mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00

Files

Russell Yanofsky 654420d6df wallet: Minimal fix to restore conflicted transaction notifications

This fix is a based on the fix by Antoine Riard <ariard@student.42.fr> in
https://github.com/bitcoin/bitcoin/pull/18600.

Unlike that PR, which implements some new behavior, this just restores previous
wallet notification and status behavior for transactions removed from the
mempool because they conflict with transactions in a block. The behavior was
accidentally changed in two `CWallet::BlockConnected` updates:
a31be09bfd and
7e89994133 from
https://github.com/bitcoin/bitcoin/pull/16624, causing issue
https://github.com/bitcoin/bitcoin/issues/18325.

The change here could be improved and replaced with a more comprehensive
cleanup, so it includes a detailed comment explaining future considerations.

Fixes #18325

Co-authored-by: Antoine Riard <ariard@student.42.fr>

Github-Pull: #18982
Rebased-From: b604c5c8b5

2020-06-09 21:12:38 +08:00

chain.cpp

wallet: Minimal fix to restore conflicted transaction notifications

2020-06-09 21:12:38 +08:00

chain.h

wallet: Minimal fix to restore conflicted transaction notifications

2020-06-09 21:12:38 +08:00

handler.cpp

scripted-diff: Bump copyright of files changed in 2020

2020-01-15 02:18:00 +07:00

handler.h

scripted-diff: Bump copyright of files changed in 2020

2020-01-15 02:18:00 +07:00

node.cpp

refactor: Change createWallet, fillPSBT argument order

2020-03-19 15:26:04 -05:00

node.h

refactor: Change createWallet, fillPSBT argument order

2020-03-19 15:26:04 -05:00

README.md

Suggested interfaces::Chain cleanups from #15288

2019-03-04 15:57:58 -05:00

wallet.cpp

Wallet: Replace CAddressBookData.name with GetLabel() method

2020-04-06 20:52:04 +00:00

wallet.h

Merge #18160 : gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged

2020-03-31 14:23:30 +02:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.