merge-script 5ad79b2035 Merge bitcoin/bitcoin#32593: wallet, rpc: Move (Un)LockCoin WalletBatch creation out of RPC ...

6135e0553e wallet, rpc: Move (Un)LockCoin WalletBatch creation out of RPC (Ava Chow)

Pull request description:

  If the locked coin needs to be persisted to the wallet database, insteead of having the RPC figure out when to create a WalletBatch and having LockCoin's behavior depend on it, have LockCoin take whether to persist as a parameter so it makes the batch.

  Since unlocking a persisted locked coin requires a database write as well, we need to track whether the locked coin was persisted to the wallet database so that it can erase the locked coin when necessary.

  Keeping track of whether a locked coin was persisted is also useful information for future PRs.

  Split from #32489

ACKs for top commit:
  rkrux:
    ACK 6135e05
  Sjors:
    ACK 6135e0553e
  w0xlt:
    ACK 6135e0553e

Tree-SHA512: 0e2367fc4d50c62ec41443374b64c4c5ecf679998677df47fb8776cfb44704713bc45547e32e96cd30d1dbed766f5d333efb6f10eb0e71271606638e07e61a01

2025-07-24 13:38:58 -04:00

..

fuzz

Explicitly close all AutoFiles that have been written

2025-06-16 15:33:15 +02:00

CMakeLists.txt

test: Recreate simple BnB success tests

2025-04-30 15:37:44 -07:00

coinselection_tests.cpp

test: Run simple tests at various feerates

2025-04-30 15:38:04 -07:00

coinselector_tests.cpp

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

db_tests.cpp

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

feebumper_tests.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

group_outputs_tests.cpp

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

init_test_fixture.cpp

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

init_test_fixture.h

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

init_tests.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

ismine_tests.cpp

wallet: Delete LegacySPKM

2025-05-06 16:53:16 -07:00

psbt_wallet_tests.cpp

Merge bitcoin/bitcoin#32475: wallet: Use util::Error throughout AddWalletDescriptor instead of returning nullptr for some errors

2025-05-21 14:24:39 +01:00

scriptpubkeyman_tests.cpp

wallet: Use util::Error throughout AddWalletDescriptor

2025-05-19 18:09:56 -07:00

spend_tests.cpp

refactor: Drop util::Result operator=

2024-04-25 16:08:24 -04:00

util.cpp

wallet: Use util::Error throughout AddWalletDescriptor

2025-05-19 18:09:56 -07:00

util.h

wallet: remove outdated pszSkip arg of database Rewrite func

2025-07-16 14:27:17 +05:30

wallet_crypto_tests.cpp

wallet: refactor: introduce CMasterKey::DEFAULT_DERIVE_ITERATIONS constant

2025-01-27 18:11:05 +01:00

wallet_test_fixture.cpp

Merge bitcoin/bitcoin#26715: Introduce MockableDatabase for wallet unit tests

2023-05-15 11:39:43 +01:00

wallet_test_fixture.h

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

wallet_tests.cpp

Merge bitcoin/bitcoin#32593: wallet, rpc: Move (Un)LockCoin WalletBatch creation out of RPC

2025-07-24 13:38:58 -04:00

wallet_transaction_tests.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

walletdb_tests.cpp

wallet: Delete LegacySPKM

2025-05-06 16:53:16 -07:00

walletload_tests.cpp

Remove unused IsSingleKey

2025-05-09 15:06:51 +02:00