mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-07-16 01:28:39 +02:00
1c500b1709test: avoid non-loopback network traffic from node_init_tests/init_test (Vasil Dimov) Pull request description: The test `node_init_tests/init_test` calls: `AppInitMain()` -> `StartMapPort()` -> `StartThreadMapPort()` -> `ThreadMapPort()` -> `ProcessPCP()` -> `PCPRequestPortMap()` -> `CreateSock()` and on the returned value from `CreateSock()` it calls the `Connect()` method. Thus, change `BasicTestingSetup::BasicTestingSetup()` to set `-natpmp` to 0. This way `node_init_tests/init_test` or other tests will not do network activity due to `ThreadMapPort()`. Also add a comment about `natpmp=0` in `test/functional/test_framework/util.py`. Also set `-dnsseed=0` in `BasicTestingSetup::BasicTestingSetup()` to avoid DNS queries. ACKs for top commit: fjahr: re-ACK1c500b1709ryanofsky: Code review ACK1c500b1709, just disabling -dnsseed since previous review, which makes sense. Tree-SHA512: 3b275d91361804da6d1dc109dffe741ea4b3dd3be916eb12fa63efa233e13ea4dab5a9f8448bd8bf99bc41817f3b7a768abe91531a3f63eae8b4c912bfcbd13e