mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-19 14:53:43 +01:00
8c12fe828d
c495731a31fuzz: wallet: add target for `CreateTransaction` (brunoerg)3db68e29ecwallet: move `ImportDescriptors`/`FuzzedWallet` to util (brunoerg) Pull request description: This PR adds a fuzz target for the `CreateTransaction` function. It is a regression target for https://github.com/bitcoin/bitcoin/pull/27271 and can be testing by applying: ```diff @@ -1110,7 +1110,7 @@ static util::Result<CreatedTransactionResult> CreateTransactionInternal( // This can only happen if feerate is 0, and requested destinations are value of 0 (e.g. OP_RETURN) // and no pre-selected inputs. This will result in 0-input transaction, which is consensus-invalid anyways if (selection_target == 0 && !coin_control.HasSelected()) { - return util::Error{_("Transaction requires one destination of non-0 value, a non-0 feerate, or a pre-selected input")}; + // return util::Error{_("Transaction requires one destination of non-0 value, a non-0 feerate, or a pre-selected input")}; } ``` Also, it moves `ImportDescriptors` function to `src/wallet/test/util.h` to avoid to duplicate same code. ACKs for top commit: marcofleon: ACKc495731a31maflcko: ACKc495731a31🏻 Tree-SHA512: a439f947b91b01e327e18cd18e63d5ce49f2cb9ca16ca9d56fe337b8cff239b3af4db18fe89478fe5faa5549d37ca935bd321913db7646fbf6818f825cb5d878