highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-05-17 17:33:59 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
eefe4bacdd2ba3e728bae939c7c680258b8f5993
bitcoin/src
History
Ava Chow eefe4bacdd Merge bitcoin/bitcoin#29027: wallet: fix key parsing check for miniscript expressions 
e1281f1bbd wallet: fix key parsing check for miniscript expressions in `ParseScript` (brunoerg)

Pull request description:

  In `ParseScript`, when processing miniscript expressions, the way we check for key parsing error is wrong, the actual code is unreachable because we're checking it into `if (node)` (successful parsing) statement.

ACKs for top commit:
  sipa:
    utACK e1281f1bbd
  RandyMcMillan:
    utACK e1281f1bbd
  achow101:
    ACK e1281f1bbd

Tree-SHA512: c4b3765d32673928a1f6d84ecbaa311870da9a9625753ed15ea57c802a9f16ddafa48c1dc66c0e4be284c5862e7821ed94135498ed9b9f3d7342a080035da289
2023-12-21 12:06:35 -05:00
..
bench
Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup
2023-12-14 16:46:54 -05:00
common
ArgsManager: return path by value from GetBlocksDirPath()
2023-12-11 17:42:17 +01:00
compat
…
config
…
consensus
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
crc32c
…
crypto
…
index
refactor: Remove calls to StartShutdown from KernelNotifications
2023-12-04 15:39:15 -04:00
init
refactor: Add InitContext function to initialize NodeContext with global pointers
2023-12-04 15:39:15 -04:00
interfaces
wallet, mempool: propagete checkChainLimits error message to wallet
2023-12-17 21:13:44 +01:00
ipc
…
kernel
Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-04 15:39:15 -04:00
leveldb
…
logging
…
minisketch
…
node
wallet, mempool: propagete checkChainLimits error message to wallet
2023-12-17 21:13:44 +01:00
policy
Add multiplication operator to CFeeRate
2023-12-09 09:33:45 -05:00
primitives
Merge bitcoin/bitcoin#28766: Improve peformance of CTransaction::HasWitness (28107 follow-up)
2023-11-28 08:44:41 -05:00
qt
Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup
2023-12-14 16:46:54 -05:00
rpc
Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup
2023-12-14 16:46:54 -05:00
script
wallet: fix key parsing check for miniscript expressions in ParseScript
2023-12-08 06:54:00 -03:00
secp256k1
…
support
pool: make sure PoolAllocator uses the correct alignment
2023-11-19 18:43:29 +01:00
test
Merge bitcoin/bitcoin#29027: wallet: fix key parsing check for miniscript expressions
2023-12-21 12:06:35 -05:00
univalue
…
util
Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup
2023-12-14 16:46:54 -05:00
wallet
Merge bitcoin/bitcoin#28372: fuzz: coinselection, improve min_viable_change/change_output_size
2023-12-20 19:45:41 -05:00
zmq
CValidationInterface: modify the parameter of TransactionAddedToMempool
2023-11-22 11:48:21 +01:00
.bear-tidy-config
…
.clang-format
build: Require C++20 compiler
2023-12-07 11:05:33 +01:00
.clang-tidy
…
addrdb.cpp
…
addrdb.h
…
addresstype.cpp
…
addresstype.h
…
addrman_impl.h
…
addrman.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
addrman.h
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
arith_uint256.cpp
refactor: Remove unused and fragile string interface from arith_uint256
2023-11-21 17:37:25 +01:00
arith_uint256.h
refactor: Remove unused and fragile string interface from arith_uint256
2023-11-21 17:37:25 +01:00
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
refactor: Add NodeContext::shutdown member
2023-12-04 15:39:15 -04:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
doc: Update bitcoin-tx replaceable documentation
2023-12-11 13:08:46 -05:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-04 15:39:15 -04:00
blockencodings.cpp
serialize: Drop useless version param from GetSerializeSize()
2023-11-16 11:14:13 +10:00
blockencodings.h
…
blockfilter.cpp
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
blockfilter.h
…
chain.cpp
…
chain.h
…
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
Use Txid in COutpoint
2023-11-21 13:15:44 +00:00
coins.h
Merge bitcoin/bitcoin#28922: Use Txid in COutpoint
2023-11-24 14:41:58 +00:00
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
Remove unused version.h include
2023-11-30 11:28:19 +01:00
external_signer.h
…
flatfile.cpp
…
flatfile.h
…
hash.cpp
…
hash.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
refactor: Remove call to ShutdownRequested from HTTPRequest
2023-12-04 15:39:15 -04:00
httpserver.h
refactor: Remove call to ShutdownRequested from HTTPRequest
2023-12-04 15:39:15 -04:00
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#28051: Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-14 15:14:00 -05:00
init.h
Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-04 15:39:15 -04:00
key_io.cpp
…
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
…
logging.h
…
Makefile.am
Merge bitcoin/bitcoin#28051: Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-14 15:14:00 -05:00
Makefile.bench.include
bench: add benchmark for wallet creation procedure
2023-11-16 11:27:17 -03:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
…
Makefile.qttest.include
…
Makefile.test_fuzz.include
fuzz: move MockedDescriptorConverter to fuzz/util
2023-11-20 15:57:50 -03:00
Makefile.test_util.include
…
Makefile.test.include
fuzz: add target for DescriptorScriptPubKeyMan
2023-11-20 15:57:56 -03:00
Makefile.univalue.include
…
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
refactor: Use Txid in CMerkleBlock
2023-11-28 17:49:41 +01:00
merkleblock.h
refactor: Use Txid in CMerkleBlock
2023-11-28 17:49:41 +01:00
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
fuzz: Improve fuzzing stability for txorphan harness
2023-12-08 13:14:46 +00:00
net_processing.h
refactor: P2P transport without serialize version and type
2023-11-23 13:43:39 +01:00
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
net.h
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
netaddress.cpp
…
netaddress.h
…
netbase.cpp
…
netbase.h
…
netgroup.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
netgroup.h
net: Add continuous ASMap health check logging
2023-12-02 22:03:08 +01:00
netmessagemaker.h
refactor: NetMsg::Make() without nVersion
2023-11-20 14:02:27 +01:00
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
Remove unused version.h include
2023-11-30 11:28:19 +01:00
psbt.h
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
pubkey.cpp
…
pubkey.h
…
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
refactor: rpc: Pass CBlockIndex by reference instead of pointer
2023-12-07 12:05:21 +01:00
rest.h
…
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
Remove unused SER_NETWORK, SER_DISK
2023-11-30 11:28:17 +01:00
signet.cpp
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
signet.h
…
span.h
…
streams.cpp
…
streams.h
Remove unused CDataStream
2023-11-30 11:27:54 +01:00
sync.cpp
…
sync.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
…
txdb.h
…
txmempool.cpp
wallet, mempool: propagete checkChainLimits error message to wallet
2023-12-17 21:13:44 +01:00
txmempool.h
[doc]: add doxygen return comment for CheckPackageLimits
2023-12-19 17:12:45 +01:00
txorphanage.cpp
fuzz: Improve fuzzing stability for txorphan harness
2023-12-08 13:14:46 +00:00
txorphanage.h
fuzz: Improve fuzzing stability for txorphan harness
2023-12-08 13:14:46 +00:00
txrequest.cpp
refactor: modernize-use-default-member-init for bit-fields (C++20)
2023-12-07 11:06:01 +01:00
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
validation.cpp
wallet, mempool: propagete checkChainLimits error message to wallet
2023-12-17 21:13:44 +01:00
validation.h
Merge bitcoin/bitcoin#26762: bugfix: Make CCheckQueue RAII-styled (attempt 2)
2023-11-30 14:28:46 -05:00
validationinterface.cpp
CValidationInterface: modify the parameter of TransactionAddedToMempool
2023-11-22 11:48:21 +01:00
validationinterface.h
CValidationInterface: modify the parameter of TransactionAddedToMempool
2023-11-22 11:48:21 +01:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…