mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-05-15 00:14:08 +02:00
Replace the sign, finalize , bip32derivs and sighash_type arguments which are passed to FillPSBT() and SignPSBTInput() with a PSBTFillOptions struct. This makes it easier to add additional options later without large code churn, such as avoid_script_path proposed in #32857. It also makes the use of default boolean options safer compared to positional arguments that can easily get mixed up.
43 lines
1.6 KiB
C++
43 lines
1.6 KiB
C++
// Copyright (c) 2019-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_WALLET_EXTERNAL_SIGNER_SCRIPTPUBKEYMAN_H
|
|
#define BITCOIN_WALLET_EXTERNAL_SIGNER_SCRIPTPUBKEYMAN_H
|
|
|
|
#include <wallet/scriptpubkeyman.h>
|
|
|
|
#include <memory>
|
|
#include <util/result.h>
|
|
|
|
struct bilingual_str;
|
|
|
|
namespace wallet {
|
|
class ExternalSignerScriptPubKeyMan : public DescriptorScriptPubKeyMan
|
|
{
|
|
public:
|
|
ExternalSignerScriptPubKeyMan(WalletStorage& storage, WalletDescriptor& descriptor, int64_t keypool_size)
|
|
: DescriptorScriptPubKeyMan(storage, descriptor, keypool_size)
|
|
{}
|
|
ExternalSignerScriptPubKeyMan(WalletStorage& storage, int64_t keypool_size)
|
|
: DescriptorScriptPubKeyMan(storage, keypool_size)
|
|
{}
|
|
|
|
/** Provide a descriptor at setup time
|
|
* Returns false if already setup or setup fails, true if setup is successful
|
|
*/
|
|
bool SetupDescriptor(WalletBatch& batch, std::unique_ptr<Descriptor>desc);
|
|
|
|
static util::Result<ExternalSigner> GetExternalSigner();
|
|
|
|
/**
|
|
* Display address on the device and verify that the returned value matches.
|
|
* @returns nothing or an error message
|
|
*/
|
|
util::Result<void> DisplayAddress(const CTxDestination& dest, const ExternalSigner& signer) const;
|
|
|
|
std::optional<common::PSBTError> FillPSBT(PartiallySignedTransaction& psbt, const PrecomputedTransactionData& txdata, const common::PSBTFillOptions& options, int* n_signed = nullptr) const override;
|
|
};
|
|
} // namespace wallet
|
|
#endif // BITCOIN_WALLET_EXTERNAL_SIGNER_SCRIPTPUBKEYMAN_H
|