highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-12 12:53:31 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
merge-script 825f4a64e6
Merge bitcoin/bitcoin#22976: scripted-diff: Rename overloaded int GetArg to GetIntArg 
93b9800fec588fc0c258e754405db1e9f89cfb81 scripted-diff: Rename overloaded int GetArg to GetIntArg (Russell Yanofsky)

Pull request description:

  This is meant to improve readability of code and remove guesswork needed to determine argument types and migrate to [typed arguments (#22978)](https://github.com/bitcoin/bitcoin/issues/22978) by having distinctly named `GetArg` `GetArgs` `GetBoolArg` and `GetIntArg` methods.

  ---

  This commit was originally part of #22766 and had some review discussion there. But it was [wisely suggested](https://github.com/bitcoin/bitcoin/pull/22766#issuecomment-910001542) to be split off  to make that PR smaller.

ACKs for top commit:
  hebasto:
    ACK 93b9800fec588fc0c258e754405db1e9f89cfb81.
  MarcoFalke:
    re-ACK 93b9800fec588fc0c258e754405db1e9f89cfb81 📨

Tree-SHA512: e034bd938b2c8fbadd90bcd52213a61161965dfddf18c2cb0d68816ecf2438cde8afee6fb7e3418f5c6b35c208338da9deb99e4e418dbf68ca34552e0916a625
2021-09-27 15:13:09 +02:00
..
bench
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
compat
compat: remove glibc_compat.cpp
2021-09-10 11:18:58 +08:00
config
…
consensus
consensus/params: simplify ValidDeployment check to avoid gcc warning
2021-08-02 23:48:32 +10:00
crc32c
…
crypto
[crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD
2021-06-23 09:46:38 -07:00
index
Remove txindex migration code
2021-08-20 16:59:41 +02:00
init
Start using init makeNode, makeChain, etc methods
2021-08-17 03:05:15 -05:00
interfaces
Make GUI UTXO lock/unlock persistent
2021-09-25 23:50:06 +12:00
ipc
…
leveldb
…
logging
Make unexpected time type in BCLog::LogMsg() a compile-time error
2021-09-07 19:19:31 +02:00
node
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
policy
add missing includes in policy/rbf
2021-09-20 13:34:48 +01:00
primitives
…
qt
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
rpc
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
script
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
secp256k1
Update secp256k1 subtree to latest upstream + adapt API
2021-07-14 14:43:45 -07:00
support
…
test
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
univalue
…
util
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
wallet
Merge bitcoin/bitcoin#22976: scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 15:13:09 +02:00
zmq
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
.clang-format
…
.clang-tidy
Enable clang-tidy bugprone-argument-comment and fix violations
2021-09-07 09:11:10 +02:00
addrdb.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
addrdb.h
Raise InitError when peers.dat is invalid or corrupted
2021-09-09 09:20:43 +02:00
addrman.cpp
addrman: Replace assert with throw on corrupt data
2021-09-21 10:09:45 +02:00
addrman.h
Refactor: Turn the internal addrman check helper into a forced check
2021-09-21 10:07:48 +02:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
Ignore banlist.dat
2021-07-30 11:21:51 +02:00
banman.h
Ignore banlist.dat
2021-07-30 11:21:51 +02:00
base58.cpp
…
base58.h
…
bech32.cpp
Add references for the generator/constant used in Bech32(m)
2021-08-20 15:49:50 -04:00
bech32.h
…
bitcoin-cli-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-cli.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
bitcoin-tx-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-tx.cpp
Replace use of boost::trim_right with locale-independent TrimString
2021-09-02 13:19:42 +08:00
bitcoin-util-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-wallet.cpp
…
bitcoind-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoind.cpp
…
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
chain: add BLOCK_ASSUMED_VALID for use with assumeutxo
2021-09-15 15:46:44 -04:00
chainparams.cpp
Merge bitcoin/bitcoin#23021: net: switch to signet DNS seed
2021-09-27 14:48:33 +02:00
chainparams.h
net: distinguish default port per network
2021-07-09 11:19:36 +02:00
chainparamsbase.cpp
test: Activate all regtest softforks at height 1, unless overridden
2021-09-16 18:53:04 +02:00
chainparamsbase.h
…
chainparamsseeds.h
contrib, p2p: update I2P hardcoded seeds
2021-07-30 11:03:44 +02:00
checkqueue.h
…
clientversion.cpp
wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump
2021-08-16 16:04:47 +08:00
clientversion.h
wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump
2021-08-16 16:04:47 +08:00
coins.cpp
…
coins.h
…
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentinfo.h
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentstatus.cpp
consensus/params: simplify ValidDeployment check to avoid gcc warning
2021-08-02 23:48:32 +10:00
deploymentstatus.h
Use DeploymentEnabled to hide VB deployments
2021-07-01 20:20:52 +02:00
dummywallet.cpp
Merge bitcoin/bitcoin#22219: multiprocess: Start using init makeNode, makeChain, etc methods
2021-09-16 08:47:38 +08:00
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
…
flatfile.h
…
fs.cpp
Merge bitcoin/bitcoin#20586: Fix Windows build with --enable-werror
2021-08-27 08:31:45 +02:00
fs.h
…
hash.cpp
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
hash.h
…
httprpc.cpp
Replace use of boost::trim use with locale-independent TrimString
2021-09-02 13:17:46 +08:00
httprpc.h
…
httpserver.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
httpserver.h
…
i2p.cpp
net: do not connect to I2P hosts on port!=0
2021-07-09 11:19:37 +02:00
i2p.h
…
indirectmap.h
…
init.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
init.h
init: remove straggling boost thread_group code
2021-07-12 21:46:59 +08:00
key_io.cpp
…
key_io.h
…
key.cpp
Stricter BIP32 decoding and test vector 5
2021-08-30 12:02:04 -04:00
key.h
doc: Remove stale comment for CPrivKey
2021-09-16 21:16:39 +09:00
logging.cpp
log, sync: add LOCK logging category, apply it to lock contention
2021-08-18 19:57:15 +02:00
logging.h
log, sync: add LOCK logging category, apply it to lock contention
2021-08-18 19:57:15 +02:00
Makefile.am
build: remove glibc-back-compat from build system
2021-09-10 11:18:58 +08:00
Makefile.bench.include
bench: add peer eviction protection benchmarks
2021-07-08 12:28:23 +02:00
Makefile.crc32c.include
…
Makefile.leveldb.include
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
Makefile.qt_locale.include
…
Makefile.qt.include
Start using init makeNode, makeChain, etc methods
2021-08-17 03:05:15 -05:00
Makefile.qttest.include
Start using init makeNode, makeChain, etc methods
2021-08-17 03:05:15 -05:00
Makefile.test_fuzz.include
…
Makefile.test_util.include
move-only: unittest: add test/util/chainstate.h
2021-09-15 15:46:48 -04:00
Makefile.test.include
fuzz: Move all addrman fuzz targets to one file
2021-09-21 10:09:56 +02:00
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
miner.h
…
net_permissions.cpp
…
net_permissions.h
Rate limit the processing of incoming addr messages
2021-07-15 12:52:38 -07:00
net_processing.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
net_processing.h
Merge bitcoin/bitcoin#22577: Close minor startup race between main and scheduler threads
2021-08-04 16:37:12 +02:00
net_types.cpp
MOVEONLY: Expose BanMapToJson / BanMapFromJson
2021-09-03 05:21:58 -04:00
net_types.h
MOVEONLY: Expose BanMapToJson / BanMapFromJson
2021-09-03 05:21:58 -04:00
net.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
net.h
Merge bitcoin/bitcoin#22911: [net] Minor cleanups to asmap
2021-09-10 14:04:16 +08:00
netaddress.cpp
[asmap] Remove SanityCheckASMap() from netaddress
2021-09-07 13:31:10 +01:00
netaddress.h
[asmap] Remove SanityCheckASMap() from netaddress
2021-09-07 13:31:10 +01:00
netbase.cpp
Cleanup headers after #20788
2021-09-11 10:47:02 +03:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
outputtype.h
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
doc: Remove incorrect INIT_PROTO_VERSION from nTime comment
2021-08-23 18:53:34 +02:00
psbt.cpp
…
psbt.h
…
pubkey.cpp
Merge bitcoin/bitcoin#22836: Stricter BIP32 decoding and test vector 5
2021-09-02 10:41:16 +08:00
pubkey.h
Consolidate XOnlyPubKey lookup hack
2021-08-23 21:38:34 -04:00
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
shutdown.cpp
…
shutdown.h
…
signet.cpp
Enable clang-tidy bugprone-argument-comment and fix violations
2021-09-07 09:11:10 +02:00
signet.h
…
span.h
…
streams.h
…
sync.cpp
sync: inline lock contention logging macro to fix time duration
2021-09-06 23:43:51 +02:00
sync.h
sync: inline lock contention logging macro to fix time duration
2021-09-06 23:43:51 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
timedata.h
…
tinyformat.h
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
torcontrol.cpp
torcontrol: Resolve Tor control plane address
2021-06-27 19:27:25 +02:00
torcontrol.h
…
txdb.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
txdb.h
Remove txindex migration code
2021-08-20 16:59:41 +02:00
txmempool.cpp
Use C++11 member initializer in CTxMemPoolEntry
2021-09-21 16:04:27 +02:00
txmempool.h
Use C++11 member initializer in CTxMemPoolEntry
2021-09-21 16:04:27 +02:00
txorphanage.cpp
…
txorphanage.h
[net processing] Add Orphanage empty consistency check
2021-07-20 13:12:42 +01:00
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
validation.h
Merge bitcoin/bitcoin#21526: validation: UpdateTip/CheckBlockIndex assumeutxo support
2021-09-23 22:22:07 +02:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
versionbits.h
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…