mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00

Files

Wladimir J. van der Laan 694f4cbd78 Merge #18312 : wallet: remove deprecated fee bumping by totalFee

c3857c5fcb wallet: remove CreateTotalBumpTransaction() (Jon Atack)
4a0b27bb01 wallet: remove totalfee from createBumpTransaction() (Jon Atack)
e347cfa9a7 rpc: remove deprecated totalFee arg from RPC bumpfee (Jon Atack)
bd05f96d79 test: delete wallet_bumpfee_totalfee_deprecation.py (Jon Atack)
a6d1ab8caa test: update bumpfee testing from totalFee to fee_rate (Jon Atack)

Pull request description:

  Since 0.19, fee-bumping using `totalFee` was deprecated in #15996 and replaced by `fee_rate` in #16727. This changeset removes it.

ACKs for top commit:
  laanwj:
    ACK c3857c5fcb

Tree-SHA512: c1bb15d664baf4d2dea06981f36384af02057d125c51fcbc8640b9d5563532187c7b84aa952f7b575255a88ce383ed4d7495bec920a47b05b6fc0d432dce1f00

2020-03-26 18:34:49 +01:00

chain.cpp

refactor: Change Chain::broadcastTransaction param order

2020-03-19 15:26:04 -05:00

chain.h

refactor: Change Chain::broadcastTransaction param order

2020-03-19 15:26:04 -05:00

handler.cpp

scripted-diff: Bump copyright of files changed in 2020

2020-01-15 02:18:00 +07:00

handler.h

scripted-diff: Bump copyright of files changed in 2020

2020-01-15 02:18:00 +07:00

node.cpp

refactor: Change createWallet, fillPSBT argument order

2020-03-19 15:26:04 -05:00

node.h

refactor: Change createWallet, fillPSBT argument order

2020-03-19 15:26:04 -05:00

README.md

Suggested interfaces::Chain cleanups from #15288

2019-03-04 15:57:58 -05:00

wallet.cpp

Merge #18312 : wallet: remove deprecated fee bumping by totalFee

2020-03-26 18:34:49 +01:00

wallet.h

Merge #18312 : wallet: remove deprecated fee bumping by totalFee

2020-03-26 18:34:49 +01:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.