4115af7Fix rebase issue where pwalletMain was used instead of pwallet Ser./Deser. nInternalChainCounter as last element (Jonas Schnelli)9382f04Do not break backward compatibility during wallet encryption (Jonas Schnelli)1df08d1Add assertion for CanSupportFeature(FEATURE_HD_SPLIT) (Jonas Schnelli)cd468d0Define CWallet::DeriveNewChildKey() as private (Jonas Schnelli)ed79e4fOptimize GetOldestKeyPoolTime(), return as soon as we have both oldest keys (Jonas Schnelli)771a304Make sure we set the wallets min version to FEATURE_HD_SPLIT at the very first point (Jonas Schnelli)1b3b5c6Slightly modify fundrawtransaction.py test (change getnewaddress() into getrawchangeaddress()) (Jonas Schnelli)003e197Remove FEATURE_HD_SPLIT bump TODO (Jonas Schnelli)d9638e5Overhaul the internal/external key derive switch (Jonas Schnelli)1090502Fix superfluous cast and code style nits in RPC wallet-hd.py test (Jonas Schnelli)58e1483CKeyPool avoid "catch (...)" in SerializationOp (Jonas Schnelli)e138876Only show keypoolsize_hd_internal if HD split is enabled (Jonas Schnelli)add38d9GetOldestKeyPoolTime: if HD & HD Chain Split is enabled, response max(oldest-internal-key, oldest-external-key) (Jonas Schnelli)dd526c2Don't switch to HD-chain-split during wallet encryption of non HD-chain-split wallets (Jonas Schnelli)79df9dfSwitch to 100% for the HD internal keypool size (Jonas Schnelli)bcafca1Make sure we always generate one keypool key at minimum (Jonas Schnelli)d0a627aFix issue where CDataStream->nVersion was taken a CKeyPool record version (Jonas Schnelli)9af8f00Make sure we hand out keypool keys if HD_SPLIT is not enabled (Jonas Schnelli)469a47bMake sure ReserveKeyFromKeyPool only hands out internal keys if HD_SPLIT is supported (Jonas Schnelli)05a9b49Fix wrong keypool internal size in RPC getwalletinfo help (Jonas Schnelli)01de822Removed redundant IsLocked() check in NewKeyPool() (Jonas Schnelli)d59531dImmediately return setKeyPool's size if HD or HD_SPLIT is disabled or not supported (Jonas Schnelli)02592f4[Wallet] split the keypool in an internal and external part (Jonas Schnelli) Tree-SHA512: 80d355d5e844b48c3163b56c788ab8b5b5285db0ceeb19858a3ef517d5a702afeca21dbae526d7b8fb4101c2a745af1d92bf557c40cf516780f17992bf678c1a
Regression tests
test_framework/authproxy.py
Taken from the python-bitcoinrpc repository.
test_framework/test_framework.py
Base class for new regression tests.
test_framework/util.py
Generally useful functions.
test_framework/mininode.py
Basic code to support p2p connectivity to a bitcoind.
test_framework/comptool.py
Framework for comparison-tool style, p2p tests.
test_framework/script.py
Utilities for manipulating transaction scripts (originally from python-bitcoinlib)
test_framework/blockstore.py
Implements disk-backed block and tx storage.
test_framework/key.py
Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)
test_framework/bignum.py
Helpers for script.py
test_framework/blocktools.py
Helper functions for creating blocks and transactions.
P2P test design notes
Mininode
-
mininode.pycontains all the definitions for objects that pass over the network (CBlock,CTransaction, etc, along with the network-level wrappers for them,msg_block,msg_tx, etc). -
P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.
-
NodeConnis the class used to connect to a bitcoind. If you implement a callback class that derives fromNodeConnCBand pass that to theNodeConnobject, your code will receive the appropriate callbacks when events of interest arrive. -
You can pass the same handler to multiple
NodeConn's if you like, or pass different ones to each -- whatever makes the most sense for your test. -
Call
NetworkThread.start()after allNodeConnobjects are created to start the networking thread. (Continue with the test logic in your existing thread.) -
RPC calls are available in p2p tests.
-
Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples:
p2p-accept-block.py,maxblocksinflight.py.
Comptool
-
Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.
-
Set the
num_nodesvariable (defined inComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then--testbinarycan be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then--refbinarycan be optionally used to change the bitcoind that will be used on nodes 2 and up. -
Implement a (generator) function called
get_tests()which yieldsTestInstances. EachTestInstanceconsists of:- a list of
[object, outcome, hash]entriesobjectis aCBlock,CTransaction, orCBlockHeader.CBlock's andCTransaction's are tested for acceptance.CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.outcomeisTrue,False, orNone. IfTrueorFalse, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. IfNoneis specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.hashis the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
sync_every_block:True/False. IfFalse, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. IfTrue, then each block is tested in sequence and synced (this is slower when processing many blocks).sync_every_transaction:True/False. Analogous tosync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. IfTrueorFalse, then only the last tx's acceptance is tested against the given outcome.
- a list of
-
For examples of tests written in this framework, see
invalidblockrequest.pyandp2p-fullblocktest.py.