MarcoFalke 171f4a516b Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase ...

d8e9ca66d1 walletdb: Move Rewrite into BerkeleyDatabase (Andrew Chow)
91d109156d walletdb: Move PeriodicFlush into WalletDatabase (Andrew Chow)
8f1bcf8b7b walletdb: Combine VerifyDatabaseFile and VerifyEnvironment (Andrew Chow)

Pull request description:

  The `BerkeleyBatch` class has 4 static functions that operate on `BerkeleyDatabase` or `BerkeleyEnvironment`. It doesn't make sense for these to be standalone nor for them to be static functions. So instead, move them from `BerkeleyBatch` into `BerkeleyDatabase` and make them member functions instead of static.

  `BerkeleyBatch::VerifyEnvironment` and `BerkeleyBatch::VerifyDatabaseFile` are combined into a single `BerkeleyDatabase::Verify` function that operates on that `BerkeleyDatabase` object.

  `BerkeleyBatch::Rewrite` and `BerkeleyBatch::PeriodicFlush` both took a `BerkeleyDatabase` as an argument and did stuff on it. So we just make it a member function so it doesn't need to take a database as an argument.

  Part of #18971

ACKs for top commit:
  MarcoFalke:
    re-ACK d8e9ca66d1 only change is test fixup 🤞
  promag:
    Code review ACK d8e9ca66d1, good stuff.

Tree-SHA512: 9847e55b13d98bf4e5636cc14bc3f5351d56737f7e320fafffaed128606240765599e5400382c5aecac06690f7e36265ca3e1031f3f6d8a9688f6d5cb1bacd2a

2020-07-05 18:06:00 -04:00

..

test

Merge #19277: util: Add Assert identity function

2020-07-04 08:44:45 -04:00

bdb.cpp

Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase

2020-07-05 18:06:00 -04:00

bdb.h

Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase

2020-07-05 18:06:00 -04:00

coincontrol.cpp

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coincontrol.h

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

amount: Move CAmount CENT to unit test header

2018-09-17 14:34:56 -04:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00

db.cpp

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

db.h

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

scripted-diff: Move ui_interface to the node lib

2020-06-27 11:49:28 -04:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

wallet: remove -salvagewallet

2020-05-25 12:39:40 -04:00

load.h

wallet: remove -salvagewallet

2020-05-25 12:39:40 -04:00

rpcdump.cpp

Merge #19114: scripted-diff: TxoutType C++11 scoped enum class

2020-06-28 14:20:00 -04:00

rpcwallet.cpp

Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO

2020-07-02 16:10:49 +02:00

rpcwallet.h

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions

2020-06-05 08:29:18 -04:00

salvage.cpp

walletdb: Combine VerifyDatabaseFile and VerifyEnvironment

2020-07-01 12:32:03 -04:00

salvage.h

Move RecoverKeysOnlyFilter into RecoverDataBaseFile

2020-05-25 12:59:29 -04:00

scriptpubkeyman.cpp

Merge #19215: psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs

2020-07-03 09:23:22 +12:00

scriptpubkeyman.h

FillPSBT: report number of inputs signed (or would sign)

2020-06-18 23:32:59 -07:00

wallet.cpp

Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase

2020-07-05 18:06:00 -04:00

wallet.h

Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO

2020-07-02 16:10:49 +02:00

walletdb.cpp

Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase

2020-07-05 18:06:00 -04:00

walletdb.h

Add Create*WalletDatabase functions

2020-06-17 12:31:29 -04:00

wallettool.cpp

walletdb: Combine VerifyDatabaseFile and VerifyEnvironment

2020-07-01 12:32:03 -04:00

wallettool.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00