bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-28 05:13:03 +02:00

History

Merge bitcoin/bitcoin#22619 : test: refactor: use consistent bytes <-> hex-string conversion in functional test framework

5a1bef60a03b57de708a1a751bd90b8245fd8b83 test: refactor: remove binascii from test_framework (Zero-1729)

Pull request description:

  This PR continues the work started in PR #22593, regarding using the `bytes` built-in module. In this PR specifically, instances of `binascii`'s methods `hexlify`, `unhexlify`,  and `a2b_hex` have been replaced with the build-in `bytes` module's `hex` and `fromhex` methods where appropriate to make bytes <-> hex-string conversions consistent across the functional test files and test_framework.

  Additionally, certain changes made are based on the following assumption:

  ```
  bytes.hex(data) == binascii.hexlify(data).decode()
  bytes.hex(data).encode() == binascii.hexlify(data)
  ```

  Ran the functional tests to ensure behaviour is still consistent and changes didn't break existing tests.

  closes #22605

ACKs for top commit:
  theStack:
    Code-review ACK 5a1bef60a03b57de708a1a751bd90b8245fd8b83 🔢

Tree-SHA512: 8f28076cf0580a0d02a156f3e1e94c9badd3d41c3fbdfb2b87cd8a761dde2c94faa5f4c448d6747b1ccc9111c3ef1a1d7b42a11c806b241fa0410b7529e2445f

2021-08-05 12:15:01 +02:00

__init__.py

…

address.py

test: refactor: remove hex_str_to_bytes helper

2021-08-01 19:26:51 +02:00

authproxy.py

test: retry when write to a socket fails on macOS

2020-06-25 17:26:20 +07:00

bdb.py

test: refactor: remove binascii from test_framework

2021-08-04 19:59:13 +01:00