mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-12 05:32:22 +02:00

Files

Ava Chow 7b6f9ba7ba Merge bitcoin/bitcoin#34672 : mining: add reason/debug to submitSolution and unify with submitBlock

75929b11ed doc: add release note for submitSolution IPC changes (woltx)
ed75d70fdb refactor: centralize SubmitBlock result handling (w0xlt)
cbaa1696f3 mining: add reason and debug output to submitSolution (w0xlt)
83f3bc002d mining: clarify SubmitBlock result handling (w0xlt)

Pull request description:

  `BlockTemplate.submitSolution` currently returns only a boolean, so IPC mining clients cannot determine why a submission failed without inspecting Bitcoin Core's debug log.

  Returning `reason` and `debug`, as `Mining.submitBlock` already does, lets callers distinguish a concrete block rejection from a duplicate or inconclusive result. Here, `inconclusive` means the method returns failure, but validation did not determine that the submitted block is invalid.

  This follow-up was suggested during the review of #34644:
  https://github.com/bitcoin/bitcoin/pull/34644#discussion_r2853758006

  This PR:

  - Extracts a shared `SubmitBlock` helper that wraps `ProcessNewBlock` with `SubmitBlockStateCatcher` to capture `BlockValidationState`
  - Adds `reason` and `debug` output parameters to `submitSolution`, matching `submitBlock`
  - Makes both methods delegate to the same helper, eliminating duplicated logic

ACKs for top commit:
  optout21:
    ACK 75929b11ed
  achow101:
    light ACK 75929b11ed
  Sjors:
    ACK 75929b11ed
  enirox001:
    ACK 75929b11ed
  sedited:
    ACK 75929b11ed

Tree-SHA512: 31b1c305c20aaebdfa2d887665d9927830d0f97ba3c3469e2792148ad799d5a400a000cc0ca0b9add071d314e27c9da44d55228c442533a32a7c031678b78a55

2026-07-22 15:50:08 -07:00

chain.h

interfaces: Add waitForNotifications() to call SyncWithValidationInterfaceQueue()

2026-02-27 12:16:35 -08:00

echo.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

handler.h

signals: re-add forward-declares to interface headers

2026-04-03 18:20:50 +00:00

init.h

ipc: Expose an RPC interface over the -ipcbind socket

2026-02-27 19:26:08 -04:00

ipc.h

bitcoin-cli: Add -ipcconnect option

2026-02-27 19:26:08 -04:00

mining.h

Merge bitcoin/bitcoin#34672 : mining: add reason/debug to submitSolution and unify with submitBlock

2026-07-22 15:50:08 -07:00

node.h

refactor: Make ThreadSafeMessageBox signal void

2026-06-11 21:31:18 +02:00

README.md

ipc: Expose an RPC interface over the -ipcbind socket

2026-02-27 19:26:08 -04:00

rpc.h

ipc: Expose an RPC interface over the -ipcbind socket

2026-02-27 19:26:08 -04:00

types.h

scripted-diff: [doc] Unify stale copyright headers

2025-12-16 22:21:15 +01:00

wallet.h

wallet: Replace CWalletTx's vOrderForm with specific fields

2026-06-27 13:01:27 -07:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #19160.
Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.
Rpc — used by bitcoin-cli to be able to call RPC methods over a unix socket instead of TCP.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.