mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-06-16 17:48:59 +02:00
f6bdbcf79d
Tests without a fixture did not have their file names linted because the grep matches on `BOOST_FIXTURE`. Updates to match `BOOST_FIXTURE` or `BOOST_TEST`. Co-authored-by: l0rinc <pap.lorinc@gmail.com>
89 lines
2.3 KiB
Python
Executable File
89 lines
2.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
#
|
|
# Copyright (c) 2018-present The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
"""
|
|
Check the test suite naming conventions
|
|
"""
|
|
|
|
import re
|
|
import subprocess
|
|
import sys
|
|
|
|
|
|
def grep_boost_test_suites():
|
|
command = [
|
|
"git",
|
|
"grep",
|
|
"-E",
|
|
r"^(BOOST_FIXTURE_TEST_SUITE|BOOST_AUTO_TEST_SUITE)\(",
|
|
"--",
|
|
"src/ipc/test/**.cpp",
|
|
"src/test/**.cpp",
|
|
"src/wallet/test/**.cpp",
|
|
]
|
|
return subprocess.check_output(command, text=True)
|
|
|
|
|
|
def check_matching_test_names(test_suite_list):
|
|
not_matching = [
|
|
x
|
|
for x in test_suite_list
|
|
if re.search(r"/(.*?)\.cpp:(?:BOOST_FIXTURE_TEST_SUITE|BOOST_AUTO_TEST_SUITE)\(\1(_[a-z0-9]+)?[,)]", x) is None
|
|
]
|
|
if len(not_matching) > 0:
|
|
not_matching = "\n".join(not_matching)
|
|
error_msg = (
|
|
"The test suite in file src/test/foo_tests.cpp should be named\n"
|
|
'`foo_tests`, or if there are multiple test suites, `foo_tests_bar`.\n'
|
|
'Please make sure the following test suites follow that convention:\n\n'
|
|
f"{not_matching}\n"
|
|
)
|
|
print(error_msg)
|
|
return 1
|
|
return 0
|
|
|
|
|
|
def get_duplicates(input_list):
|
|
"""
|
|
From https://stackoverflow.com/a/9835819
|
|
"""
|
|
seen = set()
|
|
dupes = set()
|
|
for x in input_list:
|
|
if x in seen:
|
|
dupes.add(x)
|
|
else:
|
|
seen.add(x)
|
|
return dupes
|
|
|
|
|
|
def check_unique_test_names(test_suite_list):
|
|
output = [re.search(r"\((.*?)[,)]", x) for x in test_suite_list]
|
|
output = [x.group(1) for x in output if x is not None]
|
|
output = get_duplicates(output)
|
|
output = sorted(list(output))
|
|
|
|
if len(output) > 0:
|
|
output = "\n".join(output)
|
|
error_msg = (
|
|
"Test suite names must be unique. The following test suite names\n"
|
|
f"appear to be used more than once:\n\n{output}"
|
|
)
|
|
print(error_msg)
|
|
return 1
|
|
return 0
|
|
|
|
|
|
def main():
|
|
test_suite_list = grep_boost_test_suites().splitlines()
|
|
exit_code = check_matching_test_names(test_suite_list)
|
|
exit_code |= check_unique_test_names(test_suite_list)
|
|
sys.exit(exit_code)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|