mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 13:42:10 +02:00
fab74a0e92refactor: Use C++14 digit separator for large int literals (MarcoFalke)fae759be79scripted-diff: Use inline constexpr over plain constexpr (MarcoFalke)fa74f58a26scripted-diff: Use inline const over (static) const (MarcoFalke)fab1a62c87refactor: Use inline constexpr for string literals in headers (MarcoFalke)fa08bbed8dcontrib: Adjust generate-seeds.py to write inline constexpr (MarcoFalke)fad753611bscripted-diff: Use inline constexpr over (static) const (MarcoFalke)faedb52583refactor: Make CFeeRate(integral) ctor constexpr (MarcoFalke)5555d5dcb5scripted-diff: Use inline constexpr over static constexpr (MarcoFalke)fa6e1a1e85refactor: Remove static from constexpr functions in headers (MarcoFalke) Pull request description: Both are fine and this refactor doesn't change any behavior. However, `inline constexpr` from C++17 will ensure each symbol has a single address across all TU, making the release binary minimally smaller. (For me it is smaller by about 1kB) ACKs for top commit: l0rinc: reACKfab74a0e92rustaceanrob: ACKfab74a0e92hebasto: ACKfab74a0e92, I have reviewed the code and it looks OK. Tree-SHA512: 6ec94136c12bcbf696812d0661c9857318a69e367c79fc00b9ca0b4068f269d10e5548d95c9ba2070225308c12d7a54fe8cb8447de7e0979cba99f48892b35f9
Test library
This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).
Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.
The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common
defines the common test setup for all test binaries. The test binaries will handle the global state when they
instantiate the BasicTestingSetup (or one of its derived classes).