highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-14 23:37:51 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
fa00c7c7a415406d21c665ecda01b217351d0b40
bitcoin/src/test/fuzz
History
merge-script 278b9e39df Merge bitcoin/bitcoin#34934: fuzz: exercise ForNode/ForEachNode callbacks in connman fuzz harness 
371eac8069 fuzz: exercise ForNode/ForEachNode callbacks in connman fuzz harness (frankomosh)

Pull request description:

  Track inserted node IDs and sometimes reuse them in `ForNode()` so the successful lookup path is exercised more reliably. Replace no-op callbacks with lightweight CNode accessor calls to make `ForEachNode()` and `ForNode()` cover previously unreached callback code paths.

  This addresses feedback from https://github.com/bitcoin/bitcoin/pull/34830#issuecomment-4074732710  where it was noted that the callbacks had "neither the return type checked nor its side-effect”.

  Coverage reports from the connman fuzz corpus, before and after the change:

  - [Before](https://frankomosh.github.io/fuzz-coverage/connman-callback-coverage/before/index.html)
  - [After](https://frankomosh.github.io/fuzz-coverage/connman-callback-coverage/after/index.html)

  `diff cov_show_before.txt cov_show_after.txt` filtered to `ForNode`/`ForEachNode`/`IsFullOutboundConn`/`ConnectionTypeAsString`:

  **`IsFullOutboundConn` — `net.h:786-788`**
  ```diff
  -  786|      0|    bool IsFullOutboundConn() const {
  -  787|      0|        return m_conn_type == ConnectionType::OUTBOUND_FULL_RELAY;
  -  788|      0|    }
  +  786|  1.13M|    bool IsFullOutboundConn() const {
  +  787|  1.13M|        return m_conn_type == ConnectionType::OUTBOUND_FULL_RELAY;
  +  788|  1.13M|    }
  ```

  **`ConnectionTypeAsString` — `net.h:967`**
  ```diff
  -  967|      0|    std::string ConnectionTypeAsString() const { return ::ConnectionTypeAsString(m_conn_type); }
  +  967|  1.11M|    std::string ConnectionTypeAsString() const { return ::ConnectionTypeAsString(m_conn_type); }
  ```

  **`ForNode` — `net.cpp:4126-4131`**
  ```diff
  -  4126|  1.08k|        if(pnode->GetId() == id) {
  -    |  Branch (4126:12): [True: 0, False: 1.08k]
  -  4127|      0|            found = pnode;
  -  4131|     39|    return found != nullptr && NodeFullyConnected(found) && func(found);
  -                                              ^0                          ^0
  +  4126|    602|        if(pnode->GetId() == id) {
  +    |  Branch (4126:12): [True: 1, False: 601]
  +  4127|      1|            found = pnode;
  +  4131|     28|    return found != nullptr && NodeFullyConnected(found) && func(found);
  +                                              ^1                          ^1
  ```

  **`ForEachNode` — `net.h:1270-1271`**
  ```diff
  -  1270|  1.13M|            if (NodeFullyConnected(node))
  -    |  Branch (1270:17): [True: 0, False: 1.13M]
  -  1271|      0|                func(node);
  +  1270|  1.11M|            if (NodeFullyConnected(node))
  +    |  Branch (1270:17): [True: 1.11M, False: 0]
  +  1271|  1.11M|                func(node);
  ```

  Two previously uncovered functions (`IsFullOutboundConn`, `ConnectionTypeAsString`) are now exercised through the iteration callbacks. `ForNode` finds matching nodes.

ACKs for top commit:
  nervana21:
    tACK 371eac8069
  maflcko:
    lgtm ACK 371eac8069

Tree-SHA512: 3587c021b16e38ca252676a21b66c5383ab2bd3eec9073e61e9a93db7ef84a94ce5a0c037ac512483680cafabb44103b86df0893e8a9b1bf63b8383bd54f4641
2026-05-19 15:32:56 +01:00
..
util
iwyu, doc: Document IWYU pragma: export for <threadsafety.h>
2026-03-20 15:37:51 +00:00
addition_overflow.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addrman.cpp
fuzz: Use time helpers in node_eviction
2026-03-25 16:55:18 +01:00
asmap_direct.cpp
refactor: Simplify Interpret asmap function
2026-01-20 23:59:43 +01:00
asmap.cpp
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
autofile.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.cpp
fuzz: Use NodeClockContext
2026-03-10 11:01:37 +01:00
base_encode_decode.cpp
psbt: Remove default constructor
2026-04-29 14:51:47 -07:00
bech32.cpp
string: replace AsciiCaseInsensitiveKeyEqual with CaseInsensitiveEqual
2026-04-08 16:08:54 -04:00
bip324.cpp
…
bitdeque.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bitset.cpp
…
block_header.cpp
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
block_index_tree.cpp
Change CChain::FindFork() to take ref
2026-04-20 08:55:51 +02:00
block_index.cpp
refactor: use _MiB consistently for Mebibyte conversions
2026-04-20 11:15:41 +02:00
block.cpp
refactor: Use SpanReader over DataStream
2026-02-06 07:56:57 +01:00
blockfilter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bloom_filter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
buffered_file.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chain.cpp
validation: remove BLOCK_FAILED_MASK
2026-02-17 21:40:46 +05:30
checkqueue.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cluster_linearize.cpp
feefrac: drop comparison and operator{<<,>>} for sorted wrappers
2026-02-27 08:37:33 -05:00
CMakeLists.txt
fuzz: initial compact block fuzz harness
2026-04-27 11:23:25 -04:00
cmpctblock.cpp
Merge bitcoin/bitcoin#34860: mining: always pad scriptSig at low heights, drop include_dummy_extranonce
2026-05-17 13:26:23 -04:00
coins_view.cpp
coins: add explicit CoinsViewEmpty noop backend
2026-04-08 22:36:13 +02:00
coinscache_sim.cpp
test: fix P2SH output in coins cache fuzz
2026-05-06 09:39:07 +02:00
connman.cpp
fuzz: exercise ForNode/ForEachNode callbacks in connman fuzz harness
2026-05-05 10:53:04 +03:00
crypto_aes256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
crypto_aes256cbc.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
crypto_chacha20.cpp
…
crypto_chacha20poly1305.cpp
…
crypto_common.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
crypto_diff_fuzz_chacha20.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
crypto_hkdf_hmac_sha256_l32.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
crypto_poly1305.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
crypto.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cuckoocache.cpp
refactor: use _MiB consistently for Mebibyte conversions
2026-04-20 11:15:41 +02:00
decode_tx.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
descriptor_parse.cpp
test: Test that key expression indexes match key count
2026-02-02 15:20:47 -08:00
deserialize.cpp
psbt: Remove default constructor
2026-04-29 14:51:47 -07:00
difference_formatter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
eval_script.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
fee_rate.cpp
Refactor CFeeRate to use FeeFrac internally
2025-07-07 10:39:45 +02:00
feefrac.cpp
feefrac: drop comparison and operator{<<,>>} for sorted wrappers
2026-02-27 08:37:33 -05:00
feeratediagram.cpp
feefrac: drop comparison and operator{<<,>>} for sorted wrappers
2026-02-27 08:37:33 -05:00
fees.cpp
wallet, rpc:remove settxfee and paytxfee
2026-02-13 10:52:25 +01:00
flatfile.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
float.cpp
…
fuzz.cpp
test: Replace DEBUG_LOG_OUT with -printtoconsole=1
2026-03-26 14:41:57 +01:00
fuzz.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
FuzzedDataProvider.h
fuzz: pull latest FuzzedDataProvider.h from upstream
2026-01-31 08:45:10 +03:00
golomb_rice.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
headerssync.cpp
fuzz: Use NodeClockContext
2026-03-10 11:01:37 +01:00
hex.cpp
refactor: Move transaction_identifier.h to primitives
2025-08-11 16:47:51 +01:00
http_request.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
i2p.cpp
qa: Remove all instances of remove_all except test cleanup
2026-03-24 16:03:02 -07:00
integer.cpp
Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count
2026-01-20 15:47:17 -08:00
key_io.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key.cpp
policy: uncap datacarrier by default
2025-05-30 10:12:38 -04:00
kitchen_sink.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
load_external_block_file.cpp
fuzz: Use NodeClockContext
2026-03-10 11:01:37 +01:00
locale.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
merkle.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
merkleblock.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
message.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
mini_miner.cpp
fuzz: Remove unused g_setup pointers
2026-03-25 13:51:01 +01:00
miniscript.cpp
miniscript: Using Func and Expr when parsing keys, hashes, and locktimes
2026-02-02 15:20:51 -08:00
minisketch.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
muhash.cpp
refactor: Revert "disable self-assign warning for tests"
2025-10-09 20:47:25 +02:00
multiplication_overflow.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_permissions.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net.cpp
fuzz: Use NodeClockContext
2026-03-10 11:01:37 +01:00
netaddress.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
netbase_dns_lookup.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
node_eviction.cpp
refactor: Use NodeClock::time_point for m_connected
2026-04-13 09:49:13 +02:00
overflow.cpp
…
p2p_handshake.cpp
fuzz: Use NodeClockContext
2026-03-10 11:01:37 +01:00
p2p_headers_presync.cpp
fuzz: mine blocks and send headers for them in cmpctblock harness
2026-04-27 11:36:19 -04:00
p2p_transport_serialization.cpp
refactor: Use NodeClock::time_point for CNetMessage::m_time
2026-03-31 09:48:06 +02:00
package_eval.cpp
mining: drop unused include_dummy_extranonce option
2026-05-13 18:27:48 +02:00
parse_hd_keypath.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
parse_iso8601.cpp
…
parse_numbers.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
parse_script.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
parse_univalue.cpp
…
partially_downloaded_block.cpp
fuzz: Use NodeClockContext
2026-03-10 11:01:37 +01:00
pcp.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
policy_estimator_io.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
policy_estimator.cpp
Merge bitcoin/bitcoin#33629: Cluster mempool
2025-11-25 10:35:11 +00:00
poolresource.cpp
refactor: use _MiB consistently for Mebibyte conversions
2026-04-20 11:15:41 +02:00
pow.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
prevector.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
primitives_transaction.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
process_message.cpp
mining: drop unused include_dummy_extranonce option
2026-05-13 18:27:48 +02:00
process_messages.cpp
mining: drop unused include_dummy_extranonce option
2026-05-13 18:27:48 +02:00
protocol.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
psbt.cpp
fuzz: Enforce additional version invariants in PSBT fuzzer
2026-04-29 15:04:22 -07:00
random.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
rbf.cpp
Merge bitcoin/bitcoin#34669: feefrac: drop comparison and operator{<<,>>} for sorted wrappers
2026-04-30 11:35:53 -07:00
rolling_bloom_filter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
rpc.cpp
psbt: Remove default constructor
2026-04-29 14:51:47 -07:00
script_assets_test_minimizer.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
script_descriptor_cache.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
script_flags.cpp
refactor: Use SpanReader over DataStream
2026-02-06 07:56:57 +01:00
script_format.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
script_interpreter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
script_ops.cpp
fuzz: remove redundant CScript method calls from script harness
2026-04-20 21:18:03 -03:00
script_parsing.cpp
refactor: use _MiB consistently for Mebibyte conversions
2026-04-20 11:15:41 +02:00
script_sigcache.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
script_sign.cpp
refactor: use SignOptions for MutableTransactionSignatureCreator
2026-04-28 17:43:03 +02:00
script.cpp
fuzz: remove redundant CScript method calls from script harness
2026-04-20 21:18:03 -03:00
scriptnum_ops.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
secp256k1_ec_seckey_import_export_der.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
secp256k1_ecdsa_signature_parse_der_lax.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
signature_checker.cpp
script/verify_flags: make script_verify_flags type safe
2025-08-14 10:17:32 +10:00
signet.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
socks5.cpp
fuzz: Use NodeClockContext
2026-03-10 11:01:37 +01:00
span.cpp
…
string.cpp
ArgsManager: support command-specific options
2026-04-22 16:45:31 +10:00
strprintf.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
system.cpp
tests: Add some fuzz test coverage for command-specific args
2026-04-22 17:58:25 +10:00
threadpool.cpp
threadpool: make Submit return Expected instead of throwing
2026-02-17 15:02:40 -05:00
timeoffsets.cpp
…
torcontrol.cpp
fuzz: Improve torcontrol fuzz test
2026-04-03 22:00:29 +02:00
transaction.cpp
coins: add explicit CoinsViewEmpty noop backend
2026-04-08 22:36:13 +02:00
tx_in.cpp
refactor: Use SpanReader over DataStream
2026-02-06 07:56:57 +01:00
tx_out.cpp
refactor: Use SpanReader over DataStream
2026-02-06 07:56:57 +01:00
tx_pool.cpp
mining: drop unused include_dummy_extranonce option
2026-05-13 18:27:48 +02:00
txdownloadman.cpp
fuzz: Use NodeClockContext
2026-03-10 11:01:37 +01:00
txgraph.cpp
clusterlin: adopt STL ranges algorithms (refactor)
2026-02-27 08:38:01 -05:00
txorphan.cpp
fuzz: Fix txorphan timeout by limiting block weight
2026-05-14 12:32:04 +01:00
txrequest.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
util.cpp
fuzz: Use time helpers in node_eviction
2026-03-25 16:55:18 +01:00
util.h
Merge bitcoin/bitcoin#21283: Implement BIP 370 PSBTv2
2026-05-05 14:43:28 +02:00
utxo_snapshot.cpp
Merge bitcoin/bitcoin#31449: coins,refactor: Reduce getblockstats RPC UTXO overhead estimation
2026-04-20 15:52:45 -07:00
utxo_total_supply.cpp
mining: drop unused include_dummy_extranonce option
2026-05-13 18:27:48 +02:00
validation_load_mempool.cpp
fuzz: Use NodeClockContext
2026-03-10 11:01:37 +01:00
vecdeque.cpp
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
versionbits.cpp
refactor: Enable -Wswitch in exhaustive switch
2026-03-13 09:02:09 +01:00