Andrew Chow 1aedc3b6c8 Merge bitcoin/bitcoin#26618: rpc: Prevent unloading a wallet when rescanning ...

109cbb819d doc: Add release notes for #26618 (Aurèle Oulès)
b13902d2e4 rpc: Prevent unloading a wallet when rescanning (Aurèle Oulès)

Pull request description:

  Fixes #26463.

  This PR prevents a user from unloading a wallet if it is currently rescanning.

  To test:

  ```bash
  ./src/bitcoin-cli -testnet -named createwallet wallet_name=wo disable_private_keys=true
  ./src/bitcoin-cli -testnet -rpcwallet=wo importdescriptors '[{
    "desc": "addr(mmcuW74MyJUZuLnWXGQLoNXPrS9RbFz6gD)#tpnrahgc",
        "timestamp": 0,
        "active": false,
        "internal": false,
        "next": 0
  }]'
  ./src/bitcoin-cli -testnet unloadwallet wo
  error code: -4
  error message:
  Wallet is currently rescanning. Abort existing rescan or wait.

ACKs for top commit:
  achow101:
    ACK 109cbb819d
  w0xlt:
    ACK 109cbb819d
  kouloumos:
    ACK 109cbb819d
  promag:
    ACK 109cbb819d

Tree-SHA512: 15fdddf4cf9f3fa08f52069fe4a25a76e04a55bb2586b031bfb0393dce7f175dcdb52823e132a7dff6a894539beeb980a1aad2a792790be036be6977628149b2

2023-01-09 16:56:40 -05:00

..

rpc

Merge bitcoin/bitcoin#26618: rpc: Prevent unloading a wallet when rescanning

2023-01-09 16:56:40 -05:00

test

Merge bitcoin/bitcoin#23829: refactor: use braced init for integer literals instead of c style casts

2023-01-05 17:30:52 +01:00

bdb.cpp

refactor: use braced init for integer constants instead of c style casts

2023-01-03 19:31:29 -06:00

bdb.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

coincontrol.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

coincontrol.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

coinselection.cpp

Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages

2023-01-03 18:53:36 -05:00

coinselection.h

Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages

2023-01-03 18:53:36 -05:00

context.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

context.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

db.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

db.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

dump.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

external_signer_scriptpubkeyman.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

external_signer_scriptpubkeyman.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

feebumper.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

feebumper.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fees.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fees.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

init.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

interfaces.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

ismine.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

load.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

load.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

salvage.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

salvage.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

scriptpubkeyman.cpp

refactor: use braced init for integer constants instead of c style casts

2023-01-03 19:31:29 -06:00

scriptpubkeyman.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

spend.cpp

refactor: use braced init for integer constants instead of c style casts

2023-01-03 19:31:29 -06:00

spend.h

Merge bitcoin/bitcoin#26661: wallet: Coin Selection, return accurate error messages

2023-01-03 18:53:36 -05:00

sqlite.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

sqlite.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

transaction.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

transaction.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

wallet.cpp

Merge bitcoin/bitcoin#26761: wallet: fully migrate address book entries for watchonly/solvable wallets

2023-01-05 12:22:51 -05:00

wallet.h

Merge bitcoin/bitcoin#26752: wallet: Remove mempool_sequence from interface methods

2023-01-04 17:53:58 +00:00

walletdb.cpp

Merge bitcoin/bitcoin#26702: refactor: walletdb: drop unused FindWalletTx parameter and rename

2023-01-03 11:54:51 -05:00

walletdb.h

Merge bitcoin/bitcoin#26702: refactor: walletdb: drop unused FindWalletTx parameter and rename

2023-01-03 11:54:51 -05:00

wallettool.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

wallettool.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

walletutil.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

walletutil.h

Implement LegacyScriptPubKeyMan::MigrateToDescriptor

2022-08-25 16:25:53 -04:00