laanwj e8a3882e20 Merge bitcoin/bitcoin#23604: Use Sock in CNode ...

ef5014d256 style: wrap long lines in CNode creation and add some comments (Vasil Dimov)
b683491648 scripted-diff: rename CNode::cs_hSocket to CNode::m_sock_mutex (Vasil Dimov)
c41a1162ac net: use Sock in CNode (Vasil Dimov)
c5dd72e146 fuzz: move FuzzedSock earlier in src/test/fuzz/util.h (Vasil Dimov)

Pull request description:

  _This is a piece of #21878, chopped off to ease review._

  Change `CNode` to use a pointer to `Sock` instead of a bare `SOCKET`.
  This will help mocking / testing / fuzzing more code.

ACKs for top commit:
  jonatack:
    re-ACK ef5014d256 changes since last review are the removal of an unneeded dtor and the addition of a style commit
  w0xlt:
    reACK ef5014d
  PastaPastaPasta:
    utACK ef5014d256, I have reviewed the code, and believe it makes sense to merge
  theStack:
    Cod-review ACK ef5014d256

Tree-SHA512: 7f5414dd339cd2f16f7cbdc5fcec238d68b6d50072934aea10b901f409da28ff1ece6db6e899196616aa8127b8b25ab5b86d000bdcee58b4cadd7a3c1cf560c5

2022-02-04 09:24:17 +01:00

..

addition_overflow.cpp

Move AdditionOverflow to util, Add CheckedAdd with unit tests

2021-12-17 10:46:39 +01:00

addrman.cpp

fuzz: addrman fuzz tests: override-able check ratio

2022-01-11 12:08:43 +01:00

asmap_direct.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

asmap.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

autofile.cpp

Use spans of std::byte in serialize

2022-01-02 11:40:31 +01:00

banman.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

base_encode_decode.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

bech32.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

block_header.cpp

…

block.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

blockfilter.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

bloom_filter.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

buffered_file.cpp

Use spans of std::byte in serialize

2022-01-02 11:40:31 +01:00

chain.cpp

Require CBlockIndex::RaiseValidity() to hold cs_main

2022-01-25 20:43:28 +01:00

checkqueue.cpp

…

coins_view.cpp

Remove cs_main lock annotation from ChainstateManager.m_blockman

2022-01-11 05:11:00 -05:00

connman.cpp

Merge bitcoin/bitcoin#24021: Rename and move PoissonNextSend functions

2022-01-23 11:44:02 +08:00

crypto_aes256.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

crypto_aes256cbc.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

crypto_chacha20_poly1305_aead.cpp

Move AdditionOverflow to util, Add CheckedAdd with unit tests

2021-12-17 10:46:39 +01:00

crypto_chacha20.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

Refactor the chacha20 differential fuzz test

2021-12-17 23:04:04 +05:30

crypto_hkdf_hmac_sha256_l32.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

decode_tx.cpp

…

descriptor_parse.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

deserialize.cpp

fuzz: non-addrman fuzz tests: override-able check ratio

2022-01-11 12:08:44 +01:00

eval_script.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

fee_rate.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

fees.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

flatfile.cpp

…

float.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

fuzz.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

scripted-diff: rename MapIntoRange to FastRange64

2022-01-06 11:29:55 -05:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

Merge bitcoin/bitcoin#23438: refactor: Use spans of std::byte in serialize

2022-01-27 19:19:12 +01:00

key_io.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

key.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

kitchen_sink.cpp

…

load_external_block_file.cpp

…

locale.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

merkleblock.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

message.cpp

…

minisketch.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

muhash.cpp

…

multiplication_overflow.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

net_permissions.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

net.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

netaddress.cpp

…

netbase_dns_lookup.cpp

p2p, refactor: drop unused DNSLookupFn param in LookupSubnet()

2021-12-07 13:13:18 +01:00

node_eviction.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

p2p_transport_serialization.cpp

scripted-diff: Rename CNetMessage::m_command with CNetMessage::m_type

2022-01-15 20:59:19 +02:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

parse_numbers.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

parse_script.cpp

…

parse_univalue.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

policy_estimator_io.cpp

…

policy_estimator.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

pow.cpp

Move AdditionOverflow to util, Add CheckedAdd with unit tests

2021-12-17 10:46:39 +01:00

prevector.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

primitives_transaction.cpp

…

process_message.cpp

refactor: Set fSuccessfullyConnected in FillNode

2021-12-01 12:15:01 +01:00

process_messages.cpp

refactor: Set fSuccessfullyConnected in FillNode

2021-12-01 12:15:01 +01:00

protocol.cpp

…

psbt.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

random.cpp

…

rbf.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

rolling_bloom_filter.cpp

…

rpc.cpp

Merge bitcoin/bitcoin#23508: Add getdeploymentinfo RPC

2022-01-28 08:46:03 +01:00

script_assets_test_minimizer.cpp

Remove unused (and broken) functionality in SpanReader

2021-12-06 16:18:14 -05:00

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

script_flags.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

script_interpreter.cpp

…

script_ops.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

script_sigcache.cpp

…

script_sign.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

script.cpp

fuzz: Speed up script fuzz target

2022-01-27 15:38:59 +01:00

scriptnum_ops.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

Optimize CHECKSIGADD Script Validation

2022-01-19 15:21:52 -08:00

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

util: Restore GetIntArg saturating behavior

2022-01-11 19:54:36 -05:00

strprintf.cpp

…

system.cpp

…

timedata.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

torcontrol.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

transaction.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

Add src/node/* code to node:: namespace

2022-01-06 22:14:16 -05:00

txrequest.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

util.cpp

Extract CTxIn::MAX_SEQUENCE_NONFINAL constant

2022-01-26 15:10:44 +01:00

util.h

Merge bitcoin/bitcoin#23604: Use Sock in CNode

2022-02-04 09:24:17 +01:00

utxo_snapshot.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

validation_load_mempool.cpp

…

versionbits.cpp

rpc: getdeploymentinfo: include signalling info

2022-01-15 04:37:56 +10:00