mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-03-03 03:30:05 +01:00
d9c6769d03
Avoid providing the entire unit test framework dependency to tests that only require access to the HasReason utility class. E.g. reverselock_tests.cpp, sync_tests.cpp, util_check_tests.cpp, util_string_tests.cpp, and script_parse_tests.cpp only require access to HasReason and nothing else.
101 lines
3.7 KiB
C++
101 lines
3.7 KiB
C++
// Copyright (c) 2019-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
//
|
|
|
|
#include <bitcoin-build-config.h> // IWYU pragma: keep
|
|
|
|
#include <common/run_command.h>
|
|
#include <test/util/common.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <univalue.h>
|
|
#include <util/string.h>
|
|
|
|
#ifdef ENABLE_EXTERNAL_SIGNER
|
|
#include <util/subprocess.h>
|
|
#endif // ENABLE_EXTERNAL_SIGNER
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
|
|
BOOST_FIXTURE_TEST_SUITE(system_tests, BasicTestingSetup)
|
|
|
|
#ifdef ENABLE_EXTERNAL_SIGNER
|
|
|
|
BOOST_AUTO_TEST_CASE(run_command)
|
|
{
|
|
{
|
|
const UniValue result = RunCommandParseJSON({});
|
|
BOOST_CHECK(result.isNull());
|
|
}
|
|
{
|
|
#ifdef WIN32
|
|
const UniValue result = RunCommandParseJSON({"cmd.exe", "/c", "echo", "{\"success\":", "true}"}); // The command is intentionally split "incorrectly", to exactly preserve previous behavior. This is due to the cmd.exe internal echo quoting strings with spaces in it, unlike the normal 'echo' below.
|
|
#else
|
|
const UniValue result = RunCommandParseJSON({"echo", "{\"success\": true}"});
|
|
#endif
|
|
BOOST_CHECK(result.isObject());
|
|
const UniValue& success = result.find_value("success");
|
|
BOOST_CHECK(!success.isNull());
|
|
BOOST_CHECK_EQUAL(success.get_bool(), true);
|
|
}
|
|
{
|
|
// An invalid command is handled by cpp-subprocess
|
|
#ifdef WIN32
|
|
const std::string expected{"CreateProcess failed: "};
|
|
#else
|
|
const std::string expected{"execve failed: "};
|
|
#endif
|
|
BOOST_CHECK_EXCEPTION(RunCommandParseJSON({"invalid_command"}), subprocess::CalledProcessError, HasReason(expected));
|
|
}
|
|
{
|
|
// Return non-zero exit code, no output to stderr
|
|
#ifdef WIN32
|
|
const std::vector<std::string> command = {"cmd.exe", "/c", "exit 1"};
|
|
#else
|
|
const std::vector<std::string> command = {"false"};
|
|
#endif
|
|
BOOST_CHECK_EXCEPTION(RunCommandParseJSON(command), std::runtime_error, [&](const std::runtime_error& e) {
|
|
const std::string what{e.what()};
|
|
BOOST_CHECK(what.find(strprintf("RunCommandParseJSON error: process(%s) returned 1: \n", util::Join(command, " "))) != std::string::npos);
|
|
return true;
|
|
});
|
|
}
|
|
{
|
|
// Return non-zero exit code, with error message for stderr
|
|
#ifdef WIN32
|
|
const std::vector<std::string> command = {"cmd.exe", "/c", "echo err 1>&2 && exit 1"};
|
|
#else
|
|
const std::vector<std::string> command = {"sh", "-c", "echo err 1>&2 && false"};
|
|
#endif
|
|
const std::string expected{"err"};
|
|
BOOST_CHECK_EXCEPTION(RunCommandParseJSON(command), std::runtime_error, [&](const std::runtime_error& e) {
|
|
const std::string what(e.what());
|
|
BOOST_CHECK(what.find(strprintf("RunCommandParseJSON error: process(%s) returned %s: %s", util::Join(command, " "), 1, "err")) != std::string::npos);
|
|
BOOST_CHECK(what.find(expected) != std::string::npos);
|
|
return true;
|
|
});
|
|
}
|
|
{
|
|
// Unable to parse JSON
|
|
#ifdef WIN32
|
|
const std::vector<std::string> command = {"cmd.exe", "/c", "echo {"};
|
|
#else
|
|
const std::vector<std::string> command = {"echo", "{"};
|
|
#endif
|
|
BOOST_CHECK_EXCEPTION(RunCommandParseJSON(command), std::runtime_error, HasReason("Unable to parse JSON: {"));
|
|
}
|
|
#ifndef WIN32
|
|
{
|
|
// Test stdin
|
|
const UniValue result = RunCommandParseJSON({"cat"}, "{\"success\": true}");
|
|
BOOST_CHECK(result.isObject());
|
|
const UniValue& success = result.find_value("success");
|
|
BOOST_CHECK(!success.isNull());
|
|
BOOST_CHECK_EQUAL(success.get_bool(), true);
|
|
}
|
|
#endif
|
|
}
|
|
#endif // ENABLE_EXTERNAL_SIGNER
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|