merge-script d0b8d445fb Merge bitcoin/bitcoin#35455: fuzz: improve dbwrapper_concurrent_reads performance ...

1ce9e26239 fuzz: improve dbwrapper_concurrent_reads performance (Andrew Toth)

Pull request description:

  The recently merged fuzz harness targeting concurrent reads suffers from poor performance and memory leaks (https://github.com/bitcoin/bitcoin/pull/34866#issuecomment-4614323925).

  Fix this by
  - using a global thread pool instead of a local one per iteration
  - reduce thread count to 8 from 16
  - use a std::map oracle to check results inline instead of reading from the db to get a baseline and storing results

ACKs for top commit:
  marcofleon:
    reACK 1ce9e26239
  l0rinc:
    ACK 1ce9e26239
  sedited:
    ACK 1ce9e26239

Tree-SHA512: 2e532caf246f389105e4a9b487496386d1fe9add7b27fba9ecbbf51a432ef493765ad7095288dd7e0a896860ff150d89ecb6afb8baf311a4af94d8e01b77dba5

2026-06-11 09:47:12 +02:00

..

util

Merge bitcoin/bitcoin#35478: fuzz: reset the mockable steady clock between iterations

2026-06-10 17:05:07 +02:00

addition_overflow.cpp

…

addrman.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

asmap_direct.cpp

refactor: Simplify Interpret asmap function

2026-01-20 23:59:43 +01:00

asmap.cpp

refactor: Use span instead of vector for data in util/asmap

2026-01-20 23:59:41 +01:00

autofile.cpp

…

banman.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

base_encode_decode.cpp

psbt: Remove default constructor

2026-04-29 14:51:47 -07:00

bech32.cpp

string: replace AsciiCaseInsensitiveKeyEqual with CaseInsensitiveEqual

2026-04-08 16:08:54 -04:00

bip324.cpp

…

bitdeque.cpp

…

bitset.cpp

…

block_header.cpp

…

block_index_tree.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

block_index.cpp

refactor: use _MiB consistently for Mebibyte conversions

2026-04-20 11:15:41 +02:00

block.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

validation: remove BLOCK_FAILED_MASK

2026-02-17 21:40:46 +05:30

checkqueue.cpp

…

cluster_linearize.cpp

feefrac: drop comparison and operator{<<,>>} for sorted wrappers

2026-02-27 08:37:33 -05:00

CMakeLists.txt

Merge bitcoin/bitcoin#34887: fuzz: target CDBWrapper

2026-05-21 15:03:49 +01:00

cmpctblock.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

coins_view.cpp

coins: add explicit CoinsViewEmpty noop backend

2026-04-08 22:36:13 +02:00

coinscache_sim.cpp

test: fix P2SH output in coins cache fuzz

2026-05-06 09:39:07 +02:00

connman.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

…

crypto_chacha20poly1305.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

refactor: use _MiB consistently for Mebibyte conversions

2026-04-20 11:15:41 +02:00

dbwrapper.cpp

fuzz: improve dbwrapper_concurrent_reads performance

2026-06-10 14:31:03 -04:00

decode_tx.cpp

…

descriptor_parse.cpp

fuzz: test non-max descriptor satisfaction weight

2026-06-10 13:37:23 -07:00

deserialize.cpp

psbt: Remove default constructor

2026-04-29 14:51:47 -07:00

difference_formatter.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

feefrac: drop comparison and operator{<<,>>} for sorted wrappers

2026-02-27 08:37:33 -05:00

feeratediagram.cpp

feefrac: drop comparison and operator{<<,>>} for sorted wrappers

2026-02-27 08:37:33 -05:00

fees.cpp

wallet, rpc:remove settxfee and paytxfee

2026-02-13 10:52:25 +01:00

flatfile.cpp

…

float.cpp

…

fuzz.cpp

test: Replace DEBUG_LOG_OUT with -printtoconsole=1

2026-03-26 14:41:57 +01:00

fuzz.h

…

FuzzedDataProvider.h

fuzz: pull latest FuzzedDataProvider.h from upstream

2026-01-31 08:45:10 +03:00

golomb_rice.cpp

…

headerssync.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

integer.cpp

Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count

2026-01-20 15:47:17 -08:00

key_io.cpp

…

key.cpp

key: cleanse ChainCode on destruction

2026-05-12 21:24:19 +02:00

kitchen_sink.cpp

…

load_external_block_file.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

locale.cpp

…

merkle.cpp

…

merkleblock.cpp

…

message.cpp

…

mini_miner.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

miniscript.cpp

miniscript: Using Func and Expr when parsing keys, hashes, and locktimes

2026-02-02 15:20:51 -08:00

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

refactor: Use NodeClock::time_point for m_connected

2026-04-13 09:49:13 +02:00

overflow.cpp

…

p2p_handshake.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

p2p_headers_presync.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

p2p_transport_serialization.cpp

refactor: Use NodeClock::time_point for CNetMessage::m_time

2026-03-31 09:48:06 +02:00

package_eval.cpp

test: Use operator<< for time_points instead of manual TickSinceEpoch

2026-05-27 10:33:35 +02:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

partially_downloaded_block.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

pcp.cpp

IWYU fixes

2026-05-16 03:36:51 +10:00

policy_estimator_io.cpp

…

policy_estimator.cpp

…

poolresource.cpp

refactor: use _MiB consistently for Mebibyte conversions

2026-04-20 11:15:41 +02:00

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

process_messages.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

protocol.cpp

…

psbt.cpp

fuzz: Enforce additional version invariants in PSBT fuzzer

2026-04-29 15:04:22 -07:00

random.cpp

…

rbf.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

rolling_bloom_filter.cpp

…

rpc.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

script_assets_test_minimizer.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

fuzz: remove redundant CScript method calls from script harness

2026-04-20 21:18:03 -03:00

script_parsing.cpp

refactor: use _MiB consistently for Mebibyte conversions

2026-04-20 11:15:41 +02:00

script_sigcache.cpp

…

script_sign.cpp

fuzz: fix dead HD keypaths (de)serialization round-trip

2026-06-07 20:56:03 +02:00

script.cpp

fuzz: remove redundant CScript method calls from script harness

2026-04-20 21:18:03 -03:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

span.cpp

…

string.cpp

ArgsManager: support command-specific options

2026-04-22 16:45:31 +10:00

strprintf.cpp

…

system.cpp

tests: Add some fuzz test coverage for command-specific args

2026-04-22 17:58:25 +10:00

threadpool.cpp

threadpool: make Submit return Expected instead of throwing

2026-02-17 15:02:40 -05:00

timeoffsets.cpp

…

torcontrol.cpp

fuzz: Improve torcontrol fuzz test

2026-04-03 22:00:29 +02:00

transaction.cpp

coins: add explicit CoinsViewEmpty noop backend

2026-04-08 22:36:13 +02:00

tx_in.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

tx_out.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

tx_pool.cpp

refactor: have mining files include what they use

2026-05-22 08:33:36 +02:00

txdownloadman.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

txgraph.cpp

clusterlin: adopt STL ranges algorithms (refactor)

2026-02-27 08:38:01 -05:00

txorphan.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

txrequest.cpp

…

util.cpp

fuzz: Use time helpers in node_eviction

2026-03-25 16:55:18 +01:00

util.h

Merge bitcoin/bitcoin#21283: Implement BIP 370 PSBTv2

2026-05-05 14:43:28 +02:00

utxo_snapshot.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

utxo_total_supply.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

validation_load_mempool.cpp

scripted-diff: Rename NodeClockContext to FakeNodeClock

2026-06-08 14:27:24 +00:00

vecdeque.cpp

…

versionbits.cpp

Merge bitcoin/bitcoin#34779: BIP 323: reserve version bits 5-28 as extra nonce space

2026-06-03 11:56:14 -07:00