Andrew Chow d1e42659bb Merge bitcoin/bitcoin#25543: wallet: cleanup cached amount and input mine check code ...

47ea70fbb8 wallet: clean AllInputsMine code, use InputIsMine internally (furszy)
bf310b0e8c wallet: clean InputIsMine code, use GetWalletTx (furszy)
0cb177263c wallet: unify CachedTxGetImmatureCredit and CachedTxGetImmatureWatchOnlyCredit (furszy)
04c6423f7b wallet: remove always true 'fUseCache' arg from CachedTxGetAvailableCredit (furszy)
4f0ca9bff6 wallet: remove always false 'recalculate' arg from GetCachableAmount (furszy)
47b1012677 wallet: remove always true 'fUseCache' from CachedTxGetImmatureWatchOnlyCredit (furszy)
da8f62de2c wallet: remove always true 'fUseCache' from CachedTxGetImmatureCredit (furszy)

Pull request description:

  Another wallet's code garbage collector work. Part of the `mapWallet` encapsulation goal.

  Focused on the following points:

  1) Remove always true `fUseCache` argument from `CachedTxGetImmatureCredit`, `CachedTxGetImmatureWatchOnly` and `CachedTxGetAvailableCredit`.
  2) Remove always false `recalculate` argument from `GetCachableAmount`.
  3) Merge `CachedTxGetImmatureCredit` and `CachedTxGetImmatureWatchOnlyCredit` as they do share the exact same code.
  4) Clean `InputIsMine` method; use `GetWalletTx` instead of access the wallet's map directly.
  5) Clean `AllInputsMine` method; use `InputIsMine` instead of duplicate the exact same code internally.

ACKs for top commit:
  aureleoules:
    re-ACK 47ea70fbb8
  achow101:
    ACK 47ea70fbb8
  theStack:
    re-ACK 47ea70fbb8

Tree-SHA512: e9b64b57de7be6165c5e5552e28cd8a03d4736b0a3707d29d129e3a0a3db6a855c2abf47a24917236060835a297b564a97b66d4c8b178d6bdafb93a12a7c0b40

2022-07-20 16:59:41 -04:00

..

fuzz

interfaces, refactor: Add more block information to block connected notifications

2022-07-18 13:39:55 -05:00

coinselector_tests.cpp

Merge bitcoin/bitcoin#25218: refactor: introduce generic 'Result' class and connect it to CreateTransaction and GetNewDestination

2022-07-12 13:56:48 +02:00

db_tests.cpp

…

init_test_fixture.cpp

…

init_test_fixture.h

…

init_tests.cpp

…

ismine_tests.cpp

…

psbt_wallet_tests.cpp

…

scriptpubkeyman_tests.cpp

…

spend_tests.cpp

send: refactor CreateTransaction flow to return a BResult<CTransactionRef>

2022-07-08 11:18:35 -03:00

util.cpp

wallet: Save wallet scan progress

2022-06-23 17:13:40 -03:00

util.h

…

wallet_crypto_tests.cpp

…

wallet_test_fixture.cpp

…

wallet_test_fixture.h

…

wallet_tests.cpp

Merge bitcoin/bitcoin#25543: wallet: cleanup cached amount and input mine check code

2022-07-20 16:59:41 -04:00

wallet_transaction_tests.cpp

…

walletdb_tests.cpp

…