MarcoFalke adf7843410 Merge bitcoin/bitcoin#21786: wallet: ensure sat/vB feerates are in range (mantissa of 3) ...

847288df07 test: fee rate values that cannot be represented as sat/vB (Jon Atack)
06a90fa038 rpc: for sat/vB fee rates, limit ParseFixedPoint decimals to 3 (Jon Atack)
0742c7840f rpc: enable passing decimals to AmountFromValue, add doxygen (Jon Atack)
8ce3ef57a3 test: ParseFixedPoint with 3 decimals for sat/vB fee rates (Jon Atack)
b503327597 test: type error and out of range fee rates where missing (Jon Atack)
c5fd4344f7 test: explicit fee rates with invalid amounts (Jon Atack)
ea6f76b66e test: improve zero-value explicit fee rate coverage (Jon Atack)

Pull request description:

  - Improve/close gaps in existing test coverage before making the change
  - Enable passing `decimals` to `ParseFixedPoint()` when calling `AmountFromValue()`
  - Limit explicit fee rates in sat/vB passed in by users to 3 decimals, and raise otherwise
  - Add regression test coverage

  Closes #20534.

ACKs for top commit:
  MarcoFalke:
    review ACK 847288df07 🔷

Tree-SHA512: c539d07ae9b21c0d6c8ea460beb9c8dad5559445518aace560abc3c05c588907bae189b6fd7602b3b397de4a42356136c3ec6f960d3dcf2d5d16377aef4ab5a2

2021-05-10 09:02:48 +02:00

..

test

move-only: Move constants to blockstorage

2021-04-27 10:32:54 +02:00

bdb.cpp

…

bdb.h

…

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coinselection.cpp

…

coinselection.h

[docs] add doxygen comments to wallet code

2021-04-26 11:00:18 -07:00

context.cpp

…

context.h

…

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

external_signer_scriptpubkeyman.h

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

tests: Skip SQLite fsyncs while testing

2021-04-12 19:29:03 -04:00

interfaces.cpp

Move external signer out of wallet module

2021-04-08 17:56:00 +02:00

ismine.h

…

load.cpp

…

load.h

…

rpcdump.cpp

refactor: Use CPubKey vector constructor where possible

2021-05-04 06:53:32 +02:00

rpcwallet.cpp

Merge bitcoin/bitcoin#21786: wallet: ensure sat/vB feerates are in range (mantissa of 3)

2021-05-10 09:02:48 +02:00

rpcwallet.h

refactor: replace util::Ref by std::any (C++17)

2021-03-29 23:29:42 +02:00

salvage.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

salvage.h

…

scriptpubkeyman.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

scriptpubkeyman.h

…

sqlite.cpp

tests: Skip SQLite fsyncs while testing

2021-04-12 19:29:03 -04:00

sqlite.h

…

wallet.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

wallet.h

[docs] add doxygen comments to wallet code

2021-04-26 11:00:18 -07:00

walletdb.cpp

…

walletdb.h

…

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

…