mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-19 06:43:45 +01:00
bd0ee07310
e181bda061guix: Apply all codesignatures to Windows binaries (Ava Chow)aafbd23fd9guix: Apply codesignatures to all MacOS binaries (Ava Chow)3656b828dccontrib: Sign all Windows binaries too (Ava Chow)31d325464dcontrib: Sign and notarize all MacOS binaries (Ava Chow)710d5b5149guix: Update signapple (Ava Chow)e8b3c44da6build: Include all Windows binaries for codesigning (Ava Chow)dd4ec840eebuild: Include all MacOS binaries for codesigning (Ava Chow)4e5c9ceb9dguix: Rename Windows unsigned binaries to unsigned.zip (Ava Chow)d9d49cd533guix: Rename MacOS binaries to unsigned.tar.gz (Ava Chow)c214e5268fguix: Rename unsigned.tar.gz to codesigning.tar.gz (Ava Chow) Pull request description: I have updated signapple to notarize MacOS app bundles without adding any additional dependencies. Further, it can also sign and apply detached signatures to standalone binaries. As such, we can use signapple to perform the notarization and stapling steps so that MacOS will run the app bundle after it is installed. `detached-sig-create.sh` is updated to have a notarization step and to download the ticket which will be included in the detached signatures. The workflow is largely unchanged for the MacOS codesigners except for the additional requirement of having an App Store Connect API key and Team UUID, instructions for which can be found at https://github.com/achow101/signapple/blob/master/docs/notarization.md. For guix builders, the workflow is unchanged. Additionally, the standalone binaries packaged in the MacOS `.tar.gz` and Windows `.zip` will now be codesigned. `detached-sig-create.sh` was updated to handle these, so the workflow for both MacOS and Windows codesigners remains unchanged. For guix builders, the workflow is also unchanged. Because those binaries will how have codesigned and unsigned versions, the build command is modified to output `-unsigned.{tar.gz,zip}` archives containing the binaries. Since this happens to conflict with the tarball used for codesigning, the codesigning tarball was renamed to `-codesigning.tar.gz`. Both MacOS and Windows codesigners will need to adjust their workflows to account for the new name. Fixes #15774 and #29749 ACKs for top commit: Sjors: Tested ACKe181bda061davidgumberg: Tested ACKe181bda061. pinheadmz: tested ACKe181bda061Tree-SHA512: ce0e2bf38e1748cdaa0d13be6f61c3289cd09cfb7d071a68b0b13d2802b3936c9112eda6e4c7b29c535c0995d56b14871442589cdcea2e7707e35c1b278b9263