Wladimir J. van der Laan a1be08405d Merge #20788: net: add RAII socket and use it instead of bare SOCKET ...

615ba0eb96 test: add Sock unit tests (Vasil Dimov)
7bd21ce1ef style: rename hSocket to sock (Vasil Dimov)
04ae846904 net: use Sock in InterruptibleRecv() and Socks5() (Vasil Dimov)
ba9d73268f net: add RAII socket and use it instead of bare SOCKET (Vasil Dimov)
dec9b5e850 net: move CloseSocket() from netbase to util/sock (Vasil Dimov)
aa17a44551 net: move MillisToTimeval() from netbase to util/time (Vasil Dimov)

Pull request description:

  Introduce a class to manage the lifetime of a socket - when the object
  that contains the socket goes out of scope, the underlying socket will
  be closed.

  In addition, the new `Sock` class has a `Send()`, `Recv()` and `Wait()`
  methods that can be overridden by unit tests to mock the socket
  operations.

  The `Wait()` method also hides the
  `#ifdef USE_POLL poll() #else select() #endif` technique from higher
  level code.

ACKs for top commit:
  laanwj:
    Re-ACK 615ba0eb96
  jonatack:
    re-ACK 615ba0eb96

Tree-SHA512: 3003e6bc0259295ca0265ccdeb1522ee25b4abe66d32e6ceaa51b55e0a999df7ddee765f86ce558a788c1953ee2009bfa149b09d494593f7d799c0d7d930bee8

2021-02-11 14:07:33 +01:00

..

asmap.cpp

…

asmap.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

bip32.cpp

…

bip32.h

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

bytevectorhash.cpp

…

bytevectorhash.h

…

check.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

error.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

error.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

fees.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

fees.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

getuniquepath.cpp

Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem.

2021-02-04 11:38:09 +01:00

getuniquepath.h

Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem.

2021-02-04 11:38:09 +01:00

golombrice.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

hasher.cpp

Add generic SaltedSipHasher

2020-11-10 14:33:37 -05:00

hasher.h

Add generic SaltedSipHasher

2020-11-10 14:33:37 -05:00

macros.h

refactor: Move STRINGIZE macro to macros.h

2021-02-01 22:30:05 +02:00

memory.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

message.cpp

Replace boost::variant with std::variant

2021-01-05 10:10:50 +01:00

message.h

…

moneystr.cpp

…

moneystr.h

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

rbf.cpp

…

rbf.h

…

ref.h

…

settings.cpp

…

settings.h

…

sock.cpp

net: add RAII socket and use it instead of bare SOCKET

2021-02-10 13:30:08 +01:00

sock.h

net: add RAII socket and use it instead of bare SOCKET

2021-02-10 13:30:08 +01:00

spanparsing.cpp

…

spanparsing.h

…

strencodings.cpp

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

strencodings.h

doc: Use https URLs where possible

2021-01-04 12:23:16 +08:00

string.cpp

…

string.h

scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD

2020-11-26 09:05:59 +00:00

system.cpp

Introduce GetUniquePath(base) helper method to replace boost::filesystem::unique_path() which is not available in std::filesystem.

2021-02-04 11:38:09 +01:00

system.h

refactor: Treat ArgsManager::Flags as uint32_t explicitly

2021-02-04 19:34:15 +01:00

threadnames.cpp

…

threadnames.h

…

time.cpp

Merge #20788: net: add RAII socket and use it instead of bare SOCKET

2021-02-11 14:07:33 +01:00

time.h

net: add RAII socket and use it instead of bare SOCKET

2021-02-10 13:30:08 +01:00

trace.h

tracing: add tracing framework

2020-12-07 11:55:51 +01:00

translation.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

ui_change_type.h

…

url.cpp

…

url.h

…

vector.h

…