Ava Chow 6dda050865 Merge bitcoin/bitcoin#29458: refactor: Preallocate result in TryParseHex to avoid resizing ...

a19235c14b Preallocate result in `TryParseHex` to avoid resizing (Lőrinc)
b7489ecb52 Add benchmark for TryParseHex (Lőrinc)

Pull request description:

  This pull request introduces optimizations to the `TryParseHex` function, focusing primarily on the ideal case (valid hexadecimal input without spaces).
  A new benchmark, `HexParse` was introduced in a separate commit.

  The main optimization preallocates the result vector based on the input string's length. This aims to completely avoid costly dynamic reallocations when no spaces are present.

  ------------

  Before:
  ```
  |           ns/base16 |            base16/s |    err% |     total | benchmark
  |--------------------:|--------------------:|--------:|----------:|:----------
  |                1.60 |      623,238,893.11 |    0.3% |      0.01 | `HexParse`
  |                1.65 |      606,747,566.34 |    0.6% |      0.01 | `HexParse`
  |                1.60 |      626,149,544.07 |    0.3% |      0.01 | `HexParse`
  ```

  After:
  ```
  |           ns/base16 |            base16/s |    err% |     total | benchmark
  |--------------------:|--------------------:|--------:|----------:|:----------
  |                0.68 |    1,465,555,976.27 |    0.8% |      0.01 | `HexParse`
  |                0.68 |    1,472,962,920.18 |    0.3% |      0.01 | `HexParse`
  |                0.68 |    1,476,159,423.00 |    0.3% |      0.01 | `HexParse`
  ```

ACKs for top commit:
  achow101:
    ACK a19235c14b
  hebasto:
    ACK a19235c14b.
  andrewtoth:
    Re-ACK a19235c14b
  Empact:
    Re-ACK a19235c14b

Tree-SHA512: e09a59791104be3fd1026862ce98de9efafa1f949626fa01e3b7d58e6a2ef02a11f0de55ddba5c43230a53effd24e6d368c1e12848b17e8ce91d7908a59333f0

2024-03-11 09:59:35 -04:00

..

data

…

.gitignore

…

addrman.cpp

…

base58.cpp

…

bech32.cpp

…

bench_bitcoin.cpp

…

bench.cpp

test: test_bitcoin: allow -testdatadir=<datadir>

2024-03-07 10:11:45 -07:00

bench.h

Extract util::Xor, Add key_offset option, Add bench

2023-07-12 09:59:55 +02:00

bip324_ecdh.cpp

…

block_assemble.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

ccoins_caching.cpp

…

chacha20.cpp

crypto: refactor ChaCha20 classes to use Span<std::byte> interface

2023-08-17 15:26:34 -04:00

checkblock.cpp

Convert some CDataStream to DataStream

2023-11-16 11:14:13 +10:00

checkqueue.cpp

refactor: Make CCheckQueue constructor start worker threads

2023-10-03 10:52:15 +01:00

coin_selection.cpp

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

crypto_hash.cpp

bench: Add SHA256 implementation specific benchmarks

2023-09-20 21:12:00 +01:00

data.cpp

…

data.h

…

descriptors.cpp

Move CTxDestination to its own file

2023-08-14 17:38:27 -04:00

disconnected_transactions.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

duplicate_inputs.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

ellswift.cpp

refactor: share and use GenerateRandomKey helper

2023-12-23 13:26:00 +01:00

examples.cpp

…

gcs_filter.cpp

…

hashpadding.cpp

…

load_external.cpp

refactor: switch from CAutoFile to AutoFile

2023-11-18 03:01:41 +10:00

lockedpool.cpp

…

logging.cpp

…

mempool_eviction.cpp

mempool_entry: add mempool entry sequence number

2023-08-03 13:42:45 +10:00

mempool_stress.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

merkle_root.cpp

…

nanobench.cpp

…

nanobench.h

bench: Update nanobench to 4.3.11

2023-11-14 20:22:12 +01:00

parse_hex.cpp

Add benchmark for TryParseHex

2024-02-28 17:23:54 +00:00

peer_eviction.cpp

…

poly1305.cpp

Switch all callers from poly1305_auth to Poly1305 class

2023-07-12 22:43:55 -04:00

pool.cpp

pool: make sure PoolAllocator uses the correct alignment

2023-11-19 18:43:29 +01:00

prevector.cpp

…

readblock.cpp

bench: add readblock benchmark

2023-11-26 13:24:05 -05:00

rollingbloom.cpp

…

rpc_blockchain.cpp

refactor: rpc: Pass CBlockIndex by reference instead of pointer

2023-12-07 12:05:21 +01:00

rpc_mempool.cpp

mempool_entry: add mempool entry sequence number

2023-08-03 13:42:45 +10:00

streams_findbyte.cpp

refactor: switch from CAutoFile to AutoFile

2023-11-18 03:01:41 +10:00

strencodings.cpp

…

util_time.cpp

…

verify_script.cpp

scripted-diff: Fix bitcoin_config_h includes

2024-02-13 20:10:44 +00:00

wallet_balance.cpp

refactor: De-globalize g_signals

2024-02-15 14:37:01 +01:00

wallet_create_tx.cpp

test: wallet, fix change position out of range error

2023-12-12 15:20:38 -03:00

wallet_create.cpp

scripted-diff: Fix bitcoin_config_h includes

2024-02-13 20:10:44 +00:00

wallet_ismine.cpp

refactor: Add missing include for USE_BDB, USE_SQLITE to bench/wallet_ismine.cpp

2024-02-20 15:11:58 +01:00

wallet_loading.cpp

scripted-diff: Fix bitcoin_config_h includes

2024-02-13 20:10:44 +00:00

xor.cpp

Extract util::Xor, Add key_offset option, Add bench

2023-07-12 09:59:55 +02:00