mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00

Files

MarcoFalke 064c729a96 Merge bitcoin/bitcoin#23512 : policy: Treat taproot as always active

fa3e0da06b policy: Treat taproot as always active (MarcoFalke)

Pull request description:

  Now that taproot is active, it can be treated as if it was always active for policy for the next major release. This simplifies the code and changes two things:

  * Importing `tr` descriptors can be done before the chain is fully synced. This is fine, because the wallet will already generate `tr` descriptors by default (regardless of the taproot status) after commit 47fe7445e7.
  * Valid taproot spends won't be rejected from the mempool before taproot is active. This is strictly speaking a bugfix after commit 47fe7445e7, since the wallet may generate taproot spends before the chain is fully synced. For example, a slow node or a purposefully offline node. Currently, the wallet needs the mempool to account for change. See https://github.com/bitcoin/bitcoin/issues/11887.

  A similar change was done for segwit v0 in https://github.com/bitcoin/bitcoin/pull/13120 .

  This effectively reverts commit c5ec0367d7.

ACKs for top commit:
  mjdietzx:
    Code Review ACK fa3e0da06b
  achow101:
    ACK fa3e0da06b
  sipa:
    utACK fa3e0da06b
  gruve-p:
    ACK fa3e0da06b
  gunar:
    Code Review + tACK fa3e0da06
  rajarshimaitra:
    code review + tACK fa3e0da06b

Tree-SHA512: c6dc7a4e6c345bdec33f256847dc63906ab1696aa683ab9b32a79e715613950884ac3a1a7a44e95f31bb28e58dd64679a616175f7e152b21f5550f3337c8e622

2021-11-25 08:16:19 +01:00

chain.h

policy: Treat taproot as always active

2021-11-16 08:20:33 +01:00

echo.cpp

multiprocess: Add echoipc RPC method and test

2021-04-23 03:02:50 -05:00

echo.h

multiprocess: Add echoipc RPC method and test

2021-04-23 03:02:50 -05:00

handler.cpp

scripted-diff: remove MakeUnique<T>()

2021-03-11 13:45:14 +08:00

handler.h

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

init.cpp

multiprocess: Add echoipc RPC method and test

2021-04-23 03:02:50 -05:00

init.h

multiprocess: Add echoipc RPC method and test

2021-04-23 03:02:50 -05:00

ipc.h

Add ipc::Context and ipc::capnp::Context structs

2021-06-10 09:58:45 -05:00

node.h

Merge bitcoin/bitcoin#23499 : multiprocess: Add interfaces::Node::broadCastTransaction method

2021-11-16 08:42:21 +01:00

README.md

multiprocess: Add comments and documentation

2021-04-23 03:02:50 -05:00

wallet.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #19160.
Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.