Files
bitcoin/src/interfaces/mining.h
Ava Chow 7b6f9ba7ba Merge bitcoin/bitcoin#34672: mining: add reason/debug to submitSolution and unify with submitBlock
75929b11ed doc: add release note for submitSolution IPC changes (woltx)
ed75d70fdb refactor: centralize SubmitBlock result handling (w0xlt)
cbaa1696f3 mining: add reason and debug output to submitSolution (w0xlt)
83f3bc002d mining: clarify SubmitBlock result handling (w0xlt)

Pull request description:

  `BlockTemplate.submitSolution` currently returns only a boolean, so IPC mining clients cannot determine why a submission failed without inspecting Bitcoin Core's debug log.

  Returning `reason` and `debug`, as `Mining.submitBlock` already does, lets callers distinguish a concrete block rejection from a duplicate or inconclusive result. Here, `inconclusive` means the method returns failure, but validation did not determine that the submitted block is invalid.

  This follow-up was suggested during the review of #34644:
  https://github.com/bitcoin/bitcoin/pull/34644#discussion_r2853758006

  This PR:

  - Extracts a shared `SubmitBlock` helper that wraps `ProcessNewBlock` with `SubmitBlockStateCatcher` to capture `BlockValidationState`
  - Adds `reason` and `debug` output parameters to `submitSolution`, matching `submitBlock`
  - Makes both methods delegate to the same helper, eliminating duplicated logic

ACKs for top commit:
  optout21:
    ACK 75929b11ed
  achow101:
    light ACK 75929b11ed
  Sjors:
    ACK 75929b11ed
  enirox001:
    ACK 75929b11ed
  sedited:
    ACK 75929b11ed

Tree-SHA512: 31b1c305c20aaebdfa2d887665d9927830d0f97ba3c3469e2792148ad799d5a400a000cc0ca0b9add071d314e27c9da44d55228c442533a32a7c031678b78a55
2026-07-22 15:50:08 -07:00

222 lines
8.8 KiB
C++

// Copyright (c) 2024-present The Bitcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#ifndef BITCOIN_INTERFACES_MINING_H
#define BITCOIN_INTERFACES_MINING_H
#include <consensus/amount.h>
#include <interfaces/types.h>
#include <node/mining_types.h>
#include <primitives/block.h>
#include <primitives/transaction.h>
#include <uint256.h>
#include <util/time.h>
#include <cstdint>
#include <memory>
#include <optional>
#include <stdexcept>
#include <string>
#include <vector>
namespace node {
struct NodeContext;
} // namespace node
namespace interfaces {
//! Block template interface
class BlockTemplate
{
public:
virtual ~BlockTemplate() = default;
virtual CBlockHeader getBlockHeader() = 0;
// Block contains a dummy coinbase transaction that should not be used and
// it may not match a transaction constructed from getCoinbaseTx().
virtual CBlock getBlock() = 0;
// Fees per transaction, not including coinbase transaction.
virtual std::vector<CAmount> getTxFees() = 0;
// Sigop cost per transaction, not including coinbase transaction.
virtual std::vector<int64_t> getTxSigops() = 0;
/** Return fields needed to construct a coinbase transaction */
virtual node::CoinbaseTx getCoinbaseTx() = 0;
/**
* Compute merkle path to the coinbase transaction
*
* @return merkle path ordered from the deepest
*/
virtual std::vector<uint256> getCoinbaseMerklePath() = 0;
/**
* Construct and broadcast the block. Modifies the template in place,
* updating the fields listed below as well as the merkle root.
*
* @param[in] version version block header field
* @param[in] timestamp time block header field (unix timestamp)
* @param[in] nonce nonce block header field
* @param[in] coinbase complete coinbase transaction (including witness)
* @param[out] reason failure reason (BIP22)
* @param[out] debug more detailed rejection reason
*
* @note Unlike the submitblock RPC, this method does not call
* UpdateUncommittedBlockStructures to add a missing coinbase witness
* reserved value. Callers must provide a complete coinbase transaction,
* including the witness when a witness commitment is present.
*
* @note for heights <= 16, the BIP34 height push in getCoinbaseTx().script_sig_prefix
* is only one byte long, so the coinbase scriptSig needs at least
* one additional byte of data to avoid bad-cb-length.
*
* @returns true if the block was accepted as a new block
*/
virtual bool submitSolution(uint32_t version, uint32_t timestamp, uint32_t nonce, CTransactionRef coinbase, std::string& reason, std::string& debug) = 0;
//! Deprecated older method preserved to return an explicit error for IPC
//! clients using mining.capnp @7.
virtual bool submitSolutionOld7(uint32_t, uint32_t, uint32_t, CTransactionRef)
{
throw std::runtime_error("Old submitSolution (@7) not supported. Please update your client!");
}
/**
* Waits for fees in the next block to rise, a new tip or the timeout.
*
* @param[in] options Control the timeout (default forever) and by how much total fees
* for the next block should rise (default infinite).
*
* @returns a new BlockTemplate or nothing if the timeout occurs.
*
* On testnet this will additionally return a template with difficulty 1 if
* the tip is more than 20 minutes old.
*/
virtual std::unique_ptr<BlockTemplate> waitNext(node::BlockWaitOptions options = {}) = 0;
/**
* Interrupts the current wait for the next block template.
*/
virtual void interruptWait() = 0;
};
//! Interface giving clients (RPC, Stratum v2 Template Provider in the future)
//! ability to create block templates.
class Mining
{
public:
virtual ~Mining() = default;
//! If this chain is exclusively used for testing
virtual bool isTestChain() = 0;
//! Returns whether IBD is still in progress.
virtual bool isInitialBlockDownload() = 0;
//! Returns the hash and height for the tip of this chain
virtual std::optional<BlockRef> getTip() = 0;
/**
* Waits for the connected tip to change. During node initialization, this will
* wait until the tip is connected (regardless of `timeout`).
*
* @param[in] current_tip block hash of the current chain tip. Function waits
* for the chain tip to differ from this.
* @param[in] timeout how long to wait for a new tip (default is forever)
*
* @retval BlockRef hash and height of the current chain tip after this call.
* @retval std::nullopt if the node is shut down or interrupt() is called.
*/
virtual std::optional<BlockRef> waitTipChanged(uint256 current_tip, MillisecondsDouble timeout = MillisecondsDouble::max()) = 0;
/**
* Construct a new block template.
*
* @param[in] options options for creating the block
* @param[in] cooldown wait for tip to be connected and IBD to complete.
* If the best header is ahead of the tip, wait for the
* tip to catch up. It's recommended to disable this on
* regtest and signets with only one miner, as these
* could stall.
* @retval BlockTemplate a block template.
* @retval std::nullptr if the node is shut down or interrupt() is called.
*/
virtual std::unique_ptr<BlockTemplate> createNewBlock(const node::BlockCreateOptions& options = {}, bool cooldown = true) = 0;
/**
* Interrupts createNewBlock and waitTipChanged.
*/
virtual void interrupt() = 0;
/**
* Checks if a given block is valid.
*
* @param[in] block the block to check
* @param[in] options verification options: the proof-of-work check can be
* skipped in order to verify a template generated by
* external software.
* @param[out] reason failure reason (BIP22)
* @param[out] debug more detailed rejection reason
* @returns whether the block is valid
*
* For signets the challenge verification is skipped when check_pow is false.
*/
virtual bool checkBlock(const CBlock& block, const node::BlockCheckOptions& options, std::string& reason, std::string& debug) = 0;
/**
* Process a fully assembled block.
*
* Similar to the submitblock RPC. Accepts a complete block, validates
* it, and if accepted as new, processes it into chainstate. Accepted
* blocks may then be announced to peers through normal validation signals.
*
* @param[in] block the complete block to submit
* @param[out] reason failure reason (BIP22)
* @param[out] debug more detailed rejection reason
* @returns true if the block was accepted as a new block. Returns
* false and sets reason if the block is a duplicate or
* the validation result is inconclusive.
*
* @note Unlike the submitblock RPC, this method does not call
* UpdateUncommittedBlockStructures to add a missing coinbase witness
* reserved value. Callers must submit a fully formed block, including
* the coinbase witness when a witness commitment is present.
*/
virtual bool submitBlock(const CBlock& block, std::string& reason, std::string& debug) = 0;
/**
* Fetch raw transactions from the mempool by txid.
*
* @param[in] txids transaction ids to look up
* @returns one entry per requested txid containing the
* transaction if found, otherwise nullptr
*/
virtual std::vector<CTransactionRef> getTransactionsByTxID(const std::vector<Txid>& txids) = 0;
/**
* Fetch raw transactions from the mempool by wtxid.
*
* @param[in] wtxids witness transaction ids to look up
* @returns one entry per requested wtxid containing the
* transaction if found, otherwise nullptr
*/
virtual std::vector<CTransactionRef> getTransactionsByWitnessID(const std::vector<Wtxid>& wtxids) = 0;
//! Get internal node context. Useful for RPC and testing,
//! but not accessible across processes.
virtual const node::NodeContext* context() { return nullptr; }
};
//! Return implementation of Mining interface.
//!
//! @param[in] wait_loaded waits for chainstate data to be loaded before
//! returning. Used to prevent external clients from
//! being able to crash the node during startup.
std::unique_ptr<Mining> MakeMining(const node::NodeContext& node, bool wait_loaded=true);
} // namespace interfaces
#endif // BITCOIN_INTERFACES_MINING_H