MarcoFalke 64139803f1

Merge #18690: test: Check object hashes in wait_for_getdata ...

9f5608c2893f89cd56c7c548b748996199e0da1d test: check for matching object hashes in wait_for_getdata (Danny Lee)

Pull request description:

  Previously, `wait_for_getdata` only looked for the presence of a recent `"getdata"` message.  Additionally checking the object hashes inside the message should make tests involving `wait_for_getdata` more robust.

  `p2p_sendheaders.py` already overrides `wait_for_getdata` do this check; we can use the same approach consistently across all tests that call `wait_for_getdata`.

  This PR is progress towards #18614 , but closing that issue would also involve some additional changes to `wait_for_getheaders`.

ACKs for top commit:
  theStack:
    ACK 9f5608c2893f89cd56c7c548b748996199e0da1d 🍻

Tree-SHA512: 8e7f95881c19631db014d4bb2399fea0d14686a32542f6ca3b60809744b0d684eac4e4c107c87143991f3cd0c2d4ab09d0c17486239768a9b40bee25f2e4d54a

2020-04-23 06:37:53 -04:00

..

__init__.py

…

address.py

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

authproxy.py

test: Try once more when RPC connection fails on Windows

2020-04-12 09:04:15 -04:00

blocktools.py

test: Properly serialize BIP34 coinbase height

2019-07-09 14:12:33 -04:00

coverage.py

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

descriptors.py

Output a descriptor in createmultisig and addmultisigaddress

2020-01-30 23:55:36 -05:00

key.py

Add comments to Python ECDSA implementation

2019-04-18 13:23:26 -07:00

messages.py

test: add further BIP37 size limit checks to p2p_filter.py

2020-04-20 18:22:21 +02:00

mininode.py

test: check for matching object hashes in wait_for_getdata

2020-04-22 10:46:08 -07:00

netutil.py

scripted-diff: Update copyright in ./test

2019-03-02 10:58:35 -05:00

script_util.py

test: Remove unused, undocumented and misleading CScript.__add__

2020-04-22 09:00:56 -04:00

script.py

test: Remove unused, undocumented and misleading CScript.__add__

2020-04-22 09:00:56 -04:00

segwit_addr.py

…

siphash.py

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

socks5.py

scripted-diff: Update copyright in ./test

2019-03-02 10:58:35 -05:00

test_framework.py

test: Create cached blocks not in the future

2020-04-14 21:04:36 -04:00

test_node.py

test: add wait_for_cookie_credentials() to test framework

2020-04-19 18:12:03 +02:00

test_shell.py

TestShell: Return self from setup()

2019-11-05 12:55:52 +01:00

util.py

test: Increase debugging to hunt down mempool_reorg intermittent failure

2020-04-19 08:40:20 -04:00

wallet_util.py

scripted-diff: Bump copyright of files changed in 2020

2020-01-15 02:18:00 +07:00