bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-02 11:11:04 +02:00

History

Merge bitcoin/bitcoin#31549 : fuzz: Abort if system time is called without mock time being set

a96b84cb1b76e65a639e62f0224f534f89858c18 fuzz: Abort when calling system time without setting mock time (marcofleon)
ff21870e20b2391b684cc50fdd6879805055d6a1 fuzz: Add SetMockTime() to necessary targets (marcofleon)

Pull request description:

  This PR expands the `CheckGlobals` utility that was introduced in https://github.com/bitcoin/bitcoin/pull/31486 and should help with fuzz stability (https://github.com/bitcoin/bitcoin/issues/29018).

  System time shouldn't be used when running a fuzz test, as it is likely to introduce instability (non-determinism). This PR identifies and fixes the targets that were calling system time without setting mock time at the start of an iteration.

  Removing`SetMockTime()` from any one of these targets should result in a crash and a message describing the issue.

ACKs for top commit:
  achow101:
    ACK a96b84cb1b76e65a639e62f0224f534f89858c18
  dergoegge:
    Code review ACK a96b84cb1b76e65a639e62f0224f534f89858c18
  brunoerg:
    crACK a96b84cb1b76e65a639e62f0224f534f89858c18

Tree-SHA512: e093a9feb8a397954f7b1416dfa8790b2733f09d5ac51fda5a9d225a55ebd8f99135aa52bdf5ab531653ad1a3739c4ca2b5349c1d989bb4b009ec8eaad684f7d

2025-01-09 19:31:07 -05:00

fuzz

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

CMakeLists.txt

build, test: Build db_tests.cpp regardless of USE_BDB

2025-01-07 15:50:39 +00:00

coinselector_tests.cpp

[refactor]: update coin selection algorithms input parameter max_weight name

2024-06-27 12:37:33 +01:00

db_tests.cpp

build, test: Build db_tests.cpp regardless of USE_BDB