highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-12 16:45:40 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
fa7dd88b71a1c6641bd450fae29a4a31849b1afd
bitcoin/src
History
MarcoFalke 0853d8d2fd Merge #16112: util: Log early messages 
faa2a47cd7 logging: Add threadsafety comments (MarcoFalke)
0b282f9b00 Log early messages with -printtoconsole (Anthony Towns)
412987430c Replace OpenDebugLog() with StartLogging() (Anthony Towns)

Pull request description:

  Early log messages are dropped on the floor and they'd never make it to the console or debug log. This can be tested by running the test included in this pull request without re-compiling the `bitcoind`.

  Fix that by buffering early messages and flushing them as soon as all logging options have been initialized and logging has been started.

  This pull request is identical to  "Log early messages with -printtoconsole" (#13088)  by **ajtowns**, with the following changes:
  * Rebased
  * Added docstrings for `m_buffering` and `StartLogging`
  * Switch `CCriticalSection` (aka `RecursiveMutex`) to just `Mutex` in the last commit
  * Added tests

  Fixes #16098
  Fixes #13157
  Closes #13088

ACKs for commit faa2a4:
  ajtowns:
    utACK faa2a47cd7
  hebasto:
    ACK faa2a47cd7
  kristapsk:
    ACK faa2a47cd7 (ran added functional test before / after recompiling, didn't do additional testing)

Tree-SHA512: 685e2882642fe2a43ce171d42862582dadb840d03cda8236a994322c389ca2a1f3f431b179b2726c155c61793543bb340c568a5455d97f8b83bc7d307a85d387
2019-06-18 12:32:32 -04:00
..
bench
scripted-diff: Replace fprintf with tfm::format
2019-06-13 10:32:52 -04:00
compat
Document assumptions about C++ compiler
2019-03-05 11:19:32 +01:00
config
…
consensus
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
crypto
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
index
scripted-diff: replace chainActive -> ::ChainActive()
2019-05-03 15:02:54 -04:00
interfaces
Merge #16129: refactor: Remove unused includes
2019-06-06 16:41:40 +02:00
leveldb
Pull leveldb subtree
2019-01-26 12:45:48 -05:00
node
[build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp
2019-04-09 17:53:08 -04:00
obj
…
obj-test
…
policy
Fix spelling errors identified by codespell 1.15.0
2019-06-11 17:18:16 +02:00
primitives
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
qt
Merge #16205: Refactor: Replace fprintf with tfm::format
2019-06-17 06:06:41 -04:00
rpc
Merge #15899: rpc: Document iswitness flag and fix bug in converttopsbt
2019-06-19 00:52:39 +12:00
script
Merge #15024: Allow specific private keys to be derived from descriptor
2019-06-07 15:46:36 +02:00
secp256k1
Update the secp256k1 subtree to the latest upstream version
2019-03-31 11:41:05 -07:00
support
windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
2019-01-23 16:28:27 +08:00
test
Merge #12324: speed up Unserialize_impl for prevector
2019-06-18 17:12:02 +02:00
univalue
…
util
scripted-diff: Replace fprintf with tfm::format
2019-06-13 10:32:52 -04:00
wallet
Merge #15899: rpc: Document iswitness flag and fix bug in converttopsbt
2019-06-19 00:52:39 +12:00
zmq
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
.clang-format
…
addrdb.cpp
banman: pass the banfile path in
2019-01-16 13:54:18 -05:00
addrdb.h
banman: Add, use CBanEntry ctor that takes ban reason
2019-01-16 13:54:18 -05:00
addrman.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
addrman.h
[addrman] Ensure collisions eventually get resolved
2019-02-27 16:53:44 -05:00
amount.h
Update copyright headers to 2018
2018-12-29 10:15:01 +01:00
arith_uint256.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
arith_uint256.h
Use std::numeric_limits<UNSIGNED>::max()) instead of (UNSIGNED)-1
2018-12-04 19:55:04 +02:00
attributes.h
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
banman.cpp
Allow connections from misbehavior banned peers.
2019-01-22 21:10:48 +00:00
banman.h
Allow connections from misbehavior banned peers.
2019-01-22 21:10:48 +00:00
base58.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
base58.h
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Replace remaining fprintf with tfm::format manually
2019-06-13 11:46:38 -04:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Replace remaining fprintf with tfm::format manually
2019-06-13 11:46:38 -04:00
bitcoin-wallet-res.rc
[tools] Add wallet inspection and modification tool
2019-01-30 16:26:52 -05:00
bitcoin-wallet.cpp
scripted-diff: Replace fprintf with tfm::format
2019-06-13 10:32:52 -04:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: Replace fprintf with tfm::format
2019-06-13 10:32:52 -04:00
blockencodings.cpp
CorruptionPossible -> BLOCK_MUTATED
2019-05-02 15:14:12 -04:00
blockencodings.h
disallow oversized CBlockHeaderAndShortTxIDs
2018-11-13 12:41:41 -08:00
blockfilter.cpp
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
blockfilter.h
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
bloom.cpp
refactor: Improve CRollingBloomFilter::reset by using std::fill
2019-05-22 15:55:50 +01:00
bloom.h
…
chain.cpp
refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
2019-03-27 18:29:48 -04:00
chain.h
refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
2019-03-27 18:29:48 -04:00
chainparams.cpp
Update assumevalid, minimumchainwork, and getchaintxstats to height 563378.
2019-02-17 03:38:08 +00:00
chainparams.h
…
chainparamsbase.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
coins.h
Merge #15267: doc: explain AcceptToMemoryPoolWorker's coins_to_uncache
2019-04-26 13:09:30 -04:00
compat.h
windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
2019-01-23 16:28:27 +08:00
compressor.cpp
…
compressor.h
…
core_io.h
Move PSBT decoding functions from core_io to psbt.cpp
2019-03-26 17:38:00 -07:00
core_memusage.h
…
core_read.cpp
Include core_io.h from core_read.cpp
2019-06-06 08:00:33 +02:00
core_write.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
cuckoocache.h
…
dbwrapper.cpp
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
dbwrapper.h
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
dummywallet.cpp
Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options
2019-04-28 04:42:38 +00:00
flatfile.cpp
Style cleanup.
2019-02-22 17:38:45 -08:00
flatfile.h
Style cleanup.
2019-02-22 17:38:45 -08:00
fs.cpp
Avoid redefine warning
2019-04-10 12:16:52 +01:00
fs.h
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
hash.cpp
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
hash.h
Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063
2019-03-31 11:41:05 -07:00
httprpc.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
httprpc.h
…
httpserver.cpp
Remove global symbols: Avoid using the global namespace if possible
2019-05-25 23:23:11 +02:00
httpserver.h
[build] Add several util units
2019-04-09 17:53:08 -04:00
indirectmap.h
…
init.cpp
Merge #16112: util: Log early messages
2019-06-18 12:32:32 -04:00
init.h
Pass chain and client variables where needed
2018-11-06 11:44:40 -04:00
key_io.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
key_io.h
…
key.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
key.h
CKey: add method to negate the key
2019-03-27 13:59:50 +01:00
keystore.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
keystore.h
…
limitedmap.h
…
logging.cpp
logging: Add threadsafety comments
2019-05-28 14:27:08 -04:00
logging.h
logging: Add threadsafety comments
2019-05-28 14:27:08 -04:00
Makefile.am
Merge #14047: Add HKDF_HMAC256_L32 and method to negate a private key
2019-05-16 19:24:52 +02:00
Makefile.bench.include
util: Add type safe GetTime
2019-05-23 14:12:32 -04:00
Makefile.leveldb.include
build: Remove WINVER pre define in Makefile.leveldb.inlcude
2019-01-26 09:28:48 +08:00
Makefile.qt.include
GUI: Move QRImageWidget to its own file-pair
2019-05-02 12:18:18 +00:00
Makefile.qttest.include
scripted-diff: Rename test_bitcoin to test/setup_common
2019-04-11 10:12:36 -04:00
Makefile.test.include
Add test for GCC bug 90348
2019-06-02 10:19:30 +02:00
memusage.h
…
merkleblock.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
merkleblock.h
…
miner.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
miner.h
[rpc] mining: Omit uninitialized currentblockweight, currentblocktx
2019-02-12 11:34:57 -05:00
net_processing.cpp
Merge #15834: Fix transaction relay bugs introduced in #14897 and expire transactions from peer in-flight map
2019-06-12 12:33:01 -04:00
net_processing.h
banman: create and split out banman
2019-01-16 13:54:18 -05:00
net.cpp
net: Rename ::fRelayTxes to ::g_relay_txes
2019-05-09 09:10:53 -04:00
net.h
net: Rename ::fRelayTxes to ::g_relay_txes
2019-05-09 09:10:53 -04:00
netaddress.cpp
Fix spelling errors identified by codespell 1.15.0
2019-06-11 17:18:16 +02:00
netaddress.h
netaddress: Update CNetAddr for ORCHIDv2
2019-05-15 14:21:48 -04:00
netbase.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
scripted-diff: Replace fprintf with tfm::format
2019-06-13 10:32:52 -04:00
noui.h
Update copyright headers to 2018
2018-12-29 10:15:01 +01:00
optional.h
Remove 'boost::optional'-related gcc warnings
2019-01-30 22:44:28 +02:00
outputtype.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
outputtype.h
Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.
2018-11-05 17:03:11 +01:00
pow.cpp
…
pow.h
…
prevector.h
Merge #12324: speed up Unserialize_impl for prevector
2019-06-18 17:12:02 +02:00
protocol.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
protocol.h
Use C++11 default member initializers
2019-01-05 16:16:37 +01:00
psbt.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
psbt.h
[build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp
2019-04-09 17:53:08 -04:00
pubkey.cpp
…
pubkey.h
…
random.cpp
Merge #15224: Add RNG strengthening (10ms once every minute)
2019-05-18 10:01:54 +02:00
random.h
Merge #15224: Add RNG strengthening (10ms once every minute)
2019-05-18 10:01:54 +02:00
rest.cpp
scripted-diff: replace chainActive -> ::ChainActive()
2019-05-03 15:02:54 -04:00
reverse_iterator.h
…
reverselock.h
…
scheduler.cpp
Switch all RNG code to the built-in PRNG.
2019-01-16 16:34:56 -08:00
scheduler.h
trivial: correct parameter name in comments
2019-02-10 17:17:32 -05:00
serialize.h
Merge #12324: speed up Unserialize_impl for prevector
2019-06-18 17:12:02 +02:00
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
Trivial: Doxygenize existing CBufferedFile and VectorReader comments
2019-01-25 12:32:37 -08:00
sync.cpp
Replace remaining fprintf with tfm::format manually
2019-06-13 11:46:38 -04:00
sync.h
scripted-diff: Rename LockAnnotation to LockAssertion
2019-05-17 13:29:04 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
Update copyright headers to 2018
2018-12-29 10:15:01 +01:00
threadsafety.h
Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code)
2019-05-17 13:29:04 +02:00
timedata.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
timedata.h
…
tinyformat.h
tinyformat: Add doc to Bitcoin Core specific strprintf
2019-06-13 09:30:40 -04:00
torcontrol.cpp
Merge #15651: torcontrol: Use the default/standard network port for Tor hidden services, even if the internal port is set differently
2019-06-18 17:28:44 +02:00
torcontrol.h
…
txdb.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
txdb.h
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
txmempool.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
txmempool.h
scripted-diff: replace chainActive -> ::ChainActive()
2019-05-03 15:02:54 -04:00
ui_interface.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
ui_interface.h
Merge #15699: Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly.
2019-04-23 13:03:41 -04:00
uint256.cpp
util: Make ToLower and ToUpper take a char
2019-01-10 02:51:14 +01:00
uint256.h
…
undo.h
Extract CSipHasher to it's own file in crypto/ directory.
2018-11-05 09:25:15 -08:00
validation.cpp
Remove -mempoolreplacement to prevent needless block prop slowness.
2019-06-08 09:32:33 -04:00
validation.h
Remove -mempoolreplacement to prevent needless block prop slowness.
2019-06-08 09:32:33 -04:00
validationinterface.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
validationinterface.h
[cleanup] Remove unused CReserveKey
2019-04-10 11:44:40 -04:00
version.h
…
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
Remove direct node->wallet calls in init.cpp
2018-11-06 11:44:40 -04:00
warnings.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
warnings.h
…