bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-05-26 05:44:03 +02:00

Files

Ryan Ofsky cd3d9fa5ea Merge bitcoin/bitcoin#31318 : Drop script_pub_key arg from createNewBlock

52fd1511a7 test: drop scriptPubKeyIn arg from CreateNewBlock (Sjors Provoost)
ff41b9e296 Drop script_pub_key arg from createNewBlock (Sjors Provoost)
7ab733ede4 rpc: rename coinbase_script to coinbase_output_script (Sjors Provoost)

Pull request description:

  Providing a script for the coinbase transaction is only done in test code and for (unoptimized) CPU solo mining.

  Production miners use the `getblocktemplate` RPC which omits the coinbase transaction entirely from its block template, leaving it to external (pool) software to construct it.

  This commit removes the `script_pub_key argument` from `createNewBlock()` in the Mining interface.

  A coinbase script can still be passed via `BlockCreateOptions` instead. Tests are modified to do so.

ACKs for top commit:
  ryanofsky:
    Code review ACK 52fd1511a7. No change since last review other than rebase
  TheCharlatan:
    Re-ACK 52fd1511a7
  vasild:
    ACK 52fd1511a7

Tree-SHA512: c4b3a53774d9a5dc90950e77f47a64dbb68f971baffbb9a0d8f59332ef8e52d0c039130c925bde73135b3d0e79e65d91d1df30dc4cff13f32d8a72e5c56669d8

2024-12-17 11:50:44 -05:00

capnp

Drop script_pub_key arg from createNewBlock

2024-12-04 12:44:57 +07:00

CMakeLists.txt

multiprocess: Add serialization code for BlockValidationState

2024-09-23 16:03:04 -04:00

context.h

…

exception.h

…

interfaces.cpp