mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-05 18:23:03 +01:00

Files

MeshCollider 1139e3cb76 Merge #16415 : Get rid of PendingWalletTx class

4d94916f0d Get rid of PendingWalletTx class. (Russell Yanofsky)

Pull request description:

  No reason for this class to exist if it doesn't have any code to run in the destructor. e10e1e8db0 from https://github.com/bitcoin/bitcoin/pull/16208 recently removed the destructor code that would return an unused key if the transaction wasn't committed.

  This is just cleanup, there's no change in behavior.

ACKs for top commit:
  ariard:
    utACK 4d94916. Successfully built both `bitcoind` and `bitcoin-qt`. `PendingWalletTx` was only a wrapper to enforce call to `ReturnDestination` if `CommitTransaction` doesn't `KeepDestination` before.
  promag:
    ACK 4d94916f0d, refactor looks good to me.
  meshcollider:
    utACK 4d94916f0d

Tree-SHA512: f3f93d2f2f5d8f1e7810d609d881c1b1cbbaa8629f483f4293e20b3210292605e947bc4903fde9d2d8736277ca3bd6de182f7eac1e13515d5a327f2ebc130839

2019-07-27 22:35:32 +12:00

chain.cpp

Add Travis check for single parameter constructors not marked "explicit"

2019-06-26 16:57:14 +02:00

chain.h

…

handler.cpp

…

handler.h

…

node.cpp

Call node->initError instead of InitError from GUI code

2019-07-11 19:39:55 -04:00

node.h

Call node->initError instead of InitError from GUI code

2019-07-11 19:39:55 -04:00

README.md

…

wallet.cpp

Get rid of PendingWalletTx class.

2019-07-18 12:06:23 -04:00

wallet.h

Get rid of PendingWalletTx class.

2019-07-18 12:06:23 -04:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.