highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-12 05:32:22 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
fa8acd57cd1b9fcd62abc1eca0cab57b04a52a83
bitcoin/src
History
Ava Chow b388674acf Merge bitcoin/bitcoin#35872: rpc: avoid descriptor range counter overflow 
264555af3c rpc: avoid descriptor range counter overflow (Lőrinc)
143a13fb2b test: characterize descriptor range endpoint (Lőrinc)

Pull request description:

  **Problem:** The authenticated `scantxoutset`, `scanblocks`, `getdescriptoractivity`, `utxoupdatepsbt`, and `descriptorprocesspsbt` RPCs share a descriptor expansion helper that iterates inclusive `int64_t` ranges with an `int` counter.
  A ranged descriptor with an explicit `[begin, end]` range ending at `2^31 - 1` expands that valid position, then overflows when advancing the counter to exit the loop.
  Trap-enabled builds terminate, while other builds invoke undefined behavior.

  **Fix:** Use `int64_t` for loop control so the one-past-the-end value is representable and every position passed to `Descriptor::Expand()` remains within its existing `int` range.

  Related: [#26275](https://github.com/bitcoin/bitcoin/pull/26275) fixed the same endpoint overflow in `deriveaddresses`.

ACKs for top commit:
  achow101:
    ACK 264555af3c
  polespinasa:
    ACK 264555af3c
  sedited:
    ACK 264555af3c

Tree-SHA512: 4326182b5897b6f6672e5f7c7296eafdbb6e3b5ed901d61e8fa2cff9b19d372bb8adb88902368dc520ed400e12dd5264ea68677d9ce0feec76fa2ef55fa0d2f4
2026-08-06 13:07:06 -07:00
..
bench
refactor: Enable misc-definitions-in-headers
2026-08-05 11:51:29 +02:00
common
refactor: Remove unused #include in common/system
2026-08-04 22:22:56 +02:00
compat
refactor: Use static_cast<decltype(...)> to suppress integer sanitizer warning
2026-02-18 21:29:07 +01:00
consensus
iwyu: Fix warnings in src/consensus and treat them as errors
2026-08-04 15:02:39 +01:00
crc32c
…
crypto
refactor: Make all const static class members constexpr
2026-07-24 14:01:06 +01:00
index
Merge bitcoin/bitcoin#35568: txospenderindex: disable bloom filters to optimize disk usage
2026-07-12 12:39:54 +02:00
init
log: expose -logratelimit option
2026-06-26 09:56:01 -07:00
interfaces
Merge bitcoin-core/gui#872: Menu action to export a watchonly wallet
2026-08-03 15:53:09 +01:00
ipc
Merge bitcoin/bitcoin#35084: ipc: Add nonunix platform support
2026-07-29 09:36:13 +02:00
kernel
kernel: allow setting chainstate dbcache
2026-08-03 12:03:56 -07:00
leveldb
Update leveldb subtree to latest upstream
2026-05-28 09:34:12 +01:00
logging
logging: More fully remove libevent log category
2026-06-23 22:10:34 -04:00
minisketch
…
node
node, qt: inline DEFAULT_DB_CACHE
2026-08-03 12:03:56 -07:00
policy
refactor: Make all const static class members constexpr
2026-07-24 14:01:06 +01:00
primitives
refactor: Make all const static class members constexpr
2026-07-24 14:01:06 +01:00
qt
node, qt: inline DEFAULT_DB_CACHE
2026-08-03 12:03:56 -07:00
rpc
Merge bitcoin/bitcoin#35872: rpc: avoid descriptor range counter overflow
2026-08-06 13:07:06 -07:00
script
Merge bitcoin/bitcoin#35606: script: qa: Improve Key::Fingerprint type safety
2026-07-29 09:55:39 +02:00
secp256k1
Update secp256k1 subtree to latest master
2026-07-23 09:52:01 +01:00
support
refactor: Make all const static class members constexpr
2026-07-24 14:01:06 +01:00
test
Merge bitcoin/bitcoin#35759: fuzz: check http_request body matches framing
2026-08-06 15:18:54 +01:00
univalue
refactor: Return std::optional from ParseDouble
2026-03-30 09:03:06 +02:00
util
refactor: Use C++20 std::identity over IntIdentity
2026-08-05 11:22:34 +02:00
wallet
refactor: Remove stale NOLINTNEXTLINE above GetAddressInfoBaseFields
2026-08-05 11:04:17 +02:00
zmq
refactor: Make all const static class members constexpr
2026-07-24 14:01:06 +01:00
.clang-format
fuzz: Clang-format LIMITED_WHILE like while
2026-07-14 13:31:49 +02:00
.clang-tidy
refactor: Enable misc-definitions-in-headers
2026-08-05 11:51:29 +02:00
addrdb.cpp
logging: use util/log.h where possible
2026-05-16 03:36:51 +10:00
addrdb.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addrman_impl.h
logging: use util/log.h where possible
2026-05-16 03:36:51 +10:00
addrman.cpp
addrman: remove unreachable tried-collision branch
2026-07-10 13:33:51 -03:00
addrman.h
net: Simplify AddressPosition comparitor
2026-07-22 13:54:39 +01:00
arith_uint256.cpp
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
arith_uint256.h
…
attributes.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.cpp
logging: use util/log.h where possible
2026-05-16 03:36:51 +10:00
banman.h
…
base58.cpp
…
base58.h
iwyu: Fix warnings in src/bench and treat them as error
2026-06-10 10:32:40 +01:00
bech32.cpp
…
bech32.h
iwyu: Fix warnings in src/bench and treat them as error
2026-06-10 10:32:40 +01:00
bip324.cpp
…
bip324.h
BIP434: FEATURE message support
2026-06-04 21:58:56 +10:00
bitcoin-chainstate.cpp
kernel: Add Handle/View pattern for BlockValidationState
2026-01-21 19:40:25 +05:30
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
scripted-diff: Rename Sock::{RECV,SEND,ERR}
2026-06-27 11:26:41 +01:00
bitcoin-res.rc
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
rpc+bitcoin-tx: Specify correct type for ParseFixedPoint()
2026-06-04 09:23:13 +02:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
bitcoin-util: replace netmagic command with getchainparams command
2026-07-17 14:01:58 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
bitcoin-wallet: use command-specific options
2026-04-22 16:46:02 +10:00
bitcoin.cpp
refactor: Move license info into new module
2026-03-30 16:34:48 +01:00
bitcoind-res.rc
…
bitcoind.cpp
Merge bitcoin/bitcoin#35206: doc: fix doxygen links to threads in developer-notes.md
2026-05-27 15:48:32 +01:00
blockencodings.cpp
blockencodings: fix extra transaction count
2026-07-17 10:57:18 -04:00
blockencodings.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chain.cpp
Change CChain::FindFork() to take ref
2026-04-20 08:55:51 +02:00
chain.h
Change CChain::FindFork() to take ref
2026-04-20 08:55:51 +02:00
chainparams.cpp
Merge bitcoin/bitcoin#35335: Make deployment configuration available outside of regtest in unit tests
2026-06-03 13:53:24 -07:00
chainparams.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsbase.cpp
chainparams: make deployment configuration available on all test networks
2026-05-25 18:55:15 -04:00
chainparamsbase.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsseeds.h
contrib: Update fixed feeds
2026-02-25 14:36:19 -08:00
checkqueue.h
util: zero-pad thread number suffixes
2026-06-16 10:38:20 +02:00
clientversion.cpp
refactor: Move license info into new module
2026-03-30 16:34:48 +01:00
clientversion.h
refactor: Move license info into new module
2026-03-30 16:34:48 +01:00
cluster_linearize.h
clusterlin: avoid recomputing intersections in MergeChunks
2026-07-14 13:20:41 -04:00
CMakeLists.txt
Squashed 'src/secp256k1/' changes from bd0287d650..d2d04864ef
2026-07-23 09:52:01 +01:00
coins.cpp
coins: reuse cache hasher for txid set
2026-07-17 22:55:23 -07:00
coins.h
coins: group private cache helpers
2026-07-22 12:38:13 -07:00
compressor.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
compressor.h
refactor: Make all const static class members constexpr
2026-07-24 14:01:06 +01:00
core_io.cpp
ci, iwyu: Fix warnings in src/scripts and treat them as error
2026-05-29 11:36:08 +03:00
core_io.h
refactor: [move-only] Merge core_io module
2026-01-19 12:57:16 +01:00
core_memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cuckoocache.h
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
dbwrapper.cpp
txospenderindex: disable bloom filters to optimize disk usage
2026-07-04 11:19:19 -04:00
dbwrapper.h
Merge bitcoin/bitcoin#35568: txospenderindex: disable bloom filters to optimize disk usage
2026-07-12 12:39:54 +02:00
deploymentinfo.cpp
Remove Taproot activation height
2026-03-10 16:17:40 +01:00
deploymentinfo.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
deploymentstatus.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentstatus.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
dummywallet.cpp
logging: use util/log.h where possible
2026-05-16 03:36:51 +10:00
external_signer.cpp
external_signer: validate fingerprint from enumerate response
2026-07-02 09:23:48 -04:00
external_signer.h
doc: clarify which commands receive --chain, --fingerprint and --stdin
2026-06-11 10:33:03 -07:00
flatfile.cpp
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
flatfile.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
hash.cpp
…
hash.h
refactor: Make all const static class members constexpr
2026-07-24 14:01:06 +01:00
headerssync.cpp
logging: use util/log.h where possible
2026-05-16 03:36:51 +10:00
headerssync.h
refactor: Use reference for chain_start in HeadersSyncState
2025-11-20 11:34:21 +09:00
httprpc.cpp
http: switch servers from libevent to bitcoin
2026-06-22 05:47:00 -04:00
httprpc.h
refactor: Add ExecuteHTTPRPC function
2026-02-27 19:26:08 -04:00
httpserver.cpp
Merge bitcoin/bitcoin#35592: http: check rpcallowip immediately after accepting connection
2026-08-01 16:43:57 +01:00
httpserver.h
Merge bitcoin/bitcoin#35592: http: check rpcallowip immediately after accepting connection
2026-08-01 16:43:57 +01:00
i2p.cpp
doc: fix outdated i2p URLs in comments
2026-07-23 12:06:32 +02:00
i2p.h
doc: fix outdated i2p URLs in comments
2026-07-23 12:06:32 +02:00
indirectmap.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
init.cpp
scripted-diff: use MIN_DBCACHE_BYTES
2026-08-03 12:03:56 -07:00
init.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key_io.cpp
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
key_io.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key.cpp
Merge bitcoin/bitcoin#35606: script: qa: Improve Key::Fingerprint type safety
2026-07-29 09:55:39 +02:00
key.h
Merge bitcoin/bitcoin#35606: script: qa: Improve Key::Fingerprint type safety
2026-07-29 09:55:39 +02:00
logging.cpp
logging: More fully remove libevent log category
2026-06-23 22:10:34 -04:00
logging.h
scripted-diff: logging: Drop LogAcceptCategory
2026-05-16 03:36:51 +10:00
mapport.cpp
Merge bitcoin/bitcoin#35206: doc: fix doxygen links to threads in developer-notes.md
2026-05-27 15:48:32 +01:00
mapport.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
merkleblock.cpp
refactor: add overflow-safe CeilDiv helper
2026-02-11 18:18:21 +01:00
merkleblock.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
musig.cpp
script: qa: Improve Key::Fingerprint type safety
2026-06-25 17:34:01 -07:00
musig.h
doc: use signing pubkey instead of aggregate xonly key
2026-06-12 16:06:23 -04:00
net_permissions.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_permissions.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_processing.cpp
net_processing: process unique tx INVs only
2026-08-05 21:20:22 -04:00
net_processing.h
net_processing: Drop unnecessary txid arg from InitiateTxBroadcastToAll
2026-07-12 09:12:27 +10:00
net_types.cpp
logging: use util/log.h where possible
2026-05-16 03:36:51 +10:00
net_types.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net.cpp
Merge bitcoin/bitcoin#28463: p2p: Increase inbound capacity for block-relay only connections
2026-07-24 14:30:00 -07:00
net.h
Merge bitcoin/bitcoin#28463: p2p: Increase inbound capacity for block-relay only connections
2026-07-24 14:30:00 -07:00
netaddress.cpp
…
netaddress.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
netbase.cpp
scripted-diff: Rename Sock::{RECV,SEND,ERR}
2026-06-27 11:26:41 +01:00
netbase.h
netbase: Add timeout parameter to ConnectDirectly
2026-05-20 13:39:20 +02:00
netgroup.cpp
logging: use util/log.h where possible
2026-05-16 03:36:51 +10:00
netgroup.h
refactor: Use span instead of vector for data in util/asmap
2026-01-20 23:59:41 +01:00
netmessagemaker.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
noui.cpp
undo "ui: Compile boost:signals2 only once"
2026-06-11 21:33:33 +02:00
noui.h
refactor: Make ThreadSafeMessageBox signal void
2026-06-11 21:31:18 +02:00
outputtype.cpp
…
outputtype.h
…
pow.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
pow.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
prevector.h
iwyu: Fix warnings in src/bench and treat them as error
2026-06-10 10:32:40 +01:00
private_broadcast.cpp
private broadcast: remove no-op [[nodiscard]]
2026-07-07 16:24:48 +01:00
private_broadcast.h
private broadcast: limit outstanding txs to count of 10,000
2026-06-30 14:53:59 -04:00
protocol.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
protocol.h
p2p: Assume v2transport for addresses from seeds
2026-07-21 18:59:09 +02:00
psbt.cpp
psbt: preserve proprietary fields when combining PSBTs
2026-05-16 23:57:14 -07:00
psbt.h
ci, iwyu: Fix warnings in src/scripts and treat them as error
2026-05-29 11:36:08 +03:00
pubkey.cpp
script: qa: Improve Key::Fingerprint type safety
2026-06-25 17:34:01 -07:00
pubkey.h
script: qa: Improve Key::Fingerprint type safety
2026-06-25 17:34:01 -07:00
random.cpp
logging: use util/log.h where possible
2026-02-02 17:22:31 +00:00
random.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
randomenv.cpp
refactor: use _MiB consistently for Mebibyte conversions
2026-04-20 11:15:41 +02:00
randomenv.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
rest.cpp
http: switch servers from libevent to bitcoin
2026-06-22 05:47:00 -04:00
rest.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.h
doc: fix doxygen links to threads in developer-notes.md
2026-05-06 11:48:06 -04:00
semaphore_grant.h
…
serialize.h
serialize: add LimitedVectorFormatter
2026-06-04 21:54:08 +10:00
signet.cpp
ci, iwyu: Fix warnings in src/scripts and treat them as error
2026-05-29 11:36:08 +03:00
signet.h
kernel: Remove some unnecessary non-kernel includes
2025-12-21 10:24:09 +01:00
span.h
…
streams.cpp
refactor: Add AutoFile::size
2025-11-14 01:17:38 +02:00
streams.h
streams: add ScopedDataStreamUsage
2026-04-28 10:37:15 +02:00
sync.cpp
sync: Use StdMutex for thread safety annotations
2026-03-23 15:13:45 +10:00
sync.h
scripted-diff: Rename UNIQUE_NAME to BITCOIN_UNIQUE_NAME
2026-06-08 19:06:33 +01:00
threadsafety.h
refactor: Move StdMutex to its own header
2026-03-20 15:37:44 +00:00
tinyformat.h
refactor: Make all const static class members constexpr
2026-07-24 14:01:06 +01:00
torcontrol.cpp
util: LineReader - Drop support for raw std::byte spans
2026-07-28 13:02:21 +02:00
torcontrol.h
util: LineReader - Drop support for raw std::byte spans
2026-07-28 13:02:21 +02:00
txdb.cpp
refactor: rename async coin compaction
2026-06-23 16:13:03 -07:00
txdb.h
Merge bitcoin/bitcoin#35572: coins: make cursor iteration DB-only
2026-07-14 13:27:20 -07:00
txgraph.cpp
Merge bitcoin/bitcoin#34514: refactor: remove unnecessary std::move for a few trivially copyable types
2026-07-17 11:36:46 +01:00
txgraph.h
clusterlin: use 'cost' terminology instead of 'iters' (refactor)
2026-02-24 10:08:47 -05:00
txmempool.cpp
txmempool: Drop CompareMiningScoreWithTopology
2026-07-12 09:12:27 +10:00
txmempool.h
Merge bitcoin/bitcoin#34628: p2p: Replace per-peer transaction rate-limiting with global rate limits
2026-07-25 12:15:44 +02:00
txrequest.cpp
multi_index: fix compilation failure with boost >= 1.91
2026-04-28 18:22:47 +00:00
txrequest.h
doc: fix double-word typos in comments
2025-12-30 12:12:26 -08:00
uint256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
uint256.h
uint256: Workaround GCC-14 stringop-overread bug in Compare
2026-07-17 19:02:14 -07:00
undo.h
coins: pack Coin height/coinbase consistently
2026-02-09 17:27:39 +01:00
validation.cpp
refactor: Remove unused newFeeRate var in ReplacementChecks
2026-08-06 11:19:41 +02:00
validation.h
validation: track last flushed block
2026-07-09 16:21:28 +02:00
validationinterface.cpp
util/log, logging: Provide ShouldDebugLog and ShouldTraceLog instead of a generic ShouldLog
2026-05-16 03:36:50 +10:00
validationinterface.h
validation: Move block into BlockDisconnected signal
2026-03-18 13:34:26 +01:00
versionbits_impl.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
versionbits.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
versionbits.h
versionbits: update VersionBitsCache doc comment to match current behaviour
2026-06-01 09:53:29 -04:00
walletinitinterface.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00