Ava Chow bc1c540920 Merge bitcoin/bitcoin#29060: Policy: Report debug message why inputs are non standard ...

d8f4e7caf0 doc: add release notes (ismaelsadeeq)
248c175e3d test: ensure `ValidateInputsStandardness` optionally returns debug string (ismaelsadeeq)
d2716e9e5b policy: update `AreInputsStandard` to return error string (ismaelsadeeq)

Pull request description:

  This PR is another attempt at  #13525.

  Transactions that fail `PreChecks` Validation due to non-standard inputs now  returns invalid validation state`TxValidationResult::TX_INPUTS_NOT_STANDARD` along with a debug error message.

  Previously, the debug error message for non-standard inputs do not specify why the inputs were considered non-standard.
  Instead, the same error string, `bad-txns-nonstandard-inputs`, used for all types of non-standard input scriptSigs.

  This PR updates the `AreInputsStandard`  to include the reason why inputs are non-standard in the debug message.
  This improves the `Precheck` debug message to be more descriptive.

  Furthermore, I have addressed all remaining comments from #13525 in this PR.

ACKs for top commit:
  instagibbs:
    ACK d8f4e7caf0
  achow101:
    ACK d8f4e7caf0
  sedited:
    Re-ACK d8f4e7caf0

Tree-SHA512: 19b1a73c68584522f863b9ee2c8d3a735348667f3628dc51e36be3ba59158509509fcc1ffc5683555112c09c8b14da3ad140bb879eac629b6f60b8313cfd8b91

2026-03-19 15:43:18 -07:00

..

util

test: Fixup docs for NodeClockContext and SteadyClockContext

2026-03-12 18:13:33 +01:00

addition_overflow.cpp

…

addrman.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

base_encode_decode.cpp

…

bech32.cpp

…

bip324.cpp

…

bitdeque.cpp

…

bitset.cpp

…

block_header.cpp

…

block_index_tree.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

block_index.cpp

…

block.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

validation: remove BLOCK_FAILED_MASK

2026-02-17 21:40:46 +05:30

checkqueue.cpp

…

cluster_linearize.cpp

clusterlin: adopt trained cost model (feature)

2026-02-24 12:05:17 -05:00

CMakeLists.txt

fuzz: add test case for threadpool

2026-01-30 16:17:12 -05:00

coins_view.cpp

Merge bitcoin/bitcoin#29060: Policy: Report debug message why inputs are non standard

2026-03-19 15:43:18 -07:00

coinscache_sim.cpp

coins: introduce CoinsViewOverlay

2026-02-12 21:31:23 -05:00

connman.cpp

Merge bitcoin/bitcoin#34479: fuzz: Add and use NodeClockContext

2026-03-18 16:09:31 +01:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

…

crypto_chacha20poly1305.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

test: Test that key expression indexes match key count

2026-02-02 15:20:47 -08:00

deserialize.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

difference_formatter.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

…

feeratediagram.cpp

…

fees.cpp

wallet, rpc:remove settxfee and paytxfee

2026-02-13 10:52:25 +01:00

flatfile.cpp

…

float.cpp

…

fuzz.cpp

…

fuzz.h

…

FuzzedDataProvider.h

fuzz: pull latest FuzzedDataProvider.h from upstream

2026-01-31 08:45:10 +03:00

golomb_rice.cpp

…

headerssync.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

integer.cpp

…

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

…

load_external_block_file.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

locale.cpp

…

merkle.cpp

…

merkleblock.cpp

…

message.cpp

…

mini_miner.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

miniscript.cpp

miniscript: Using Func and Expr when parsing keys, hashes, and locktimes

2026-02-02 15:20:51 -08:00

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

overflow.cpp

…

p2p_handshake.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

p2p_headers_presync.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

p2p_transport_serialization.cpp

…

package_eval.cpp

[miner] omit dummy extraNonce via IPC

2026-01-27 14:45:35 +01:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

…

partially_downloaded_block.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

pcp.cpp

…

policy_estimator_io.cpp

…

policy_estimator.cpp

…

poolresource.cpp

…

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

Merge bitcoin/bitcoin#34479: fuzz: Add and use NodeClockContext

2026-03-18 16:09:31 +01:00

process_messages.cpp

Merge bitcoin/bitcoin#34479: fuzz: Add and use NodeClockContext

2026-03-18 16:09:31 +01:00

protocol.cpp

…

psbt.cpp

fuzz: make sure PSBT serialization roundtrips

2026-03-04 11:56:02 -05:00

random.cpp

…

rbf.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

rolling_bloom_filter.cpp

…

rpc.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

script_assets_test_minimizer.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_parsing.cpp

…

script_sigcache.cpp

…

script_sign.cpp

…

script.cpp

…

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

span.cpp

…

string.cpp

refactor: fees: split fee rate format from fee estimate mode

2026-02-11 15:48:00 +00:00

strprintf.cpp

…

system.cpp

…

threadpool.cpp

threadpool: make Submit return Expected instead of throwing

2026-02-17 15:02:40 -05:00

timeoffsets.cpp

…

torcontrol.cpp

…

transaction.cpp

Merge bitcoin/bitcoin#29060: Policy: Report debug message why inputs are non standard

2026-03-19 15:43:18 -07:00

tx_in.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

tx_out.cpp

refactor: Use SpanReader over DataStream

2026-02-06 07:56:57 +01:00

tx_pool.cpp

[miner] omit dummy extraNonce via IPC

2026-01-27 14:45:35 +01:00

txdownloadman.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

txgraph.cpp

clusterlin: use 'cost' terminology instead of 'iters' (refactor)

2026-02-24 10:08:47 -05:00

txorphan.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

txrequest.cpp

…

util.cpp

fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration()

2026-01-23 15:59:07 +01:00

util.h

Merge bitcoin/bitcoin#34483: refactor: Use SpanReader over DataStream

2026-02-06 18:00:18 -08:00

utxo_snapshot.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

utxo_total_supply.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

validation_load_mempool.cpp

fuzz: Use NodeClockContext

2026-03-10 11:01:37 +01:00

vecdeque.cpp

…

versionbits.cpp

refactor: Enable -Wswitch in exhaustive switch

2026-03-13 09:02:09 +01:00