highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-06-26 08:51:55 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
MarcoFalke 19e3e65429
Merge bitcoin-core/gui#243: fix issue when disabling the auto-enabled blank wallet checkbox 
915e34112b5a4c2ef391d7e3706603bcd6f62a2a qt: fix issue when disabling the auto-enabled blank wallet checkbox (Jarol Rodriguez)

Pull request description:

  As detailed by #151, On `master` a user can create the confusing scenario where you have a disabled `Encrypt Wallet` checkbox and a selected `Disable Private Keys` checkbox after unselecting the auto-enabled `Blank Wallet` checkbox.

  This commit makes it so that when the `Blank Wallet` checkbox is auto-selected after the user selects `Disable Private keys`, unselecting it will also unselect the `Disable Private Keys` checkbox, which in turn re-enables the `Encrypt Wallet` checkbox.

  Below are screenshots comparing the behavior of selecting `Disable Private Keys` then unselecting the `Blank Wallet` between `master` and this `PR`:

  **Master:**
  | Select `Disable Private Keys` | Unselect `Blank Wallet` |
  | ----------------------------- | ------------------------ |
  | ![Screen Shot 2021-03-09 at 7 57 14 PM](https://user-images.githubusercontent.com/23396902/110560141-77405a80-8113-11eb-9285-5acba6241dcf.png) |   ![Screen Shot 2021-03-09 at 7 57 31 PM](https://user-images.githubusercontent.com/23396902/110560159-81faef80-8113-11eb-9b37-086aa39ecb9f.png)    |

  **PR:**
  | Select `Disable Private Keys` | Unselect `Blank Wallet` |
  | ----------------------------- | ------------------------ |
  | ![Screen Shot 2021-03-09 at 7 34 12 PM](https://user-images.githubusercontent.com/23396902/110560379-e3bb5980-8113-11eb-899a-3a4c6a1bc115.png) | ![Screen Shot 2021-03-09 at 7 34 20 PM](https://user-images.githubusercontent.com/23396902/110560412-f170df00-8113-11eb-8bd0-f7fe6fc0d739.png) |

ACKs for top commit:
  hebasto:
    ACK 915e34112b5a4c2ef391d7e3706603bcd6f62a2a
  Talkless:
    ACK 915e34112b5a4c2ef391d7e3706603bcd6f62a2a

Tree-SHA512: ce6ecbc35b94a08cabf0b8a24dbdfc874d82cc8918cc8623dce8172c7fc9c75d63a13b036bae5f7ab2c090f8d020574a542285d1651600813faf5d91e2506a8d
2021-03-26 17:30:21 +01:00
..
bench
Merge #20861: BIP 350: Implement Bech32m and use it for v1+ segwit addresses
2021-03-18 20:37:21 +01:00
compat
compat: remove memcpy -> memmove backwards compatibility alias
2021-03-10 14:31:10 +08:00
config
…
consensus
…
crc32c
…
crypto
…
index
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
interfaces
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
leveldb
…
logging
…
node
Merge #21390: test: Test improvements for UTXO set hash tests
2021-03-26 08:52:59 +01:00
policy
…
primitives
…
qt
Merge bitcoin-core/gui#243: fix issue when disabling the auto-enabled blank wallet checkbox
2021-03-26 17:30:21 +01:00
rpc
Merge #21390: test: Test improvements for UTXO set hash tests
2021-03-26 08:52:59 +01:00
script
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
secp256k1
…
support
…
test
Merge #21522: fuzz: [refactor] Use PickValue where possible
2021-03-25 08:02:11 +01:00
univalue
…
util
Merge #21317: util: Make Assume() usable as unary expression
2021-03-22 08:35:21 +01:00
wallet
remove unnecessary newline from initWarning() argument
2021-03-24 04:31:48 -06:00
zmq
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
.clang-format
…
addrdb.cpp
…
addrdb.h
…
addrman.cpp
…
addrman.h
…
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
naming nits
2021-03-17 17:59:22 -07:00
bech32.h
naming nits
2021-03-17 17:59:22 -07:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge #18335: bitcoin-cli: print useful error if bitcoind rpc work queue exceeded
2021-03-19 20:52:16 +01:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
…
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
…
chainparams.cpp
…
chainparams.h
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-16 19:52:31 +01:00
chainparamsbase.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
Merge #18030: doc: Coin::IsSpent() can also mean never existed
2021-03-23 11:11:02 +01:00
compat.h
net: extend Sock with methods for robust send & read until terminator
2021-03-01 17:36:16 +01:00
compressor.cpp
…
compressor.h
…
core_io.h
util: Avoid invalid integer negation in ValueFromAmount: make ValueFromAmount(const CAmount& n) well-defined also when n is std::numeric_limits<CAmount>::min()
2021-03-02 16:05:28 +00:00
core_memusage.h
…
core_read.cpp
…
core_write.cpp
util: Avoid invalid integer negation in ValueFromAmount: make ValueFromAmount(const CAmount& n) well-defined also when n is std::numeric_limits<CAmount>::min()
2021-03-02 16:05:28 +00:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
dummywallet.cpp
…
flatfile.cpp
…
flatfile.h
…
fs.cpp
…
fs.h
…
hash.cpp
…
hash.h
…
httprpc.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
httprpc.h
…
httpserver.cpp
Merge #18335: bitcoin-cli: print useful error if bitcoind rpc work queue exceeded
2021-03-19 20:52:16 +01:00
httpserver.h
…
i2p.cpp
i2p: limit the size of incoming messages
2021-03-16 11:00:57 +01:00
i2p.h
i2p: limit the size of incoming messages
2021-03-16 11:00:57 +01:00
indirectmap.h
…
init.cpp
remove unnecessary newline from initWarning() argument
2021-03-24 04:31:48 -06:00
init.h
bitcoind: Add -daemonwait option to wait for initialization
2021-03-04 18:24:00 +01:00
key_io.cpp
Use Bech32m encoding for v1+ segwit addresses
2021-03-16 10:48:36 -07:00
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
net: implement the necessary parts of the I2P SAM protocol
2021-03-01 18:19:37 +01:00
logging.h
net: implement the necessary parts of the I2P SAM protocol
2021-03-01 18:19:37 +01:00
Makefile.am
Merge #21415: refactor: remove Optional & nullopt
2021-03-17 12:17:33 +01:00
Makefile.bench.include
…
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
Qt: add Android packaging support
2021-03-21 22:33:27 +01:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
build: compile libnatpmp with -DNATPMP_STATICLIB on Windows
2021-03-04 12:34:46 +08:00
Makefile.test_util.include
build: compile libnatpmp with -DNATPMP_STATICLIB on Windows
2021-03-04 12:34:46 +08:00
Makefile.test.include
Merge #21142: fuzz: Add tx_pool fuzz target
2021-03-23 09:59:40 +01:00
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
miner.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
style-only: Remove whitespace
2021-03-18 09:16:11 +01:00
net_processing.h
Merge #21162: Net Processing: Move RelayTransaction() into PeerManager
2021-03-18 14:57:50 +08:00
net_types.h
…
net.cpp
Merge #21328: net, refactor: pass uint16 CService::port as uint16
2021-03-19 20:47:10 +01:00
net.h
Merge #21328: net, refactor: pass uint16 CService::port as uint16
2021-03-19 20:47:10 +01:00
netaddress.cpp
net: add I2P to the reachability map
2021-03-01 18:19:46 +01:00
netaddress.h
net: extend CNetAddr::SetSpecial() to support I2P
2021-03-01 13:22:11 +01:00
netbase.cpp
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-16 19:52:31 +01:00
netbase.h
p2p, refactor: pass and use uint16_t CService::port as uint16_t
2021-03-16 19:52:31 +01:00
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
…
psbt.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
pubkey.cpp
…
pubkey.h
…
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
…
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
shutdown.cpp
shutdown: Use RAII TokenPipe in shutdown
2021-03-04 18:24:00 +01:00
shutdown.h
…
signet.cpp
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
signet.h
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
span.h
…
streams.h
…
sync.cpp
…
sync.h
…
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
torcontrol: Move TorControlReply, TorControlConnection and TorController to improve testability
2021-03-02 12:21:32 +00:00
torcontrol.h
tests: Add fuzzing harness for TorController
2021-03-02 12:21:32 +00:00
txdb.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
txdb.h
…
txmempool.cpp
refactor: return std::nullopt instead of {}
2021-03-22 11:22:06 +08:00
txmempool.h
fuzz: Add tx_pool fuzz targets
2021-03-18 18:43:52 +01:00
txorphanage.cpp
scripted-diff: Update txorphanage naming convention
2021-02-27 01:08:09 +10:00
txorphanage.h
txorphanage: comment improvements
2021-03-02 19:40:11 +10:00
txrequest.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
refactor: return std::nullopt instead of {}
2021-03-22 11:22:06 +08:00
validation.h
Merge #21415: refactor: remove Optional & nullopt
2021-03-17 12:17:33 +01:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
validation: Remove global ::VersionBitsTip{State,SinceHeight,Statistics}
2021-03-01 17:56:07 -05:00
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…