highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-28 14:22:47 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
fab7f5c01d0b4be00bdd8922d3bf8bd1a27ba8fb
bitcoin/src
History
fanquake 03a536f1ed Merge bitcoin/bitcoin#28284: refactor: Remove confusing static_cast in address types 
fadf671fa5 Refactor: Remove confusing static_cast (MarcoFalke)
faeea1ab58 refactor: Add missing includes (MarcoFalke)

Pull request description:

  It seems confusing to use `static_cast<uint160>(bla)` to call the constructor of `uint160`. The normal and common way to call a constructor is by simply calling it. (`uint160{bla}`).

  Do this, and also drop the constructor completely where the existing `const&` reference is enough.

  Also, add missing includes while touching the file.

ACKs for top commit:
  vincenzopalazzo:
    ACK fadf671fa5
  TheCharlatan:
    ACK fadf671fa5

Tree-SHA512: 8fb9a72203a6461b1f4b38bb90943ca25a92b218fc87da2022b90802e7747350e3668a13db3189201ad30e2e39a51d6658fed4aad176fd52cecc1c7f972c3134
2023-08-22 14:46:10 +01:00
..
bench
crypto: refactor ChaCha20 classes to use Span<std::byte> interface
2023-08-17 15:26:34 -04:00
common
Rename script/standard.{cpp/h} to script/solver.{cpp/h}
2023-08-14 17:39:49 -04:00
compat
Sort includes in compat.h
2023-08-08 17:50:41 +02:00
config
…
consensus
…
crc32c
…
crypto
crypto: make ChaCha20::SetKey wipe buffer
2023-08-17 15:37:41 -04:00
index
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
init
init: remove config option names from translated -loglevel strings
2023-06-15 10:27:56 -06:00
interfaces
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
ipc
…
kernel
move-only: Create src/kernel/mempool_removal_reason.h
2023-08-17 16:26:20 +02:00
leveldb
…
logging
…
minisketch
…
node
Merge bitcoin/bitcoin#28200: refactor: Remove unused includes from wallet.cpp
2023-08-22 10:34:10 +01:00
policy
Merge bitcoin/bitcoin#28157: test doc: tests acceptstalefeeestimates option is only supported on regtest chain
2023-08-22 09:17:12 +01:00
primitives
…
qt
Rename script/standard.{cpp/h} to script/solver.{cpp/h}
2023-08-14 17:39:49 -04:00
rpc
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager
2023-08-18 12:52:30 -04:00
script
refactor: Add missing includes
2023-08-17 15:55:01 +02:00
secp256k1
Update secp256k1 subtree to latest upstream master
2023-07-18 15:25:05 +01:00
support
Don't derive secure_allocator from std::allocator
2023-07-24 22:33:40 -07:00
test
Merge bitcoin/bitcoin#28200: refactor: Remove unused includes from wallet.cpp
2023-08-22 10:34:10 +01:00
univalue
Remove unused raw-pointer read helper from univalue
2023-07-27 14:24:52 +02:00
util
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
wallet
Merge bitcoin/bitcoin#28200: refactor: Remove unused includes from wallet.cpp
2023-08-22 10:34:10 +01:00
zmq
…
.bear-tidy-config
ci: filter all subtrees from tidy output
2023-06-29 11:59:31 +01:00
.clang-format
…
.clang-tidy
refactor: Enable all clang-tidy plugin bitcoin tests
2023-08-16 14:48:06 +02:00
addrdb.cpp
script: appease spelling linter
2023-06-29 16:14:07 -06:00
addrdb.h
…
addresstype.cpp
Refactor: Remove confusing static_cast
2023-08-17 15:55:07 +02:00
addresstype.h
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
addrman_impl.h
…
addrman.cpp
…
addrman.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
refactor: add missing headers for BIP324 ciphersuite
2023-08-15 07:30:48 +05:30
bip324.h
refactor: add missing headers for BIP324 ciphersuite
2023-08-15 07:30:48 +05:30
bitcoin-chainstate.cpp
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager
2023-08-18 12:52:30 -04:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
kernel: Remove Univalue from kernel library
2023-07-25 17:40:07 +02:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
blockencodings.cpp
refactor: Fix logging.h includes
2023-08-05 10:42:56 +02:00
blockencodings.h
…
blockfilter.cpp
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
blockfilter.h
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
chain.cpp
…
chain.h
Documentation improvements for assumeutxo
2023-07-24 16:23:38 -04:00
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
…
compressor.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
compressor.h
…
core_io.h
kernel: Remove Univalue from kernel library
2023-07-25 17:40:07 +02:00
core_memusage.h
…
core_read.cpp
kernel: Remove Univalue from kernel library
2023-07-25 17:40:07 +02:00
core_write.cpp
Rename script/standard.{cpp/h} to script/solver.{cpp/h}
2023-08-14 17:39:49 -04:00
cuckoocache.h
…
dbwrapper.cpp
Merge bitcoin/bitcoin#28186: kernel: Prune leveldb headers
2023-08-07 22:31:46 +02:00
dbwrapper.h
refactor: Correct dbwrapper key naming
2023-08-05 10:45:19 +02:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
…
flatfile.h
…
hash.cpp
…
hash.h
doc: Remove comments that just repeat what the code does
2023-07-12 10:01:51 +02:00
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#27949: http: update libevent workaround to correct version
2023-06-28 12:20:25 +01:00
httpserver.h
…
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#28244: Break up script/standard.{h/cpp}
2023-08-17 12:54:16 +01:00
init.h
refactor: index, decouple 'Init' from 'Start'
2023-07-10 10:47:17 -03:00
key_io.cpp
Rename script/standard.{cpp/h} to script/solver.{cpp/h}
2023-08-14 17:39:49 -04:00
key_io.h
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
key.cpp
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
key.h
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
logging.cpp
refactor: rename BCLog::BLOCKSTORE to BLOCKSTORAGE
2023-06-15 10:27:56 -06:00
logging.h
refactor: rename BCLog::BLOCKSTORE to BLOCKSTORAGE
2023-06-15 10:27:56 -06:00
Makefile.am
move-only: Create src/kernel/mempool_removal_reason.h
2023-08-17 16:26:20 +02:00
Makefile.bench.include
Merge bitcoin/bitcoin#28008: BIP324 ciphersuite
2023-08-10 11:58:59 +02:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
…
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
Merge bitcoin/bitcoin#27425: test: move remaining rand code from util/setup_common to util/random
2023-07-19 10:26:11 +01:00
Makefile.test.include
Merge bitcoin/bitcoin#28008: BIP324 ciphersuite
2023-08-10 11:58:59 +02:00
Makefile.univalue.include
…
mapport.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager
2023-08-18 12:52:30 -04:00
net_processing.h
net processing: clamp -blockreconstructionextratxn to uint32_t bounds
2023-07-25 21:51:20 +01:00
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#27981: Fix potential network stalling bug
2023-08-17 13:15:42 +01:00
net.h
Merge bitcoin/bitcoin#27981: Fix potential network stalling bug
2023-08-17 13:15:42 +01:00
netaddress.cpp
…
netaddress.h
refactor: use Span for SipHash::Write
2023-07-17 13:27:46 +02:00
netbase.cpp
Remove now-unnecessary poll, fcntl includes from net(base).cpp
2023-06-28 16:35:45 -05:00
netbase.h
…
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
outputtype.h
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: Remove duplicate allNetMessageTypesVec
2023-07-11 19:26:52 +02:00
protocol.h
…
psbt.cpp
Move Taproot{SpendData/Builder} to signingprovider.{h/cpp}
2023-08-14 17:38:27 -04:00
psbt.h
…
pubkey.cpp
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
pubkey.h
Add BIP324Cipher, encapsulating key agreement, derivation, and stream/AEAD ciphers
2023-07-26 17:09:23 -04:00
random.cpp
crypto: require key on ChaCha20 initialization
2023-08-17 15:31:27 -04:00
random.h
crypto: refactor ChaCha20 classes to use Span<std::byte> interface
2023-08-17 15:26:34 -04:00
randomenv.cpp
…
randomenv.h
…
rest.cpp
…
rest.h
…
reverse_iterator.h
…
scheduler.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
scheduler.h
…
serialize.h
refactor: use "if constexpr" in std::vector's Unserialize()
2023-08-03 10:35:22 +02:00
shutdown.cpp
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
shutdown.h
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
signet.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
signet.h
…
span.h
refactor: Use reinterpret_cast where appropriate
2023-07-24 15:32:35 +02:00
streams.cpp
streams: Teach AutoFile how to XOR
2023-07-19 18:12:42 +02:00
streams.h
streams: Teach AutoFile how to XOR
2023-07-19 18:12:42 +02:00
sync.cpp
…
sync.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
Replace LocaleIndependentAtoi with ToIntegral
2023-08-08 16:04:22 +02:00
torcontrol.h
iwyu on torcontrol
2023-08-08 16:03:40 +02:00
txdb.cpp
kernel: Pass interrupt reference to chainman
2023-06-28 09:52:27 +02:00
txdb.h
kernel: Pass interrupt reference to chainman
2023-06-28 09:52:27 +02:00
txmempool.cpp
move-only: Create src/kernel/mempool_removal_reason.h
2023-08-17 16:26:20 +02:00
txmempool.h
move-only: Create src/kernel/mempool_removal_reason.h
2023-08-17 16:26:20 +02:00
txorphanage.cpp
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
txorphanage.h
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
txrequest.cpp
refactor: use Span for SipHash::Write
2023-07-17 13:27:46 +02:00
txrequest.h
…
uint256.cpp
…
uint256.h
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
undo.h
…
validation.cpp
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager
2023-08-18 12:52:30 -04:00
validation.h
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager
2023-08-18 12:52:30 -04:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…