MarcoFalke dbd7a91fdf Merge #19310: wallet: BerkeleyDatabase make BerkeleyDatabase::Create, CreateMock, and CreateDummy non-static functions ...

da7a83c5ee Remove WalletDatabase::Create, CreateMock, and CreateDummy (Andrew Chow)
d6045d0ac6 scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase (Andrew Chow)
45c08f8a7b Add Create*WalletDatabase functions (Andrew Chow)

Pull request description:

  Instead of having `Create`, `CreateMock`, and `CreateDummy` being static functions in `BerkeleyDatabase`, move these to standalone functions in `walletdb.cpp`. This prepares us for having different `WalletDatabase` classes.

  Part of #18971. This was originally one commit but has been split into 3 to make it (hopefully) easier to review.

ACKs for top commit:
  MarcoFalke:
    ACK da7a83c5ee 🎂
  ryanofsky:
    Code review ACK da7a83c5ee. Easy review, nice scripted-diff

Tree-SHA512: 1feb7cb3889168c555154bf3701a49095fd6b8cab911d44b7f7efbf6fcee2280ccb3d4afec8a83755b39a592ecd13b90a318faa655c321f87bdabdf1e2312327

2020-06-18 16:29:21 -04:00

..

test

…

bdb.cpp

…

bdb.h

Merge #19310: wallet: BerkeleyDatabase make BerkeleyDatabase::Create, CreateMock, and CreateDummy non-static functions

2020-06-18 16:29:21 -04:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

ismine.h

…

load.cpp

…

load.h

…

rpcdump.cpp

…

rpcwallet.cpp

…

rpcwallet.h

…

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

…

scriptpubkeyman.h

…

wallet.cpp

…

wallet.h

…

walletdb.cpp

…

walletdb.h

…

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

…