highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
fabb419a3caafc00fbbc533fee14fab7a5d2a2c6
bitcoin/src
History
fanquake fd69ffbbfb Merge bitcoin/bitcoin#28427: index: coinstats reorg, fail when block cannot be reversed 
c0bf667912 index: add [nodiscard] attribute to functions writing to the db (furszy)
eef595560e index: coinstats reorg, fail when block cannot be reversed (furszy)

Pull request description:

  Found it while reviewing https://github.com/bitcoin/bitcoin/pull/24230#discussion_r1310863359.

  During a reorg, continuing execution when a block cannot be reversed leaves the
  coinstats index in an inconsistent state.
  This was surely overlooked when 'CustomRewind' was implemented.

ACKs for top commit:
  ryanofsky:
    Code review ACK c0bf667912. Only change since last review is new commit adding [[nodiscard]]

Tree-SHA512: f4fc8522508d23e4fff09a29c935971819b1bd3b2a260e08e2e2b72f9340980d74fbec742a58fe216baf61d27de057c7c8300e8fa075f8507cd1227f128af909
2023-09-12 09:44:55 +01:00
..
bench
crypto: refactor ChaCha20 classes to use Span<std::byte> interface
2023-08-17 15:26:34 -04:00
common
Rename script/standard.{cpp/h} to script/solver.{cpp/h}
2023-08-14 17:39:49 -04:00
compat
Sort includes in compat.h
2023-08-08 17:50:41 +02:00
config
…
consensus
consensus/validation.h: remove needless GetTransactionOutputWeight helper
2023-09-08 11:16:06 +02:00
crc32c
…
crypto
crypto: make ChaCha20::SetKey wipe buffer
2023-08-17 15:37:41 -04:00
index
Merge bitcoin/bitcoin#28427: index: coinstats reorg, fail when block cannot be reversed
2023-09-12 09:44:55 +01:00
init
init: remove config option names from translated -loglevel strings
2023-06-15 10:27:56 -06:00
interfaces
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
ipc
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
kernel
config: default acceptnonstdtxn=0 on all chains
2023-08-28 22:09:39 +10:00
leveldb
…
logging
…
minisketch
…
node
Merge bitcoin/bitcoin#28195: blockstorage: Drop legacy -txindex check
2023-09-05 11:37:35 +01:00
policy
Merge bitcoin/bitcoin#26291: Update MANDATORY_SCRIPT_VERIFY_FLAGS
2023-08-23 16:19:39 -04:00
primitives
Remove version/hashing options from CBlockLocator/CDiskBlockIndex
2023-09-08 13:40:15 +00:00
qt
qt: Update translation source file
2023-09-01 08:08:36 +01:00
rpc
Merge bitcoin/bitcoin#28291: rpc: removed StrFormatInternalBug quote delimitation
2023-09-05 11:41:02 +03:00
script
Merge bitcoin/bitcoin#25284: net: Use serialization parameters for CAddress serialization
2023-09-07 11:34:34 +01:00
secp256k1
Update secp256k1 subtree to upstream release 0.4.0
2023-09-04 12:51:20 -04:00
support
Don't derive secure_allocator from std::allocator
2023-07-24 22:33:40 -07:00
test
doc: fix typos and mistakes in BIP324 code comments
2023-09-10 16:12:30 -04:00
univalue
Remove unused raw-pointer read helper from univalue
2023-07-27 14:24:52 +02:00
util
removed StrFormatInternalBug quote delimitation
2023-08-18 04:04:06 +00:00
wallet
consensus/validation.h: remove needless GetTransactionOutputWeight helper
2023-09-08 11:16:06 +02:00
zmq
p2p, refactor: return std::optional<CNetAddr> in LookupHost
2023-05-26 13:41:07 -03:00
.bear-tidy-config
ci: filter all subtrees from tidy output
2023-06-29 11:59:31 +01:00
.clang-format
…
.clang-tidy
refactor: Enable all clang-tidy plugin bitcoin tests
2023-08-16 14:48:06 +02:00
addrdb.cpp
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addrdb.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addresstype.cpp
Refactor: Remove confusing static_cast
2023-08-17 15:55:07 +02:00
addresstype.h
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
addrman_impl.h
Replace READWRITEAS macro with AsBase wrapping function
2023-08-28 17:48:15 +02:00
addrman.cpp
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addrman.h
doc: update Select function description
2023-05-24 12:03:18 -07:00
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
Introduce platform-agnostic ALWAYS_INLINE macro
2023-05-04 20:57:51 +01:00
banman.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bip324.h
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bitcoin-chainstate.cpp
assumeutxo cleanup: Move IsInitialBlockDownload & NotifyHeaderTip to ChainstateManager
2023-08-18 12:52:30 -04:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
kernel: Remove Univalue from kernel library
2023-07-25 17:40:07 +02:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
blockencodings.cpp
refactor: Fix logging.h includes
2023-08-05 10:42:56 +02:00
blockencodings.h
…
blockfilter.cpp
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
blockfilter.h
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
chain.cpp
…
chain.h
Remove version/hashing options from CBlockLocator/CDiskBlockIndex
2023-09-08 13:40:15 +00:00
chainparams.cpp
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparams.h
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparamsbase.cpp
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsbase.h
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsseeds.h
p2p: update hardcoded mainnet seeds for 25.x
2023-04-20 06:08:22 -07:00
checkqueue.h
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
…
compressor.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
compressor.h
…
core_io.h
kernel: Remove Univalue from kernel library
2023-07-25 17:40:07 +02:00
core_memusage.h
…
core_read.cpp
kernel: Remove Univalue from kernel library
2023-07-25 17:40:07 +02:00
core_write.cpp
Rename script/standard.{cpp/h} to script/solver.{cpp/h}
2023-08-14 17:39:49 -04:00
cuckoocache.h
…
dbwrapper.cpp
Merge bitcoin/bitcoin#28186: kernel: Prune leveldb headers
2023-08-07 22:31:46 +02:00
dbwrapper.h
refactor: remove clientversion include from dbwrapper.h
2023-09-08 13:40:15 +00:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
external_signer.cpp
Fix clang-tidy performance-unnecessary-copy-initialization warnings
2023-05-09 18:48:52 +02:00
external_signer.h
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
flatfile.cpp
…
flatfile.h
…
hash.cpp
…
hash.h
Remove unused legacy CHashVerifier
2023-09-05 10:13:50 +02:00
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
scripted-diff: Use UniValue::find_value method
2023-05-09 18:47:14 +02:00
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#27949: http: update libevent workaround to correct version
2023-06-28 12:20:25 +01:00
httpserver.h
…
i2p.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
i2p.h
…
indirectmap.h
…
init.cpp
refactor: remove clientversion include from dbwrapper.h
2023-09-08 13:40:15 +00:00
init.h
refactor: index, decouple 'Init' from 'Start'
2023-07-10 10:47:17 -03:00
key_io.cpp
Rename script/standard.{cpp/h} to script/solver.{cpp/h}
2023-08-14 17:39:49 -04:00
key_io.h
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
key.cpp
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
key.h
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
logging.cpp
[log] add category TXPACKAGES for orphanage and package relay
2023-08-29 16:41:22 +01:00
logging.h
[log] add category TXPACKAGES for orphanage and package relay
2023-08-29 16:41:22 +01:00
Makefile.am
move-only: Create src/kernel/mempool_removal_reason.h
2023-08-17 16:26:20 +02:00
Makefile.bench.include
Merge bitcoin/bitcoin#28008: BIP324 ciphersuite
2023-08-10 11:58:59 +02:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
…
Makefile.qt_locale.include
qt: Translation updates from Transifex
2023-09-01 07:39:00 +01:00
Makefile.qt.include
…
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
Merge bitcoin/bitcoin#27425: test: move remaining rand code from util/setup_common to util/random
2023-07-19 10:26:11 +01:00
Makefile.test.include
Merge bitcoin/bitcoin#28008: BIP324 ciphersuite
2023-08-10 11:58:59 +02:00
Makefile.univalue.include
…
mapport.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost
2023-05-30 11:39:59 -04:00
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#25284: net: Use serialization parameters for CAddress serialization
2023-09-07 11:34:34 +01:00
net_processing.h
net processing: clamp -blockreconstructionextratxn to uint32_t bounds
2023-07-25 21:51:20 +01:00
net_types.cpp
…
net_types.h
…
net.cpp
net: do not use send buffer to store/cache garbage
2023-09-10 16:12:27 -04:00
net.h
doc: fix typos and mistakes in BIP324 code comments
2023-09-10 16:12:30 -04:00
netaddress.cpp
net, refactor: pass reference for peer address in GetReachabilityFrom
2023-06-05 11:02:47 -04:00
netaddress.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
netbase.cpp
Remove now-unnecessary poll, fcntl includes from net(base).cpp
2023-06-28 16:35:45 -05:00
netbase.h
p2p, refactor: return std::optional<CNetAddr> in LookupHost
2023-05-26 13:41:07 -03:00
netgroup.cpp
refactor: Use HashWriter over legacy CHashWriter (via SerializeHash)
2023-08-25 17:09:32 +02:00
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
outputtype.h
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: Remove duplicate allNetMessageTypesVec
2023-07-11 19:26:52 +02:00
protocol.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
psbt.cpp
Move Taproot{SpendData/Builder} to signingprovider.{h/cpp}
2023-08-14 17:38:27 -04:00
psbt.h
Merge bitcoin/bitcoin#25939: rpc: In utxoupdatepsbt also look for the tx in the txindex
2023-04-21 14:06:12 -04:00
pubkey.cpp
crypto: Spanify EllSwiftPubKey constructor
2023-09-07 08:53:45 -04:00
pubkey.h
crypto: Spanify EllSwiftPubKey constructor
2023-09-07 08:53:45 -04:00
random.cpp
crypto: require key on ChaCha20 initialization
2023-08-17 15:31:27 -04:00
random.h
crypto: refactor ChaCha20 classes to use Span<std::byte> interface
2023-08-17 15:26:34 -04:00
randomenv.cpp
…
randomenv.h
…
rest.cpp
rest: bugfix, fix crash error when calling /deploymentinfo
2023-06-12 10:24:14 -03:00
rest.h
…
reverse_iterator.h
…
scheduler.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
scheduler.h
…
serialize.h
Support for serialization parameters
2023-08-28 17:48:26 +02:00
shutdown.cpp
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
shutdown.h
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
signet.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
signet.h
…
span.h
refactor: Use reinterpret_cast where appropriate
2023-07-24 15:32:35 +02:00
streams.cpp
streams: Teach AutoFile how to XOR
2023-07-19 18:12:42 +02:00
streams.h
streams: Teach AutoFile how to XOR
2023-07-19 18:12:42 +02:00
sync.cpp
…
sync.h
…
threadsafety.h
…
timedata.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
timedata.h
…
tinyformat.h
…
torcontrol.cpp
Replace LocaleIndependentAtoi with ToIntegral
2023-08-08 16:04:22 +02:00
torcontrol.h
iwyu on torcontrol
2023-08-08 16:03:40 +02:00
txdb.cpp
Merge bitcoin/bitcoin#28195: blockstorage: Drop legacy -txindex check
2023-09-05 11:37:35 +01:00
txdb.h
move-only: Move CBlockTreeDB to node/blockstorage
2023-08-01 15:27:33 +02:00
txmempool.cpp
move-only: Create src/kernel/mempool_removal_reason.h
2023-08-17 16:26:20 +02:00
txmempool.h
move-only: Create src/kernel/mempool_removal_reason.h
2023-08-17 16:26:20 +02:00
txorphanage.cpp
[log] add more logs related to orphan handling
2023-08-29 16:41:22 +01:00
txorphanage.h
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
txrequest.cpp
refactor: use Span for SipHash::Write
2023-07-17 13:27:46 +02:00
txrequest.h
…
uint256.cpp
…
uint256.h
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
undo.h
…
validation.cpp
refactor: remove clientversion include from dbwrapper.h
2023-09-08 13:40:15 +00:00
validation.h
Merge bitcoin/bitcoin#28195: blockstorage: Drop legacy -txindex check
2023-09-05 11:37:35 +01:00
validationinterface.cpp
…
validationinterface.h
…
version.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
warnings.h
…