highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-05 04:29:36 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
fad63ebe0f0db1e1d909064665be91ebd970bb0a
bitcoin/src
History
John Newbery fad63ebe0f [logging] Don't incorrectly log that REJECT messages are unknown. 
Reject messages are logged to debug.log if NET debug logging is enabled.

Because of the way the `ProcessMessages()` function is structured,
processing for REJECT messages will also drop through to the default
branch and incorrectly log `Unknown command "reject" from peer-?`. Fix
that by exiting from `ProcessMessages()` early.

without this PR:
```
2018-05-03T17:37:00.930600Z received: reject (21 bytes) peer=0
2018-05-03T17:37:00.930620Z Reject message code 16: spammy spam
2018-05-03T17:37:00.930656Z Unknown command "reject" from peer=0
```
with this PR:
```
2018-05-03T17:35:04.751246Z received: reject (21 bytes) peer=0
2018-05-03T17:35:04.751274Z Reject message code 16: spammy spam
```
2018-05-03 13:41:03 -04:00
..
bench
util: Store debug log file path in BCLog::Logger member.
2018-04-29 14:37:19 -07:00
compat
Default to defining endian-conversion DECLs in compat w/o config
2018-04-16 11:47:32 -04:00
config
…
consensus
Use P2SH consensus rules for all blocks
2018-04-13 09:52:50 -04:00
crypto
…
index
scripted-diff: Rename SetBestChain callback ChainStateFlushed
2018-04-27 14:44:22 -04:00
interfaces
util: Encapsulate logCategories within BCLog::Logger.
2018-04-27 16:10:02 -07:00
leveldb
…
obj
…
obj-test
…
policy
Extract consts for WITNESS_V0 hash sizes
2018-04-10 20:13:32 -07:00
primitives
Support serialization as another type without casting
2018-03-20 17:08:06 -07:00
qt
Merge #12729: Get rid of ambiguous OutputType::NONE value
2018-05-03 11:53:30 +02:00
rpc
Add missing newlines to LogPrint debug logging
2018-05-02 15:14:04 +02:00
script
Merge #13002: Do not treat bare multisig outputs as IsMine unless watched
2018-04-26 20:10:12 +02:00
secp256k1
…
support
Remove duplicate includes
2018-04-09 09:18:49 +02:00
test
util: Store debug log file path in BCLog::Logger member.
2018-04-29 14:37:19 -07:00
univalue
…
wallet
refactor: Avoid extra lookups of mapAddressBook in listunspent RPC
2018-05-03 11:32:57 +01:00
zmq
…
.clang-format
Fix inconsistent namespace formatting guidelines
2018-04-13 15:37:20 -04:00
addrdb.cpp
Add logging and error handling for file syncing
2018-04-23 14:25:28 +02:00
addrdb.h
…
addrman.cpp
…
addrman.h
Merge #12731: Support serialization as another type without casting
2018-04-10 20:54:33 +02:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
base58.cpp
use base58 map instead of strchr()
2018-03-21 11:57:57 +08:00
base58.h
…
bech32.cpp
…
bech32.h
Fix missing or inconsistent include guards
2018-03-22 16:23:04 +01:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName
2018-04-06 04:46:02 +10:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Merge #12950: bitcoin-tx: Flatten for loop over one element
2018-04-13 17:15:15 +02:00
bitcoind-res.rc
…
bitcoind.cpp
net: Minor accumulated cleanups
2018-04-16 13:24:14 -07:00
blockencodings.cpp
…
blockencodings.h
Fix missing or inconsistent include guards
2018-03-22 16:23:04 +01:00
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
Add static_assert to prevent VARINT(<signed value>)
2018-03-15 18:57:55 -05:00
chainparams.cpp
Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106
2018-05-02 10:02:48 -04:00
chainparams.h
[doc] Add comments for chainparams.h, validation.cpp
2018-04-17 17:15:20 -04:00
chainparamsbase.cpp
ArgsManager: support config file sections
2018-04-11 23:15:28 +10:00
chainparamsbase.h
Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName
2018-04-06 04:46:02 +10:00
chainparamsseeds.h
…
checkpoints.cpp
…
checkpoints.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
Support deserializing into temporaries
2018-03-13 17:04:31 -07:00
compat.h
net: Minor accumulated cleanups
2018-04-16 13:24:14 -07:00
compressor.cpp
Move compressor utility functions out of class
2018-03-21 14:17:18 -07:00
compressor.h
Support serializing Span<unsigned char> and use that instead of FLATDATA
2018-04-05 08:20:37 -07:00
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
Merge #12885: Reduce implementation code inside CScript
2018-04-23 21:09:17 +02:00
cuckoocache.h
Use explicit casting in cuckoocache's compute_hashes(...) to clarify integer conversion
2018-03-27 00:37:20 +02:00
dbwrapper.cpp
[logging] Comment all continuing logs.
2018-04-07 12:29:48 -04:00
dbwrapper.h
[db] Create separate database for txindex.
2018-04-25 11:25:05 -07:00
fs.cpp
…
fs.h
…
hash.cpp
…
hash.h
Support deserializing into temporaries
2018-03-13 17:04:31 -07:00
httprpc.cpp
Merge #12859: Bugfix: Include <memory> for std::unique_ptr
2018-04-05 09:31:53 +02:00
httprpc.h
…
httpserver.cpp
util: Encapsulate logCategories within BCLog::Logger.
2018-04-27 16:10:02 -07:00
httpserver.h
util: Encapsulate logCategories within BCLog::Logger.
2018-04-27 16:10:02 -07:00
indirectmap.h
…
init.cpp
Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106
2018-05-02 10:02:48 -04:00
init.h
wallet: Refactor g_wallet_init_interface to const reference
2018-04-13 14:07:21 +01:00
key_io.cpp
…
key_io.h
Fix missing or inconsistent include guards
2018-03-22 16:23:04 +01:00
key.cpp
…
key.h
…
keystore.cpp
Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size
2018-04-04 17:50:32 -04:00
keystore.h
Add compile time checking for all cs_KeyStore runtime locking assertions
2018-04-25 22:31:40 +02:00
limitedmap.h
…
logging.cpp
logging: remove unused return value from LogPrintStr
2018-05-02 11:25:20 +02:00
logging.h
logging: remove unused return value from LogPrintStr
2018-05-02 11:25:20 +02:00
Makefile.am
Remove Safe mode
2018-04-26 15:33:11 +02:00
Makefile.bench.include
benchmark: Removed bench/perf.cpp
2018-04-18 19:53:10 -07:00
Makefile.leveldb.include
…
Makefile.qt.include
Remove direct bitcoin calls from qt/splashscreen.cpp
2018-04-04 16:52:40 -04:00
Makefile.qttest.include
[tests] [qt] Add tests for address book manipulation via EditAddressDialog
2018-04-25 13:13:24 -04:00
Makefile.test.include
[test] Simple unit test for TxIndex.
2018-04-25 11:25:18 -07:00
memusage.h
Bugfix: Include <memory> for std::unique_ptr
2018-04-02 18:31:52 +00:00
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
Remove duplicate includes
2018-04-09 09:18:49 +02:00
miner.h
Remove unused variable in SortForBlock
2018-03-14 23:10:39 -07:00
net_processing.cpp
[logging] Don't incorrectly log that REJECT messages are unknown.
2018-05-03 13:41:03 -04:00
net_processing.h
Remove direct bitcoin calls from qt/peertablemodel.cpp
2018-04-04 16:52:40 -04:00
net.cpp
Add missing newlines to LogPrint debug logging
2018-05-02 15:14:04 +02:00
net.h
Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s
2018-04-13 19:25:18 +02:00
netaddress.cpp
net: Minor accumulated cleanups
2018-04-16 13:24:14 -07:00
netaddress.h
net: Minor accumulated cleanups
2018-04-16 13:24:14 -07:00
netbase.cpp
net: Minor accumulated cleanups
2018-04-16 13:24:14 -07:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
Merge #12731: Support serialization as another type without casting
2018-04-10 20:54:33 +02:00
pubkey.cpp
…
pubkey.h
…
random.cpp
Remove duplicate includes
2018-04-09 09:18:49 +02:00
random.h
Merge #12742: Make FastRandomContext support standard C++11 RNG interface
2018-03-22 12:21:46 -04:00
rest.cpp
[rpc] Public interfaces to GetTransaction block until synced.
2018-04-25 11:25:17 -07:00
reverse_iterator.h
…
reverselock.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
Merge #12916: Introduce BigEndian wrapper and use it for netaddress ports
2018-04-11 14:23:58 +02:00
span.h
Add Slice: a (pointer, size) array view that acts like a container
2018-04-05 08:20:37 -07:00
streams.h
Support deserializing into temporaries
2018-03-13 17:04:31 -07:00
sync.cpp
[logging] Comment all continuing logs.
2018-04-07 12:29:48 -04:00
sync.h
…
threadinterrupt.cpp
[index] Allow TxIndex sync thread to be interrupted.
2018-04-25 11:25:09 -07:00
threadinterrupt.h
[index] Allow TxIndex sync thread to be interrupted.
2018-04-25 11:25:09 -07:00
threadsafety.h
…
timedata.cpp
Add missing newlines to LogPrint debug logging
2018-05-02 15:14:04 +02:00
timedata.h
…
tinyformat.h
Fix typos
2018-03-21 08:34:44 +02:00
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
[db] Migration for txindex data to new, separate database.
2018-04-25 11:25:06 -07:00
txdb.h
[init] Initialize and start TxIndex in init code.
2018-04-25 11:25:12 -07:00
txmempool.cpp
Merge #11742: rpc: Add testmempoolaccept
2018-04-02 16:02:33 +02:00
txmempool.h
Merge #11742: rpc: Add testmempoolaccept
2018-04-02 16:02:33 +02:00
ui_interface.cpp
…
ui_interface.h
…
uint256.cpp
…
uint256.h
…
undo.h
Merge #12716: Fix typos and cleanup in various files
2018-03-21 11:17:43 -04:00
util.cpp
Add logging and error handling for file syncing
2018-04-23 14:25:28 +02:00
util.h
util: Establish global logger object.
2018-04-27 16:09:59 -07:00
utilmoneystr.cpp
…
utilmoneystr.h
…
utilstrencodings.cpp
…
utilstrencodings.h
…
utiltime.cpp
Fix for utiltime to compile with msvc.
2018-04-20 08:41:15 +10:00
utiltime.h
Avoid std::locale/imbue in DateTimeStrFormat
2018-04-13 01:36:53 -07:00
validation.cpp
Simplify semantics of ChainStateFlushed callback
2018-04-27 14:44:56 -04:00
validation.h
[validation] Replace tx index code in validation code with TxIndex.
2018-04-25 11:25:13 -07:00
validationinterface.cpp
scripted-diff: Rename SetBestChain callback ChainStateFlushed
2018-04-27 14:44:22 -04:00
validationinterface.h
Simplify semantics of ChainStateFlushed callback
2018-04-27 14:44:56 -04:00
version.h
…
versionbits.cpp
…
versionbits.h
Merge #12757: Clarify include guard naming convention
2018-04-01 18:30:21 -04:00
walletinitinterface.h
wallet: Make WalletInitInterface members const
2018-04-13 14:02:59 +01:00
warnings.cpp
Remove "rpc" category from GetWarnings
2018-04-27 09:27:52 +02:00
warnings.h
Remove "rpc" category from GetWarnings
2018-04-27 09:27:52 +02:00