mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00

Files

MarcoFalke 56376f3365 Merge #15670 : refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight

765c0b364d refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight (Antoine Riard)

Pull request description:

  As suggested in #14711, pass height to CChain::FindEarliestAtLeast to
  simplify Chain interface by combining findFirstBlockWithTime and
  findFirstBlockWithTimeAndHeight into one

ACKs for commit 765c0b:
  jnewbery:
    utACK 765c0b364d. Nice work @ariard!
  ryanofsky:
    utACK 765c0b364d. Looks good, thanks for implementing the suggestion!

Tree-SHA512: 63f98252a93da95f08c0b6325ea98f717aa9ae4036d17eaa6edbec68e5ddd65672d66a6af267b80c36311fffa9b415a47308e95ea7718b300b685e23d4e9e6ec

2019-04-19 12:03:12 -04:00

chain.cpp

Merge #15670 : refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight

2019-04-19 12:03:12 -04:00

chain.h

Merge #15670 : refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight

2019-04-19 12:03:12 -04:00

handler.cpp

scripted-diff: Move util files to separate directory.

2018-11-04 22:46:07 -08:00

handler.h

scripted-diff: Avoid interface keyword to fix windows gitian build

2018-04-07 03:42:02 -04:00

node.cpp

[build] Move policy settings to new src/policy/settings unit

2019-04-09 17:53:08 -04:00

node.h

interfaces: Add loadWallet to Node

2019-02-04 12:20:42 +00:00

README.md

Suggested interfaces::Chain cleanups from #15288

2019-03-04 15:57:58 -05:00

wallet.cpp

generalize bumpfee to add inputs when needed

2019-04-11 07:21:49 -04:00

wallet.h

Remove remaining wallet accesses to node globals

2019-03-06 16:47:57 -05:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.