highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
fbbb2d4fc13971c98c83a51635166ac532e71a32
bitcoin/src
History
Wladimir J. van der Laan 362e901a17 Merge #18466: rpc: fix invalid parameter error codes for {sign,verify}message RPCs 
a5cfb40e27 doc: release note for changed {sign,verify}message error codes (Sebastian Falbesoner)
9e399b9b2d test: check parameter validity in rpc_signmessage.py (Sebastian Falbesoner)
e62f0c71f1 rpc: fix {sign,message}verify RPC errors for invalid address/signature (Sebastian Falbesoner)

Pull request description:

  RPCs that accept address parameters usually return the intended error code `RPC_INVALID_ADDRESS_OR_KEY` (-5) if a passed address is invalid. The two exceptions to the rule are `signmessage` and `verifymessage`, which return `RPC_TYPE_ERROR` (-3) in this case instead. Oddly enough `verifymessage` returns `RPC_INVALID_ADDRESS_OR_KEY` when the _signature_ was malformed, where `RPC_TYPE_ERROR` would be more approriate.

  This PR fixes these inaccuracies and as well adds tests to `rpc_signmessage.py` that check the parameter validity and error codes for the related RPCs `signmessagewithprivkey`, `signmessage` and `verifymessage`.

  master branch:
  ```
  $ ./bitcoin-cli signmessage invalid_addr message
  error code: -3
  error message:
  Invalid address
  $ ./bitcoin-cli verifymessage invalid_addr dummy_sig message
  error code: -3
  error message:
  Invalid address
  $ ./bitcoin-cli verifymessage 12c6DSiU4Rq3P4ZxziKxzrL5LmMBrzjrJX invalid_sig message
  error code: -5
  error message:
  Malformed base64 encoding
  ```
  PR branch:
  ```
  $ ./bitcoin-cli signmessage invalid_addr message
  error code: -5
  error message:
  Invalid address
  $ ./bitcoin-cli verifymessage invalid_addr dummy_sig message
  error code: -5
  error message:
  Invalid address
  $ ./bitcoin-cli verifymessage 12c6DSiU4Rq3P4ZxziKxzrL5LmMBrzjrJX invalid_sig message
  error code: -3
  error message:
  Malformed base64 encoding
  ```

ACKs for top commit:
  laanwj:
    Code review ACK a5cfb40e27
  meshcollider:
    utACK a5cfb40e27

Tree-SHA512: bae0c4595a2603cea66090f6033785601837b45fd853052312b3a39d8520566c581994b68f693dd247c22586c638c3b7689c849085cce548cc36b9bf0e119d2d
2021-03-01 11:45:42 +01:00
..
bench
scripted-diff: Invoke ::AcceptToMemoryPool with chainstate
2021-02-18 14:49:06 -05:00
compat
assumptions: check C++17 assumption with MSVC
2021-02-23 12:51:50 +08:00
config
…
consensus
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
crc32c
build: Update crc32c subtree
2020-12-08 19:26:30 +01:00
crypto
refactor: Improve encapsulation between MuHash3072 and Num3072
2021-01-24 16:28:27 +01:00
index
Avoid accessing nullpointer in BaseIndex::GetSummary()
2021-02-11 11:39:45 +01:00
interfaces
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
leveldb
…
logging
…
node
scripted-diff: Invoke ::AcceptToMemoryPool with chainstate
2021-02-18 14:49:06 -05:00
policy
refactor: Use C++17 std::array deduction for ALL_FEE_ESTIMATE_HORIZONS
2021-01-03 18:38:31 +01:00
primitives
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
qt
Merge #21286: build: Bump minimum Qt version to 5.9.5
2021-02-28 13:14:04 +08:00
rpc
Merge #18466: rpc: fix invalid parameter error codes for {sign,verify}message RPCs
2021-03-01 11:45:42 +01:00
script
Merge #19136: wallet: add parent_desc to getaddressinfo
2021-02-18 21:51:16 +13:00
secp256k1
Update secp256k1 subtree to latest master
2020-10-27 23:08:48 -07:00
support
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
test
Merge #21264: fuzz: Two scripted diff renames
2021-02-25 14:42:48 +01:00
univalue
Update univalue subtree
2020-11-19 15:48:24 +01:00
util
Merge #18017: txmempool: split epoch logic into class
2021-02-24 09:57:21 +01:00
wallet
Merge #18466: rpc: fix invalid parameter error codes for {sign,verify}message RPCs
2021-03-01 11:45:42 +01:00
zmq
rpc: Remove duplicate name and argNames from CRPCCommand
2021-01-28 08:19:52 +01:00
.clang-format
[tools] Allow argument/parameter bin packing in clang-format
2021-02-18 10:07:37 +00:00
addrdb.cpp
log: Clarify log message when file does not exist
2021-02-18 15:08:35 +01:00
addrdb.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
addrman.cpp
refactor: remove boost::thread_group usage
2021-01-29 15:39:44 +08:00
addrman.h
[addrman] Don't repeat "Bucketing method was updated" log multiple times
2021-01-29 12:39:55 +00:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
banman.cpp
log: Clarify log message when file does not exist
2021-02-18 15:08:35 +01:00
banman.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
base58.cpp
refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17)
2021-01-31 17:35:16 +01:00
base58.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-cli.cpp
cli: Treat high detail levels as the maximum in -netinfo
2021-02-15 20:01:52 +01:00
bitcoin-tx-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-tx.cpp
Move TX_MAX_STANDARD_VERSION to policy
2020-12-10 11:12:08 +01:00
bitcoin-util-res.rc
Add bitcoin-util command line utility
2021-01-12 18:34:25 +10:00
bitcoin-util.cpp
Merge #20938: build: fix linking against -latomic when building for riscv
2021-01-18 18:33:24 +01:00
bitcoin-wallet-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoin-wallet.cpp
util: Add ArgsManager::GetCommand() and use it in bitcoin-wallet
2021-01-21 19:31:28 +01:00
bitcoind-res.rc
Drop the leading 0 from the version number
2020-11-18 12:00:57 -05:00
bitcoind.cpp
init: Signal-safe instant shutdown
2020-12-15 17:21:06 +01:00
blockencodings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockencodings.h
…
blockfilter.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
blockfilter.h
…
bloom.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
bloom.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chain.cpp
…
chain.h
simplify ChainstateManager::SnapshotBlockhash() return semantics
2021-02-12 07:53:29 -06:00
chainparams.cpp
Merge #15946: Allow maintaining the blockfilterindex when using prune
2021-02-18 09:40:42 +01:00
chainparams.h
chainparams: add allowed assumeutxo values
2021-02-12 07:53:22 -06:00
chainparamsbase.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chainparamsbase.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
chainparamsseeds.h
net: Hardcoded seeds update for 0.21
2020-10-25 14:25:00 +01:00
checkqueue.h
refactor: Drop boost::thread stuff in CCheckQueue
2020-09-24 06:55:34 +03:00
clientversion.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
clientversion.h
refactor: Move STRINGIZE macro to macros.h
2021-02-01 22:30:05 +02:00
coins.cpp
simplify ChainstateManager::SnapshotBlockhash() return semantics
2021-02-12 07:53:29 -06:00
coins.h
simplify ChainstateManager::SnapshotBlockhash() return semantics
2021-02-12 07:53:29 -06:00
compat.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
compressor.cpp
…
compressor.h
…
core_io.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
core_memusage.h
…
core_read.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
core_write.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
cuckoocache.h
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
dbwrapper.cpp
…
dbwrapper.h
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
dummywallet.cpp
wallet: add -signer argument for external signer command
2021-02-23 14:34:30 +01:00
flatfile.cpp
log: Move "Pre-allocating up to position 0x[...] in [...].dat" log message to debug category
2021-02-10 20:46:25 +00:00
flatfile.h
…
fs.cpp
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
fs.h
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
hash.cpp
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
hash.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
httprpc.cpp
rpc: Validate -rpcauth arguments
2020-11-23 21:02:54 +00:00
httprpc.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
httpserver.cpp
net: Drop unneeded headers when compat.h included
2020-10-22 21:45:20 +03:00
httpserver.h
…
indirectmap.h
…
init.cpp
Merge #19809: log: Prefix log messages with function name and source code location if -logsourcelocations is set
2021-02-18 14:37:51 +01:00
init.h
Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const
2020-12-06 00:22:40 +00:00
key_io.cpp
Better error messages for invalid addresses
2021-01-24 02:44:53 +01:00
key_io.h
Better error messages for invalid addresses
2021-01-24 02:44:53 +01:00
key.cpp
doc: Use https URLs where possible
2021-01-04 12:23:16 +08:00
key.h
…
logging.cpp
Merge #19809: log: Prefix log messages with function name and source code location if -logsourcelocations is set
2021-02-18 14:37:51 +01:00
logging.h
log: Prefix log messages with function name if -logsourcelocations is set
2021-01-15 09:57:32 +00:00
Makefile.am
Merge #18017: txmempool: split epoch logic into class
2021-02-24 09:57:21 +01:00
Makefile.bench.include
net: Add libnatpmp support
2021-01-07 18:07:09 +02:00
Makefile.crc32c.include
build: Update crc32c subtree
2020-12-08 19:26:30 +01:00
Makefile.leveldb.include
…
Makefile.qt_locale.include
qt: Pre-splitoff translations update
2020-10-27 19:40:44 +01:00
Makefile.qt.include
gui: Add Roboto Mono font
2021-02-21 21:01:02 +02:00
Makefile.qttest.include
net: Add libnatpmp support
2021-01-07 18:07:09 +02:00
Makefile.test_fuzz.include
fuzz: move-only FillNode implementation to cpp file
2021-01-23 20:01:12 +01:00
Makefile.test_util.include
test: Move P2WSH_OP_TRUE to shared test library
2021-02-17 11:36:30 +01:00
Makefile.test.include
Merge #20788: net: add RAII socket and use it instead of bare SOCKET
2021-02-11 14:07:33 +01:00
mapport.cpp
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
mapport.h
net: Add -natpmp command line option
2021-01-07 18:07:09 +02:00
memusage.h
…
merkleblock.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
merkleblock.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
miner.cpp
validation: Pass in chainstate to TestBlockValidity
2021-01-28 14:15:26 -05:00
miner.h
Don't declare de facto const member functions as non-const
2020-12-06 18:44:25 +00:00
net_permissions.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
net_permissions.h
Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers
2020-10-12 12:14:53 -07:00
net_processing.cpp
Merge #20845: net: Log to net debug in MaybeDiscourageAndDisconnect except for noban and manual peers
2021-02-22 09:43:57 +01:00
net_processing.h
[net processing] Move ping data fields to net processing
2021-02-15 16:15:51 +00:00
net_types.h
…
net.cpp
Merge #21222: log: Clarify log message when file does not exist
2021-02-23 16:03:19 +01:00
net.h
[net] Change AdvertiseLocal to GetLocalAddrForPeer
2021-02-18 09:28:06 +00:00
netaddress.cpp
net: allow CSubNet of non-IP networks
2021-01-10 15:51:15 +01:00
netaddress.h
net: create GetNetworkNames()
2021-02-02 00:01:36 +01:00
netbase.cpp
Merge #20965: net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helps
2021-02-15 15:31:15 +01:00
netbase.h
Merge #20965: net, rpc: return NET_UNROUTABLE as not_publicly_routable, automate helps
2021-02-15 15:31:15 +01:00
netmessagemaker.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
noui.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
optional.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
outputtype.cpp
refactor: Use C++17 std::array deduction for OUTPUT_TYPES
2021-01-03 18:37:59 +01:00
outputtype.h
refactor: Use C++17 std::array deduction for OUTPUT_TYPES
2021-01-03 18:37:59 +01:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: init vectors via std::{begin,end} to avoid pointer arithmetic
2021-01-31 17:35:01 +01:00
protocol.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
psbt.cpp
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
psbt.h
scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD
2020-11-26 09:05:59 +00:00
pubkey.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
pubkey.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
random.cpp
refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17)
2021-01-31 17:35:16 +01:00
random.h
…
randomenv.cpp
util: Allow use of C++14 chrono literals
2020-12-08 16:47:36 +01:00
randomenv.h
…
rest.cpp
Merge #20429: refactor: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size
2021-02-18 07:53:37 +01:00
reverse_iterator.h
…
scheduler.cpp
Add include for std::bind.
2021-01-13 02:05:00 +01:00
scheduler.h
refactor: remove boost::thread_group usage
2021-01-29 15:39:44 +08:00
serialize.h
Support bypassing range check in ReadCompactSize
2020-10-09 10:32:19 +02:00
shutdown.cpp
init: only use pipe2 if availabile, check in configure
2021-02-22 14:17:24 +01:00
shutdown.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
signet.cpp
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
signet.h
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
span.h
Merge #19387: span: update constructors to match c++20 draft spec and add lifetimebound attribute
2020-11-25 15:18:33 +01:00
streams.h
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
sync.cpp
refactor: remove straggling boost::mutex usage
2021-01-26 15:57:28 +08:00
sync.h
Merge #20495: sync: Use decltype(auto) return type for WITH_LOCK
2021-01-12 15:56:19 +08:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
timedata.cpp
Avoid the use of abs64 in timedata
2020-10-12 19:50:16 -07:00
timedata.h
…
tinyformat.h
refactor: Improve use of explicit keyword
2020-12-01 18:36:39 +01:00
torcontrol.cpp
Merge #20788: net: add RAII socket and use it instead of bare SOCKET
2021-02-11 14:07:33 +01:00
torcontrol.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
txdb.cpp
txdb: don't reset during in-memory cache resize
2021-02-12 07:53:32 -06:00
txdb.h
txdb: add CCoinsViewDB::ChangeCacheSize
2020-07-01 14:44:24 -04:00
txmempool.cpp
Merge #18017: txmempool: split epoch logic into class
2021-02-24 09:57:21 +01:00
txmempool.h
Merge #18017: txmempool: split epoch logic into class
2021-02-24 09:57:21 +01:00
txrequest.cpp
refactor: Improve use of explicit keyword
2020-12-01 18:36:39 +01:00
txrequest.h
Report and verify expirations
2020-10-12 12:14:53 -07:00
uint256.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
uint256.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
undo.h
…
validation.cpp
Merge #21202: [validation] Two small clang lock annotation improvements
2021-02-22 09:47:15 +01:00
validation.h
style-only: Make CheckSequenceLock signature readable
2021-02-18 14:49:10 -05:00
validationinterface.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
validationinterface.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
version.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
versionbitsinfo.h
…
walletinitinterface.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
warnings.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00