glozow 7583eac43c Merge bitcoin/bitcoin#30617: net: Clarify that m_addr_local is only set once ...

fa6fe43207 net: Clarify that m_addr_local is only set once (MarcoFalke)

Pull request description:

  The function is supposed to be only called once when the version msg arrives (a single time). Calling it twice would be an internal logic bug. However, the `LogError` in this function has many issues:

  * If the error happens in tests, as is the case for the buggy fuzz test, it will go unnoticed
  * It is dead code, unless a bug is introduced to execute it

  Fix all issues by using `Assume(!m_addr_local.IsValid())` instead. Idea taken from https://github.com/bitcoin/bitcoin/pull/30364#discussion_r1680530382

ACKs for top commit:
  achow101:
    ACK fa6fe43207
  mzumsande:
    utACK fa6fe43207
  glozow:
    ACK fa6fe43207

Tree-SHA512: 8c1e8c524768f4f36cc50110ae54ee423e057a963ff78f736f3bf92df1ce5af28e3e0149153780897944e1d5c22ddbca9dac9865d9f4d44afffa152bc8559405

2024-08-13 10:19:19 +01:00

..

util

Fix lint-spelling warnings

2024-07-22 13:59:42 +02:00

addition_overflow.cpp

…

addrman.cpp

random: replace construct/assign with explicit Reseed()

2024-07-01 12:39:57 -04:00

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

…

base_encode_decode.cpp

…

bech32.cpp

fuzz: replace hardcoded numbers for bech32 limits

2024-08-06 11:03:31 +02:00

bip324.cpp

random: convert XoRoShiRo128PlusPlus into full RNG

2024-07-01 10:26:46 -04:00

bitdeque.cpp

…

bitset.cpp

random: convert XoRoShiRo128PlusPlus into full RNG

2024-07-01 10:26:46 -04:00

block_header.cpp

refactor: Hand-replace some uint256S -> uint256

2024-08-05 14:51:47 +02:00

block_index.cpp

…

block.cpp

…

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

…

cluster_linearize.cpp

clusterlin: add MergeLinearizations function + fuzz test + benchmark

2024-08-01 16:03:34 -04:00

coins_view.cpp

coins: pass linked list of flagged entries to BatchWrite

2024-08-05 19:43:56 -04:00

coinscache_sim.cpp

coins: pass linked list of flagged entries to BatchWrite

2024-08-05 19:43:56 -04:00

connman.cpp

…

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

random: convert XoRoShiRo128PlusPlus into full RNG

2024-07-01 10:26:46 -04:00

crypto_chacha20poly1305.cpp

Add fuzz test for FSChaCha20Poly1305

2024-07-15 18:26:45 +05:30

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

fuzz: limit the number of nested wrappers in descriptors

2024-07-14 17:47:40 +02:00

deserialize.cpp

…

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

…

feeratediagram.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

Merge bitcoin/bitcoin#30263: build: Bump clang minimum supported version to 16

2024-07-08 16:20:17 +01:00

fuzz.h

fuzz: Use std::span in FuzzBufferType

2024-06-12 15:21:31 +02:00

FuzzedDataProvider.h

…

golomb_rice.cpp

…

headerssync.cpp

…

hex.cpp

fuzz: increase FromHex() coverage

2024-07-31 16:47:38 +01:00

http_request.cpp

…

i2p.cpp

netbase: extend CreateSock() to support creating arbitrary sockets

2024-06-14 14:23:50 +02:00

integer.cpp

refactor: Hand-replace some uint256S -> uint256

2024-08-05 14:51:47 +02:00

key_io.cpp

…

key.cpp

refactor: remove unused CKey::Negate method

2024-06-03 16:59:43 +02:00

kitchen_sink.cpp

rpc: clarify ALREADY_IN_CHAIN rpc errors

2024-08-05 15:45:58 +01:00

load_external_block_file.cpp

…

locale.cpp

…

merkleblock.cpp

…

message.cpp

…

mini_miner.cpp

fuzz: mini_miner_selection fixups.

2024-07-09 17:22:57 +01:00

miniscript.cpp

refactor: Hand-replace some uint256S -> uint256

2024-08-05 14:51:47 +02:00

minisketch.cpp

…

muhash.cpp

refactor: Hand-replace some uint256S -> uint256

2024-08-05 14:51:47 +02:00

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

net: Clarify that m_addr_local is only set once

2024-08-09 14:05:04 +02:00

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

p2p_handshake.cpp

[fuzz] Harness for version handshake

2024-07-31 13:25:52 +01:00

p2p_transport_serialization.cpp

random: convert XoRoShiRo128PlusPlus into full RNG

2024-07-01 10:26:46 -04:00

package_eval.cpp

scripted-diff: change names from V3 to TRUC

2024-07-02 12:06:07 +01:00

parse_hd_keypath.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

fuzz: Limit parse_univalue input length

2024-07-19 15:39:02 +02:00

partially_downloaded_block.cpp

Merge bitcoin/bitcoin#30237: test: Add Compact Block Encoding test ReceiveWithExtraTransactions covering non-empty extra_txn

2024-07-01 14:11:52 +01:00

policy_estimator_io.cpp

…

policy_estimator.cpp

…

poolresource.cpp

random: convert XoRoShiRo128PlusPlus into full RNG

2024-07-01 10:26:46 -04:00

pow.cpp

…

prevector.cpp

refactor: use c++20 std::views::reverse instead of reverse_iterator.h

2024-08-06 00:23:38 +01:00

primitives_transaction.cpp

…

process_message.cpp

test: [refactor] Pass TestOpts

2024-07-08 16:11:15 +02:00

process_messages.cpp

test: [refactor] Pass TestOpts

2024-07-08 16:11:15 +02:00

protocol.cpp

…

psbt.cpp

…

random.cpp

random: drop ad-hoc Shuffle in favor of std::shuffle

2024-07-06 09:06:36 -04:00

rbf.cpp

fuzz: have package_rbf always make small txns

2024-06-18 10:19:41 -04:00

rolling_bloom_filter.cpp

…

rpc.cpp

test: [refactor] Pass TestOpts

2024-07-08 16:11:15 +02:00

script_assets_test_minimizer.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_parsing.cpp

…

script_sigcache.cpp

fuzz: Deglobalize signature cache in sigcache test

2024-07-19 17:17:02 +02:00

script_sign.cpp

…

script.cpp

[test]: remove ExtractDestination false assertion for ANCHOR script

2024-08-09 11:18:45 +01:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

…

span.cpp

…

string.cpp

util: Catch translation string errors at compile time

2024-07-10 09:40:47 +02:00

strprintf.cpp

…

system.cpp

…

timeoffsets.cpp

refactor: remove warnings globals

2024-06-13 11:20:49 +01:00

torcontrol.cpp

…

transaction.cpp

…

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

scripted-diff: change names from V3 to TRUC

2024-07-02 12:06:07 +01:00

txorphan.cpp

fuzz: Speed up PickValue in txorphan

2024-07-23 10:37:58 +02:00

txrequest.cpp

…

util.cpp

policy: Add OP_1 <0x4e73> as a standard output type

2024-07-30 14:06:58 -04:00

util.h

…

utxo_snapshot.cpp

assumeutxo: Drop block height from metadata

2024-08-08 23:55:06 +02:00

utxo_total_supply.cpp

test: [refactor] Pass TestOpts

2024-07-08 16:11:15 +02:00

validation_load_mempool.cpp

mempool: move LoadMempool/DumpMempool to node

2024-06-26 22:47:09 +00:00

vecdeque.cpp

random: convert XoRoShiRo128PlusPlus into full RNG

2024-07-01 10:26:46 -04:00

versionbits.cpp

…