mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 23:03:45 +01:00

Files

Ava Chow 7db096121d Merge bitcoin/bitcoin#29039 : versionbits refactoring

e3014017ba test: add IsActiveAfter tests for versionbits (Anthony Towns)
60950f77c3 versionbits: docstrings for BIP9Info (Anthony Towns)
7565563bc7 tests: refactor versionbits fuzz test (Anthony Towns)
2e4e9b9608 tests: refactor versionbits unit test (Anthony Towns)
525c00f91b versionbits: Expose VersionBitsConditionChecker via impl header (Anthony Towns)
e74a7049b4 versionbits: Expose StateName function (Anthony Towns)
d00d1ed52c versionbits: Split out internal details into impl header (Anthony Towns)
37b9b67a39 versionbits: Simplify VersionBitsCache API (Anthony Towns)
1198e7d2fd versionbits: Move BIP9 status logic for getblocktemplate to versionbits (Anthony Towns)
b1e967c3ec versionbits: Move getdeploymentinfo logic to versionbits (Anthony Towns)
3bd32c2055 versionbits: Move WarningBits logic from validation to versionbits (Anthony Towns)
5da119e5d0 versionbits: Change BIP9Stats to uint32_t types (Anthony Towns)
a679040ec1 consensus/params: Move version bits period/threshold to bip9 param (Anthony Towns)
e9d617095d versionbits: Remove params from AbstractThresholdConditionChecker (Anthony Towns)
9bc41f1b48 versionbits: Use std::array instead of C-style arrays (Anthony Towns)

Pull request description:

  Increases the encapsulation/modularity of the versionbits code, moving more of the logic into the versionbits module rather than having it scattered across validation and rpc code. Updates unit/fuzz tests to test the actual code used rather than just a close approximation of it.

ACKs for top commit:
  achow101:
    ACK e3014017ba
  TheCharlatan:
    Re-ACK e3014017ba
  darosior:
    ACK e3014017ba

Tree-SHA512: 2978db5038354b56fa1dd6aafd511099e9c16504d6a88daeac2ff2702c87bcf3e55a32e2f0a7697e3de76963b68b9d5ede7976ee007e45862fa306911194496d

2025-04-29 14:06:45 -07:00

test_runner

lint: Add exclusions for libmultiprocess subtree

2025-04-02 08:41:16 -05:00

check-doc.py

Change default help arg to -help and mention -h and -? as alternatives

2024-10-21 11:08:51 +02:00

commit-script-check.sh

lint: commit-script-check.sh: echo to stderr

2024-10-09 18:00:42 +02:00

git-subtree-check.sh

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

lint_ignore_dirs.py

lint: Add exclusions for libmultiprocess subtree

2025-04-02 08:41:16 -05:00

lint-circular-dependencies.py

versionbits: Split out internal details into impl header

2025-01-21 00:38:03 +10:00

lint-files.py

chore: remove redundant word

2025-02-13 22:09:55 +08:00

lint-include-guards.py

test: Refactor subtree exclusion in lint tests

2024-03-26 13:49:47 +03:00

lint-includes.py

Remove wallet::ParseISO8601DateTime, use ParseISO8601DateTime instead

2024-12-02 15:09:31 +01:00

lint-locale-dependence.py

lint: Add exclusions for libmultiprocess subtree

2025-04-02 08:41:16 -05:00

lint-python-dead-code.py

lint: Convert Python dead code linter to Python

2022-04-06 00:55:22 +02:00

lint-python-utf8-encoding.py

lint: Ignore check_fileopens failure on **kwargs

2023-07-20 09:15:43 +02:00

lint-python.py

lint: Speed up flake8 checks

2024-08-29 07:03:42 +02:00

lint-qt-translation.py

lint: Add lint-qt-translation.py

2023-10-23 15:07:02 +01:00

lint-shell-locale.py

refactor: cleanups post unsubtree'ing univalue

2022-06-15 12:56:44 +01:00

lint-shell.py

lint: Include test_utxo_snapshots in lint_shell

2023-10-13 14:06:06 +02:00

lint-spelling.py

doc: Updating docs from autotools to cmake

2024-09-18 11:04:52 -04:00

lint-submodule.py

scripted-diff: Use new python 3.7 keywords

2023-01-18 13:00:34 +01:00

lint-tests.py

scripted-diff: Use new python 3.7 keywords

2023-01-18 13:00:34 +01:00

README.md

doc: update location of minisketch repository

2025-03-05 14:13:53 +00:00

spelling.ignore-words.txt

Update spelling.ignore-words

2024-08-28 18:42:19 +02:00

README.md

This folder contains lint scripts.

Running locally

To run linters locally with the same versions as the CI environment, use the included Dockerfile:

DOCKER_BUILDKIT=1 docker build -t bitcoin-linter --file "./ci/lint_imagefile" ./ && docker run --rm -v $(pwd):/bitcoin -it bitcoin-linter

Building the container can be done every time, because it is fast when the result is cached and it prevents issues when the image changes.

test runner

To run all the lint checks in the test runner outside the docker you first need to install the rust toolchain using your package manager of choice or rustup.

Then you can use:

( cd ./test/lint/test_runner/ && cargo fmt && cargo clippy && RUST_BACKTRACE=1 cargo run )

If you wish to run individual lint checks, run the test_runner with --lint=TEST_TO_RUN arguments. If running with cargo run, arguments after -- are passed to the binary you are running e.g.:

( cd ./test/lint/test_runner/ && RUST_BACKTRACE=1 cargo run -- --lint=doc --lint=trailing_whitespace )

To see a list of all individual lint checks available in test_runner, use -h or --help:

( cd ./test/lint/test_runner/ && RUST_BACKTRACE=1 cargo run -- --help )

Dependencies

Lint test	Dependency
`lint-python.py`	lief
`lint-python.py`	mypy
`lint-python.py`	pyzmq
`lint-python-dead-code.py`	vulture
`lint-shell.py`	ShellCheck
`lint-spelling.py`	codespell
`py_lint`	ruff
markdown link check	mlc

In use versions and install instructions are available in the CI setup.

Please be aware that on Linux distributions all dependencies are usually available as packages, but could be outdated.

Running the tests

Individual tests can be run by directly calling the test script, e.g.:

test/lint/lint-files.py

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs. Scripted diffs are only assumed to run on the latest LTS release of Ubuntu. Running them on other operating systems might require installing GNU tools, such as GNU sed.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

Usage: test/lint/git-subtree-check.sh [-r] DIR [COMMIT]
       test/lint/git-subtree-check.sh -?

DIR is the prefix within the repository to check.
COMMIT is the commit to check, if it is not provided, HEAD will be used.
-r checks that subtree commit is present in repository.

To do a full check with -r, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb-subtree.git (branch bitcoin-fork)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)
for src/crc32c: https://github.com/bitcoin-core/crc32c-subtree.git (branch bitcoin-fork)
for src/minisketch: https://github.com/bitcoin-core/minisketch.git (branch master)

To do so, add the upstream repository as remote:

git remote add --fetch secp256k1 https://github.com/bitcoin-core/secp256k1.git

lint_ignore_dirs.py

Add list of common directories to ignore when running tests