fanquake 6ddf435493 Merge #18274: rpc/wallet: initialize nFeeRequired to avoid using garbage value on failure ...

a652ba6293 rpc/wallet: initialize nFeeRequired to avoid using garbage value on failure (Karl-Johan Alm)

Pull request description:

  Initialize the `nFeeRequired` variable to avoid using an uninitialized value for errors happening before it is set to 0.

  Note: this originally fixed `nFeeRet` in `wallet.cpp`.

ACKs for top commit:
  promag:
    ACK a652ba6293.
  Sjors:
    utACK a652ba6293
  practicalswift:
    ACK a652ba6293 -- patch looks correct
  meshcollider:
    utACK a652ba6293

Tree-SHA512: 0d12f1ffd0851ed5ce6d109d2c87f55e8b1d57da297e684feeabb57229200c4078f029c55ca5aa5712bd18e26dda3ce538443dfe68a7a6d504428068f81fded0

2020-03-09 19:17:51 +08:00

..

test

test: Add cost_of_change parameter assertions to bnb_search_test

2020-02-22 11:11:09 -06:00

coincontrol.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

coincontrol.h

refactor: Nuke coincontrol circular dependency

2019-11-23 08:30:03 +02:00

coinselection.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

coinselection.h

amount: Move CAmount CENT to unit test header

2018-09-17 14:34:56 -04:00

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

db.cpp

Merge #18241: wallet/refactor: refer to CWallet immutably when possible

2020-03-07 07:24:54 +08:00

db.h

wallet/db: make IsDummy() const

2020-03-02 17:26:30 +09:00

feebumper.cpp

Refactor FormatStateMessage into ValidationState

2020-02-27 17:59:07 -08:00

feebumper.h

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

Merge #13339: wallet: Replace %w by wallet name in -walletnotify script

2020-02-17 11:59:23 +01:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

wallet: Avoid showing GUI popups on RPC errors

2019-10-08 13:02:14 -04:00

load.h

wallet: Fix documentation around WalletParameterInteraction

2019-09-03 14:10:25 -04:00

psbtwallet.cpp

Merge #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple

2020-01-30 17:21:21 +13:00

psbtwallet.h

Merge #17264: rpc: set default bip32derivs to true for psbt methods

2020-02-25 23:50:39 +13:00

rpcdump.cpp

Merge #18241: wallet/refactor: refer to CWallet immutably when possible

2020-03-07 07:24:54 +08:00

rpcwallet.cpp

Merge #18274: rpc/wallet: initialize nFeeRequired to avoid using garbage value on failure

2020-03-09 19:17:51 +08:00

rpcwallet.h

Refactor: Allow LegacyScriptPubKeyMan to be null

2020-01-23 16:34:28 -05:00

scriptpubkeyman.cpp

wallet/spkm: make GetOldestKeyPoolTime() const

2020-03-02 17:26:31 +09:00

scriptpubkeyman.h

wallet/spkm: make GetOldestKeyPoolTime() const

2020-03-02 17:26:31 +09:00

wallet.cpp

wallet: make BackupWallet() const

2020-03-02 17:27:35 +09:00

wallet.h

wallet: make ReserveDestination pwallet ivar const

2020-03-02 17:27:35 +09:00

walletdb.cpp

Refactor: Allow LegacyScriptPubKeyMan to be null

2020-01-23 16:34:28 -05:00

walletdb.h

Fix doxygen errors

2020-01-16 18:25:11 -08:00

wallettool.cpp

Refactor: Allow LegacyScriptPubKeyMan to be null

2020-01-23 16:34:28 -05:00

wallettool.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

walletutil.cpp

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

walletutil.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00