highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-20 23:02:13 +01:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
fanquake 9f650062fc
Merge bitcoin/bitcoin#26005: Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces) 
c3e536555aa3a7db773170671da1256a2ace2094 Bugfix: Wallet: Return util::Error rather than non-error nullptr when CreateWallet/LoadWallet/RestoreWallet fail (Luke Dashjr)
335ff98c8a64eda38a2a2334102bd253f108c253 Bugfix: Wallet: Wrap RestoreWallet content in a try block to ensure exceptions become returned errors and incomplete wallet directory is removed (Luke Dashjr)

Pull request description:

  Bug 1: `copy_file` can throw exceptions, but `RestoreWallet` is expected to return a nullptr with a populated `errors` parameter. This is fixed by wrapping `copy_file` and `LoadWallet` (for good measure) in a `try` block, and converting any exceptions to the intended return style.

  Bug 2: `util::Result` turns what would have been a `false` unique_ptr into a `true` nullptr result, which leads to nullptr dereferences in at least the 3 cases of wallet creation/loading/restoring. This is fixed by keeping the pointer as a plain `std::unique_ptr` until actually returning it (ie, after the nullptr check).

  Fixes https://github.com/bitcoin-core/gui/issues/661

ACKs for top commit:
  achow101:
    ACK c3e536555aa3a7db773170671da1256a2ace2094

Tree-SHA512: 4291b3dbbb147acea2e63a704324c9371bc16ecb4237f8753729b0b0a6e55c9758ad61bfe8bd432fd7b0bae95d8b63a9831e61ac8b8d5c0197b550a2e0f4a105
2022-09-19 16:10:47 +01:00
..
bench
Merge bitcoin/bitcoin#25734: wallet, refactor: #24584 follow-ups
2022-08-16 20:00:19 -04:00
common
…
compat
compat: document redefining ssize_t when using MSVC
2022-07-20 13:10:12 +01:00
config
…
consensus
Require callers of AcceptBlockHeader() to perform anti-dos checks
2022-08-29 08:10:35 -04:00
crc32c
Update crc32c subtree to latest upstream master
2022-08-13 13:55:38 +01:00
crypto
Use HashWriter where possible
2022-07-20 15:34:36 +02:00
index
refactor: use std::string for index names
2022-09-13 19:10:41 +01:00
init
Update -debug and -debugexclude help docs for severity level logging
2022-08-20 11:55:17 +02:00
interfaces
Make validation interface capable of signalling header presync
2022-08-29 08:10:35 -04:00
ipc
…
kernel
scripted-diff: rename CChainState -> Chainstate
2022-09-09 11:47:27 -04:00
leveldb
Update leveldb-subtree subtree to latest upstream
2022-07-29 14:43:11 +01:00
logging
…
minisketch
Update minisketch subtree to latest master
2022-06-29 16:35:02 +01:00
node
scripted-diff: rename CChainState -> Chainstate
2022-09-09 11:47:27 -04:00
policy
fixups for BIP125 doc cleanup
2022-08-22 14:59:58 +01:00
primitives
CBlockLocator: performance-move-const-arg Clang tidy fixups
2022-08-31 15:10:26 +02:00
qt
Merge bitcoin/bitcoin#25971: refactor: Use std::string for thread and index names
2022-09-16 12:39:39 +02:00
rpc
Merge bitcoin/bitcoin#25499: Use steady clock for all millis bench logging
2022-09-16 11:10:15 +01:00
script
Make miniscript string parsing account for exact script size as bound
2022-09-17 15:12:48 +02:00
secp256k1
Update secp256k1 subtree to latest upstream master
2022-06-11 14:55:18 +01:00
support
build: globally define NOMINMAX
2022-06-20 12:22:05 +01:00
test
Permit delaying duplicate key check in miniscript::Node construction
2022-09-17 10:47:05 +02:00
univalue
Fix issues when calling std::move(const&)
2022-08-20 09:32:53 +02:00
util
scripted-diff: rename pszThread to thread_name
2022-09-14 11:00:14 +01:00
wallet
Merge bitcoin/bitcoin#26005: Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces)
2022-09-19 16:10:47 +01:00
zmq
build: prune BOOST_CPPFLAGS from libbitcoin_zmq
2022-09-14 09:33:34 +01:00
.bear-tidy-config
tidy: enable modernize-use-nullptr
2022-04-26 10:43:33 +01:00
.clang-format
…
.clang-tidy
Merge bitcoin/bitcoin#25872: Fix issues when calling std::move(const&)
2022-08-31 08:38:24 +01:00
addrdb.cpp
Use steady clock for all millis bench logging
2022-07-30 10:23:58 +02:00
addrdb.h
…
addrman_impl.h
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
addrman.cpp
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
addrman.h
addrman: Use system time instead of adjusted network time
2022-07-30 11:04:09 +02:00
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
Use steady clock for all millis bench logging
2022-07-30 10:23:58 +02:00
banman.h
refactor: Add thread safety annotation to BanMan::SweepBanned()
2022-05-20 15:17:00 +02:00
base58.cpp
scripted-diff: Rename ValidAsCString to ContainsNoNUL
2022-04-27 14:16:35 +02:00
base58.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
bech32.cpp
…
bech32.h
…
bitcoin-chainstate.cpp
scripted-diff: rename CChainState -> Chainstate
2022-09-09 11:47:27 -04:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks
2022-08-19 17:11:06 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
build: remove BOOST_CPPFLAGS usage from bitcoin-tx
2022-09-14 09:10:04 +01:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
bitcoind-res.rc
…
bitcoind.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
blockencodings.cpp
Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
2022-05-17 10:37:10 +01:00
blockencodings.h
Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
2022-05-17 10:37:10 +01:00
blockfilter.cpp
Use new Join() helper for ListBlockFilterTypes()
2022-08-24 10:15:32 +02:00
blockfilter.h
refactor: add LIFETIMEBOUND to blockfilter where needed
2022-08-31 16:51:32 +01:00
chain.cpp
CBlockLocator: performance-move-const-arg Clang tidy fixups
2022-08-31 15:10:26 +02:00
chain.h
Add functions to construct locators without CChain
2022-08-23 16:05:00 -04:00
chainparams.cpp
Update chainparams for 24.0 release
2022-08-31 15:31:34 +03:00
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
Merge bitcoin/bitcoin#25853: net: update testnet torv3 hardcoded seeds for 24.x
2022-09-09 10:07:39 +02:00
checkqueue.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks
2022-08-19 17:11:06 +02:00
coins.h
refactor: remove unused methods {CDBIterator,CCoinsViewDBCursor}::GetValueSize()
2022-06-21 16:19:10 +02:00
compressor.cpp
…
compressor.h
…
core_io.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
core_memusage.h
…
core_read.cpp
refactor: Make const refs vars where applicable
2022-07-27 13:27:57 +02:00
core_write.cpp
…
cuckoocache.h
validationcaches: Use size_t for sizes
2022-08-03 12:03:28 -04:00
dbwrapper.cpp
Remove unused includes from dbwrapper.h
2022-07-19 14:32:53 +02:00
dbwrapper.h
Remove unused includes from dbwrapper.h
2022-07-19 14:32:53 +02:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
validation: move g_versionbitscache into ChainstateManager
2022-05-10 12:09:33 +10:00
deploymentstatus.h
validation: move g_versionbitscache into ChainstateManager
2022-05-10 12:09:33 +10:00
dummywallet.cpp
…
external_signer.cpp
refactor: Make const refs vars where applicable
2022-07-27 13:27:57 +02:00
external_signer.h
…
flatfile.cpp
…
flatfile.h
…
fs.cpp
fs: fully initialize _OVERLAPPED for win32
2022-09-14 11:55:10 +01:00
fs.h
fs: work around u8path deprecated-declaration warnings with libc++
2022-08-19 08:58:56 +01:00
hash.cpp
Fix link to MurmurHash3.cpp from Austin Appleby
2022-08-30 13:52:45 +02:00
hash.h
Use HashWriter where possible
2022-07-20 15:34:36 +02:00
headerssync.cpp
Move headerssync logging to BCLog::NET
2022-08-30 12:09:04 -04:00
headerssync.h
Track headers presync progress and log it
2022-08-29 08:10:35 -04:00
httprpc.cpp
scripted-diff: Use getInt<T> over get_int/get_int64
2022-05-18 19:15:03 +02:00
httprpc.h
…
httpserver.cpp
Prevent data race for pathHandlers
2022-09-02 12:50:12 +01:00
httpserver.h
…
i2p.cpp
i2p: use the same destination type for transient and persistent addresses
2022-09-12 12:55:36 +02:00
i2p.h
i2p: add support for creating transient sessions
2022-08-11 17:51:18 +02:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#25499: Use steady clock for all millis bench logging
2022-09-16 11:10:15 +01:00
init.h
Move init::SanityCheck to kernel::SanityCheck
2022-06-02 11:42:12 -04:00
key_io.cpp
…
key_io.h
…
key.cpp
extended keys: fail to derive too large depth instead of wrapping around
2022-08-04 11:32:26 +02:00
key.h
(pubk)key: mark Derive() as nodiscard
2022-08-04 11:32:25 +02:00
logging.cpp
Merge bitcoin/bitcoin#25614: Severity-based logging, step 2
2022-09-01 15:57:56 -04:00
logging.h
Move headerssync logging to BCLog::NET
2022-08-30 12:09:04 -04:00
Makefile.am
Merge bitcoin/bitcoin#26087: build: prune BOOST_CPPFLAGS from libbitcoin_zmq
2022-09-16 14:53:53 +01:00
Makefile.bench.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.crc32c.include
build: Create .la library for crc32c
2022-04-26 16:25:38 -04:00
Makefile.leveldb.include
Use more specific path when including memenv.h header
2022-06-23 15:33:01 +02:00
Makefile.minisketch.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.qttest.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.test_fuzz.include
build: remove unused libevent cppflags
2022-09-15 09:30:26 +01:00
Makefile.test_util.include
build: remove unused libevent cppflags
2022-09-15 09:30:26 +01:00
Makefile.test.include
build: extract $(BOOST_CPPFLAGS) from $(BITCOIN_INCLUDES)
2022-09-13 17:15:17 +01:00
Makefile.univalue.include
…
mapport.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Bypass headers anti-DoS checks for NoBan peers
2022-08-30 14:11:21 -04:00
net_processing.h
Expose HeadersSyncState::m_current_height in getpeerinfo()
2022-08-29 08:10:35 -04:00
net_types.cpp
scripted-diff: Use getInt<T> over get_int/get_int64
2022-05-18 19:15:03 +02:00
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#25499: Use steady clock for all millis bench logging
2022-09-16 11:10:15 +01:00
net.h
scripted-diff: net: rename permissionFlags to permission_flags
2022-09-01 20:55:22 +10:00
netaddress.cpp
refactor: use C++11 default initializers
2022-05-17 17:18:58 +01:00
netaddress.h
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
netbase.cpp
refactor: Make const refs vars where applicable
2022-07-27 13:27:57 +02:00
netbase.h
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
noui.h
…
outputtype.cpp
Merge bitcoin/bitcoin#25734: wallet, refactor: #24584 follow-ups
2022-08-16 20:00:19 -04:00
outputtype.h
wallet: remove UNKNOWN type from OUTPUT_TYPES array
2022-08-18 16:47:15 -03:00
pow.cpp
Add function to validate difficulty changes
2022-08-23 11:34:10 -04:00
pow.h
Add function to validate difficulty changes
2022-08-23 11:34:10 -04:00
prevector.h
Merge bitcoin/bitcoin#24962: prevector: enforce is_trivially_copyable_v
2022-05-16 16:25:47 +02:00
protocol.cpp
refactor: use strprintf for creating unknown-service-flag string
2022-08-20 15:11:28 +02:00
protocol.h
refactor: Use type-safe std::chrono for addrman time
2022-07-26 11:06:10 +02:00
psbt.cpp
psbt: Implement merge for Taproot fields
2022-06-27 16:47:48 -04:00
psbt.h
psbt: Avoid unsigned int overflow in PSBT_IN_TAP_BIP32_DERIVATION
2022-08-10 11:58:17 -04:00
pubkey.cpp
Merge bitcoin/bitcoin#25642: Don't wrap around when deriving an extended key at a too large depth
2022-08-10 14:25:43 -04:00
pubkey.h
(pubk)key: mark Derive() as nodiscard
2022-08-04 11:32:25 +02:00
random.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
random.h
refactor: Make FEELER_SLEEP_WINDOW type safe (std::chrono)
2022-07-13 15:21:12 +02:00
randomenv.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
randomenv.h
…
rest.cpp
Fix logical race in rest_getutxos
2022-08-16 17:26:28 +02:00
rest.h
…
reverse_iterator.h
…
scheduler.cpp
refactor: use C++11 default initializers
2022-05-17 17:18:58 +01:00
scheduler.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
serialize.h
Add ChronoFormatter to serialize
2022-07-26 11:05:04 +02:00
shutdown.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
shutdown.h
…
signet.cpp
…
signet.h
…
span.h
scripted-diff: rename BytePtr to AsBytePtr
2022-04-26 09:41:45 +01:00
streams.h
streams: Add AutoFile without ser-type and ser-version
2022-06-29 10:31:53 +02:00
sync.cpp
…
sync.h
refactor: Remove trailing semicolon from LOCK2
2022-08-12 14:10:43 +02:00
threadinterrupt.cpp
Expose underlying clock in CThreadInterrupt
2022-07-13 15:20:49 +02:00
threadinterrupt.h
Fix iwyu
2022-08-20 09:33:01 +02:00
threadsafety.h
…
timedata.cpp
Make adjusted time type safe
2022-08-05 14:59:15 +02:00
timedata.h
Make adjusted time type safe
2022-08-05 14:59:15 +02:00
tinyformat.h
…
torcontrol.cpp
refactor: move compat.h into compat/
2022-07-20 10:34:46 +01:00
torcontrol.h
…
txdb.cpp
CDiskBlockIndex: rename GetBlockHash() to ConstructBlockHash()
2022-07-22 12:45:07 +02:00
txdb.h
Add missing includes
2022-07-19 14:12:33 +02:00
txmempool.cpp
[mempool] replace update_descendant_state with lambda
2022-09-09 11:08:02 +01:00
txmempool.h
scripted-diff: rename CChainState -> Chainstate
2022-09-09 11:47:27 -04:00
txorphanage.cpp
refactor: log nEvicted message in LimitOrphans then return void
2022-07-28 14:39:45 +08:00
txorphanage.h
refactor: log nEvicted message in LimitOrphans then return void
2022-07-28 14:39:45 +08:00
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
Use ReadLE64 in uint256::GetUint64() instead of duplicating logic
2022-09-15 16:48:50 -04:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#25499: Use steady clock for all millis bench logging
2022-09-16 11:10:15 +01:00
validation.h
scripted-diff: rename CChainState -> Chainstate
2022-09-09 11:47:27 -04:00
validationinterface.cpp
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
validationinterface.h
scripted-diff: Rename MainSignalsInstance() class to MainSignalsImpl()
2022-05-09 18:35:44 +02:00
version.h
…
versionbits.cpp
Sanity assert GetAncestor() != nullptr where appropriate
2022-05-05 15:55:44 +02:00
versionbits.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
walletinitinterface.h
…
warnings.cpp
scripted-diff: Convert global Mutexes to GlobalMutexes
2022-05-21 01:23:23 +10:00
warnings.h
…