mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-06-06 11:13:02 +02:00
99ecb9a630
f550a8e035Rename ReleaseWallet to FlushAndDeleteWallet (furszy)64e736d79ewallet: WaitForDeleteWallet, do not expect thread safety (Ryan Ofsky)8872b4a6cawallet: rename UnloadWallet to WaitForDeleteWallet (furszy)5d15485aafwallet: unload, notify GUI as soon as possible (furszy) Pull request description: Coming from #29073. Applied ryanofsky suggested changes on https://github.com/bitcoin/bitcoin/issues/29073#issuecomment-2274237242 with few modifications coming from https://github.com/bitcoin/bitcoin/pull/18338#issuecomment-605060348. The only point I did not tackle from https://github.com/bitcoin/bitcoin/pull/18338#issuecomment-605060348 is: > * Move log print and flush out of ReleaseWallet into CWallet destructor Because it would mean every `CWallet` object would flush data to disk during destruction. Which is not necessary for wallet tool utilities and unit tests. ACKs for top commit: achow101: ACKf550a8e035ryanofsky: Code review ACKf550a8e035. Just a simple rename since last review ismaelsadeeq: Re-ACKf550a8e035Tree-SHA512: e2eb69bf36883c514f601f4838ae6a41113996b9559abf8dc2b46e16bbcdad401195ac0f2b9d1fb55a10e78bb8ea9953788a168c80474e3f101350d208cb3bd2