highperfocused/danswer
1
0
Fork 0
mirror of https://github.com/danswer-ai/danswer.git synced 2025-04-08 11:58:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix editing deleted personas, editing personas with no prompts, and model selection

Browse Source
This commit is contained in:
Weves 2023-12-19 14:39:55 -08:00 committed by Chris Weaver
parent 24a62cb33d
commit 370760eeee
3 changed files with 38 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
backend/danswer/db/chat.py
View File

@ -472,6 +472,7 @@ def upsert_persona(
persona.recency_bias = recency_bias
persona.default_persona = default_persona
persona.llm_model_version_override = llm_model_version_override
persona.deleted = False # Un-delete if previously deleted
# Do not delete any associations manually added unless
# a new updated list is provided

2
web/src/app/admin/personas/PersonaEditor.tsx
View File

@ -152,7 +152,7 @@ export function PersonaEditor({
if (isUpdate) {
[promptResponse, personaResponse] = await updatePersona({
id: existingPersona.id,
existingPromptId: existingPrompt!.id,
existingPromptId: existingPrompt?.id,
...values,
num_chunks: numChunks,
});

56
web/src/app/admin/personas/lib.ts
View File

@ -8,11 +8,12 @@ interface PersonaCreationRequest {
document_set_ids: number[];
num_chunks: number | null;
llm_relevance_filter: boolean | null;
llm_model_version_override: string | null;
}
interface PersonaUpdateRequest {
id: number;
existingPromptId: number;
existingPromptId: number | undefined;
name: string;
description: string;
system_prompt: string;
@ -20,6 +21,7 @@ interface PersonaUpdateRequest {
document_set_ids: number[];
num_chunks: number | null;
llm_relevance_filter: boolean | null;
llm_model_version_override: string | null;
}
function promptNameFromPersonaName(personaName: string) {
@ -98,6 +100,7 @@ function buildPersonaAPIBody(
recency_bias: "base_decay",
prompt_ids: [promptId],
document_set_ids,
llm_model_version_override: creationRequest.llm_model_version_override,
};
}
@ -133,29 +136,42 @@ export async function createPersona(
export async function updatePersona(
personaUpdateRequest: PersonaUpdateRequest
): Promise<[Response, Response | null]> {
const { id, existingPromptId, ...requestBody } = personaUpdateRequest;
const { id, existingPromptId } = personaUpdateRequest;
// first update prompt
const updatePromptResponse = await updatePrompt({
promptId: existingPromptId,
personaName: personaUpdateRequest.name,
systemPrompt: personaUpdateRequest.system_prompt,
taskPrompt: personaUpdateRequest.task_prompt,
});
let promptResponse;
let promptId;
if (existingPromptId !== undefined) {
promptResponse = await updatePrompt({
promptId: existingPromptId,
personaName: personaUpdateRequest.name,
systemPrompt: personaUpdateRequest.system_prompt,
taskPrompt: personaUpdateRequest.task_prompt,
});
promptId = existingPromptId;
} else {
promptResponse = await createPrompt({
personaName: personaUpdateRequest.name,
systemPrompt: personaUpdateRequest.system_prompt,
taskPrompt: personaUpdateRequest.task_prompt,
});
promptId = promptResponse.ok ? (await promptResponse.json()).id : null;
}
const updatePersonaResponse = updatePromptResponse.ok
? await fetch(`/api/admin/persona/${id}`, {
method: "PATCH",
headers: {
"Content-Type": "application/json",
},
body: JSON.stringify(
buildPersonaAPIBody(personaUpdateRequest, existingPromptId)
),
})
: null;
const updatePersonaResponse =
promptResponse.ok && promptId
? await fetch(`/api/admin/persona/${id}`, {
method: "PATCH",
headers: {
"Content-Type": "application/json",
},
body: JSON.stringify(
buildPersonaAPIBody(personaUpdateRequest, promptId)
),
})
: null;
return [updatePromptResponse, updatePersonaResponse];
return [promptResponse, updatePersonaResponse];
}
export function deletePersona(personaId: number) {