highperfocused/ffmpeg
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext"

Browse Source 
This reverts commit f631c328e680a3dd491936b92f69970c20cdcfc7.

The avcodec_parameters_to_context() call was freeing and reallocating
AVCodecContext->extradata, essentially taking ownership of it, which according
to the doxy is user owned. This is an API break and has produced crashes in
some library users like Firefox[1].

Revert until a better solution is found to internally propagate the filtered
extradata back into the decoder context, or a decision is made to change the
API.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1486080

Signed-off-by: James Almer <jamrial@gmail.com>
This commit is contained in:
James Almer 2018-09-12 15:01:14 -03:00
parent 156120fcf8
commit 87588caf8c
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libavcodec/decode.c
View File

@ -281,10 +281,6 @@ int ff_decode_bsfs_init(AVCodecContext *avctx)
bsfs_str++;
}
ret = avcodec_parameters_to_context(avctx, s->bsfs[s->nb_bsfs - 1]->par_out);
if (ret < 0)
return ret;
return 0;
fail:
ff_decode_bsfs_uninit(avctx);