refactor: rename is_uncheckable (#2670)

it actually means is_internal and internal payments cant fail so we return success status
This commit is contained in:
dni ⚡ 2024-09-16 17:34:30 +02:00 committed by GitHub
parent d229b7a765
commit d26e50ec9a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -21,8 +21,8 @@ from lnbits.settings import settings
from lnbits.utils.exchange_rates import allowed_currencies
from lnbits.wallets import get_funding_source
from lnbits.wallets.base import (
PaymentPendingStatus,
PaymentStatus,
PaymentSuccessStatus,
)
@ -285,12 +285,12 @@ class Payment(FromRowModel):
return self.expiry < time.time() if self.expiry else False
@property
def is_uncheckable(self) -> bool:
def is_internal(self) -> bool:
return self.checking_id.startswith("internal_")
async def check_status(self) -> PaymentStatus:
if self.is_uncheckable:
return PaymentPendingStatus()
if self.is_internal:
return PaymentSuccessStatus()
funding_source = get_funding_source()
if self.is_out:
status = await funding_source.get_payment_status(self.checking_id)