highperfocused/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-11-09 21:56:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

itest: check for config addrs precedence

Browse Source 
In this commit, we update the itest to check for precedence of the
config addresses over the persisted addresses.

We did not check for address persistence after restart (without the
extraArgs `--externalip`) because in `lntest/node/config.goL300`,
`GenArg` by default sets the `--externalip` flag, which makes
the config addrs to always take precedence over the persisted
addrs, for the tests.
This commit is contained in:
Abdullahi Yunus
2025-09-22 21:39:58 +01:00
parent cf287e9693
commit 141cc571ab
1 changed files with 17 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
itest/lnd_channel_graph_test.go
View File

@@ -728,25 +728,7 @@ func testSelfNodeAnnouncementPersistence(ht *lntest.HarnessTest) {
}
assertUpdateNodeAnnouncementResponse(ht, response, expectedOps)
resp = alice.RPC.GetInfo()
assertNodeInfo(
resp, "alice", "#eeeeee", "192.168.1.10:8333",
"192.168.1.11:8333",
)
// Restart Alice.
ht.RestartNode(alice)
// After restarting, the node info should contain the values that were
// set in the update request since the updated values take precedence
// over the default values.
resp = alice.RPC.GetInfo()
assertNodeInfo(
resp, "alice", "#eeeeee", "192.168.1.10:8333",
"192.168.1.11:8333",
)
// Test that we can still remove an address.
// Test that we can remove an address.
removeAddrReq := &peersrpc.NodeAnnouncementUpdateRequest{
AddressUpdates: []*peersrpc.UpdateAddressAction{
{
@@ -761,6 +743,20 @@ func testSelfNodeAnnouncementPersistence(ht *lntest.HarnessTest) {
}
assertUpdateNodeAnnouncementResponse(ht, response, expectedOps)
resp = alice.RPC.GetInfo()
assertNodeInfo(
resp, "alice", "#eeeeee", "192.168.1.11:8333",
)
// Restart Alice.
ht.RestartNode(alice)
// After restarting, the node info should contain the values that were
// set in the update request since the updated values take precedence
// over the default values.
resp = alice.RPC.GetInfo()
assertNodeInfo(resp, "alice", "#eeeeee")
// Now we restart the node with custom values in the config.
lndArgs := []string{
"--externalip=192.168.1.12:8333",
@@ -772,16 +768,11 @@ func testSelfNodeAnnouncementPersistence(ht *lntest.HarnessTest) {
// Get the node info and verify that the values are the same as the
// ones we set in the config (and not the updated values).
// The addresses should be the same as the ones we set in the config
// plus the ones we set in the update request earlier.
resp = alice.RPC.GetInfo()
assertNodeInfo(
resp, "alice-updated", "#ffffff", "192.168.1.11:8333",
"192.168.1.12:8333", "192.168.1.13:8333",
resp, "alice-updated", "#ffffff", "192.168.1.12:8333",
"192.168.1.13:8333",
)
// The address we removed earlier should not be present.
require.Error(ht, assertAddrs(resp.Uris, "192.168.1.10:8333"))
}
// assertSyncType asserts that the peer has an expected syncType.