Merge pull request #5839 from ellemouton/noDuplicateConnsForDupAddrs

server: use deduped addrMap for connReq creation

docs/release-notes/release-notes-0.14.0.md

@@ -464,6 +464,9 @@ you.
   certain channels couldn't be passed to `lncli getchaninfo` due to their 8-byte 
   compact ID being too large for an int64. 
 
+* [Dedup stored peer addresses before creating connection requests to prevent
+  redundant connection requests](https://github.com/lightningnetwork/lnd/pull/5839)
+
 ## Documentation 
 
 The [code contribution guidelines have been updated to mention the new

server.go

@@ -3771,11 +3771,7 @@ func (s *server) connectToPersistentPeer(pubKeyStr string) {
 
 	// Any addresses left in addrMap are new ones that we have not made
 	// connection requests for. So create new connection requests for those.
-	for _, addr := range s.persistentPeerAddrs[pubKeyStr] {
-		if _, ok := addrMap[addr.String()]; !ok {
-			continue
-		}
-
+	for _, addr := range addrMap {
 		connReq := &connmgr.ConnReq{
 			Addr:      addr,
 			Permanent: true,